From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7682433A7 for ; Thu, 23 Nov 2023 11:52:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA884402A6; Thu, 23 Nov 2023 11:52:47 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 695164026B for ; Thu, 23 Nov 2023 11:52:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700736765; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BHT5pkhrsGEEdmT3riHaKtEek2S19OXndheSCRQnG3E=; b=HI5O7/oXLEJMTCjA8nG+BxdlAG0Z97AiwqkBTnIQSoBjUfffLujAqckenglyD2XIGWEaEo 0zm1Mv6f2ak2AsZ4eyXWBRa5/po73nNS3mfJJ7K/DJoBGBZMWkxRdmA8B8XvbzlQDGGSZB E6IWQI3umWudiNhQvyNgMIi6yNowKdA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-508-B93oSVOpNpKaNAOp0WJkLQ-1; Thu, 23 Nov 2023 05:52:43 -0500 X-MC-Unique: B93oSVOpNpKaNAOp0WJkLQ-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-40b32faeb7eso3758855e9.1 for ; Thu, 23 Nov 2023 02:52:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700736762; x=1701341562; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BHT5pkhrsGEEdmT3riHaKtEek2S19OXndheSCRQnG3E=; b=sQeVDu+UMopQFutQhqMf5RI3Zk+bTJSkcb1GCAKkLi4cNXsRuy1+pSVx3AbtRbCADH cnwzxAT2q5iFbX+cMzBgXJODKCneFabsqafPn+eybmm/dzL3h03EI8QXrMdkpbTSE2cB hafeVQn5i3cxpdaPAlF5/140nM772ftf6wy116jZI10r5L8OSGwUpRo2EanTTlM8Gi7p EAnj+Szxz37jBbKsOcQWX4bq+lsk5x2/541/h+LlbEu9h+IgjvLFo/encLVRnJ6lp3n3 OFb52HiJ0XcKFbRlFhYwzRJHhDxMQke2nFayUEZSYbpPUbQcIhoBy4WZ3Zkshtupo4uU Qcmg== X-Gm-Message-State: AOJu0YzgGEiuonAvYm1cN/MJQlPtw9eFSboTunZuL+qx3FdYkVxnxPUj VqyTErQ7ro/l7FZ5GXvgvEPC1k1R0HrjhFsqJCwcGYmye6uygjlQCEf+4Xd5EV+niDG7yI9F3hR af080r/s= X-Received: by 2002:a05:600c:4f44:b0:40a:4429:a994 with SMTP id m4-20020a05600c4f4400b0040a4429a994mr3762139wmq.28.1700736762317; Thu, 23 Nov 2023 02:52:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IE8TMyuZF+OrH1F0cdSLyMSUCDB53DcA2HMGR75ThbfGgjLhe/wIY4h1qhXZqXTj8+tJF1rFw== X-Received: by 2002:a05:600c:4f44:b0:40a:4429:a994 with SMTP id m4-20020a05600c4f4400b0040a4429a994mr3762126wmq.28.1700736761975; Thu, 23 Nov 2023 02:52:41 -0800 (PST) Received: from [192.168.0.36] ([78.16.130.39]) by smtp.gmail.com with ESMTPSA id j14-20020a05600c190e00b0040b3525428bsm1598327wmq.2.2023.11.23.02.52.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Nov 2023 02:52:41 -0800 (PST) Message-ID: <2a04b026-e736-4395-57a6-97e5c8c986af@redhat.com> Date: Thu, 23 Nov 2023 10:52:40 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 To: Maxime Coquelin , stable@dpdk.org Cc: Sampath Peechu , David Marchand References: <20231123101131.98389-1-maxime.coquelin@redhat.com> From: Kevin Traynor Subject: Re: [PATCH v21.11.6 1/2] net/virtio: fix descriptor addresses in 32-bit build In-Reply-To: <20231123101131.98389-1-maxime.coquelin@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 23/11/2023 10:11, Maxime Coquelin wrote: > With Virtio-user, the Virtio descriptor buffer address is the > virtual address of the mbuf's buffer. On 32-bit builds, it is > expected to be 32 bits. > > With Virtio-PCI, the Virtio descriptor buffer address is the > physical address of the mbuf's buffer. On 32-bit builds running > on 64-bit kernel, it is expected to be up to 64 bits. > > This patch introduces a new mask field in virtqueue's struct to > filter our the upper 4 bytes of the address only when necessary. > An optimization is introduced for 64-bit builds to remove the > masking, as the address is always 64 bits wide. > > Fixes: ba55c94a7ebc ("net/virtio: revert forcing IOVA as VA mode for virtio-user") > Cc:stable@dpdk.org > > Reported-by: Sampath Peechu > Signed-off-by: Maxime Coquelin > Reviewed-by: David Marchand > (cherry picked from commit 8c41645be010ec7fa0df4f6c3790b167945154b4) > Signed-off-by: Maxime Coquelin > --- > .mailmap | 1 + > drivers/net/virtio/virtio_ethdev.c | 7 +++++-- > drivers/net/virtio/virtqueue.h | 18 ++++++++++++++---- > 3 files changed, 20 insertions(+), 6 deletions(-) Applied to 21.11 branch. Thanks for backporting.