From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Mihai Brodschi <mihai.brodschi@broadcom.com>,
Jakub Grajciar <jgrajcia@cisco.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH v2] net/memif: fix buffer overflow in zero copy Rx
Date: Thu, 10 Oct 2024 03:33:09 +0100 [thread overview]
Message-ID: <2c3e4967-0a78-41f5-b46d-94d0764ee401@amd.com> (raw)
In-Reply-To: <c3a72bcb-24b0-4c42-9a07-427eadce029a@broadcom.com>
On 6/28/2024 10:01 PM, Mihai Brodschi wrote:
> rte_pktmbuf_alloc_bulk is called by the zero-copy receiver to allocate
> new mbufs to be provided to the sender. The allocated mbuf pointers
> are stored in a ring, but the alloc function doesn't implement index
> wrap-around, so it writes past the end of the array. This results in
> memory corruption and duplicate mbufs being received.
>
> Allocate 2x the space for the mbuf ring, so that the alloc function
> has a contiguous array to write to, then copy the excess entries
> to the start of the array.
>
> Fixes: 43b815d88188 ("net/memif: support zero-copy slave")
> Cc: stable@dpdk.org
>
> Signed-off-by: Mihai Brodschi <mihai.brodschi@broadcom.com>
>
Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>
Applied to dpdk-next-net/main, thanks.
next prev parent reply other threads:[~2024-10-10 2:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 21:01 Mihai Brodschi
2024-07-01 4:57 ` Patrick Robb
2024-07-07 2:12 ` Ferruh Yigit
2024-07-07 5:50 ` Mihai Brodschi
2024-07-07 14:05 ` Ferruh Yigit
2024-07-07 15:18 ` Mihai Brodschi
2024-07-07 18:46 ` Mihai Brodschi
2024-07-08 3:39 ` Mihai Brodschi
2024-07-08 11:45 ` Ferruh Yigit
2024-07-19 9:03 ` Ferruh Yigit
2024-08-31 13:38 ` Mihai Brodschi
2024-10-10 2:00 ` Ferruh Yigit
2024-10-10 2:33 ` Ferruh Yigit [this message]
2024-07-07 5:31 Mihai Brodschi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c3e4967-0a78-41f5-b46d-94d0764ee401@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=jgrajcia@cisco.com \
--cc=mihai.brodschi@broadcom.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).