From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CBC294246A for ; Mon, 23 Jan 2023 14:58:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A652C400EF; Mon, 23 Jan 2023 14:58:58 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 03F74400D4 for ; Mon, 23 Jan 2023 14:58:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674482337; x=1706018337; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=OJF2NDy+INhGzqatorc0dMNqRv3zGjjoS6a3MACUS5w=; b=efqljfkLYS0dA310EhLPfP/PD6LzHLu06zMKokA97rHuo2Qn3q/u1OzH mWX7I4fexOs9YV5fphUc74IUVEH2gaBqvop/dfjD664yLWhTRju5vHiCR E5SZATBBlRzVp7VfF2gZIdjTU1FRVc6SEza5Y+jpEYFZyUJpzeY60a3bT So2Y4BWEIExAtHRS65IwALe3R4cxah/iJ5VSl37hV/pglSwceEbUf9k61 24wvyczh68r2kw7vjzg/wuOEvChXof24+L5paTuVq5oPirrOUPlJfNAVH uppXrBii2WSKUdwNAiVlgYbReublRCYEHkv+R84xlvxI82J/4B7QtY5CC w==; X-IronPort-AV: E=McAfee;i="6500,9779,10598"; a="306397241" X-IronPort-AV: E=Sophos;i="5.97,239,1669104000"; d="scan'208";a="306397241" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2023 05:58:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10598"; a="990428247" X-IronPort-AV: E=Sophos;i="5.97,239,1669104000"; d="scan'208";a="990428247" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga005.fm.intel.com with ESMTP; 23 Jan 2023 05:58:55 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 23 Jan 2023 05:58:55 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 23 Jan 2023 05:58:55 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 23 Jan 2023 05:58:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kk1ENu3QC6MyEmKMyG5TXEOv5OwfLBGpSBVj0pY3t4Ex8EW8TS5wiuuPz1UNOKqiWXchVQgkSFW4svhKeRRkHLgcMy//BjO3E+erWUe3bzGN0PsDPtzaqc6WkPX+q6jer3unyxsCUc1GTh/8HakHhFXg2AnVZlprOlMB1rmnzAmjF2SE+yr+pu3VNcgpaV1yJXv495hjkRmI7iWPFKBCkZwWkCkIrdkqhXjZKIZRfNH13s5nrbE8zBWZ04xYi2AUlcsX3oXFXmWN8a4i0QfYd4qQpi8PMgrxj/TjZpE1cadvbB3k1fRm1wCEu8POO1JfpjdnOj/3GUCdIOYZIWRuvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ItsuR7Dl3F9Xtj2XuuJyc/2Cebpbzly9BFNxmCIWhj0=; b=Gg1ztWq0gHg9hOJSbcx842LAhG7K+WqAsJ/BV81hWHAWgQ33dC+6cVWI9N8y4EQ5YjWDDQWyNRBJ1lo2VN5sUPkjSkBJf/aYpKBcYS41ygJ9kYHlFKnNVnGZB9N9d1ja7M3rMnwELgtulo8MAsGQHMXj83LwAFJNgzkTTzU0Au51XW2XLfMpW9PlH/TeLKzZBXe+R1isNR4FyQ13SM016F6FwjjhQe5+9JApBOFyAYizFypm1I8U4fnU+ZzqnYXW5nA+Div+mbXBUBaqc6vk1L1PjoRsNEr7YepS1zrZ7BBOxLSqj5z6IX/qtIB16ek/LuqB07xz0iPOqhBZye+NNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from BYAPR11MB3799.namprd11.prod.outlook.com (2603:10b6:a03:fb::19) by SA0PR11MB4702.namprd11.prod.outlook.com (2603:10b6:806:92::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Mon, 23 Jan 2023 13:58:53 +0000 Received: from BYAPR11MB3799.namprd11.prod.outlook.com ([fe80::fa57:6a26:c7d7:841a]) by BYAPR11MB3799.namprd11.prod.outlook.com ([fe80::fa57:6a26:c7d7:841a%4]) with mapi id 15.20.6002.033; Mon, 23 Jan 2023 13:58:53 +0000 Message-ID: <2ce086a5-3dd4-fd00-15b5-38274d1f726e@intel.com> Date: Mon, 23 Jan 2023 13:58:47 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 19.11.14-rc1] examples/vm_power_manager: revert backported commit To: Tadhg Kearney , CC: , References: <20230116141331.498056-1-tadhg.kearney@intel.com> Content-Language: en-US From: "Hunt, David" In-Reply-To: <20230116141331.498056-1-tadhg.kearney@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0227.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::16) To BYAPR11MB3799.namprd11.prod.outlook.com (2603:10b6:a03:fb::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR11MB3799:EE_|SA0PR11MB4702:EE_ X-MS-Office365-Filtering-Correlation-Id: 2ed25a76-7027-4f98-0537-08dafd49f5f7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q9web7IVCBwkdyzJOGPZ9Q815WrGxbwKKZegmiplKmQGaKoXAcURQMp5BkSR5sIZurdvGjW9YeYN+hiTIcA/deaguosTYYuGQrF+FX6EVr9le8uztDgNS6av6EBQ6+UIkknYFQ07pp5Z8RUPQzr3+dJ5mZXdoi5o+LCP52Z+4OAZZk03XUs/b+leG2QQStzxwdaGN9rj3R4vxNNFVWMyWjU25Rb7XnGeVp2kemO4feyjm3gUF6+NIvoftwk7IVBdAm43aXAOHvg+W5DO0JNvI3VwoWPIutoLa0VrDVbBdZ6s+YXQqwa4FtGJg31tnapHERADrh5o0a8MAD+DhT4oU0MYItVnaRd/HHdYrERvS6t68NzggQhn9fi9r3siC86rB9AZuKZm4hxcBd5BZCibDZyUHFHZt67aUkqkaeo26hJ/anc+u7C1w6S05uHqX6ufZb9gV4fT4Lsph5IzJRZ3El76c+aw4I3rYUiqapvvpadUrveVZ9jDq7WYnO6NMffiZt74IxgpcNvQWPmFsn/SpEtrXKHLkv4PygeCeJCcBbUkrbkyWT/RFO+HbNdTs+jtBrUXNxSXjGN7pXopo58XOyZMwX8f35XRIVZsganiWnBtcVLWHCuGO03yTT+L7yyFzB9HKNSMCc8lk6NwUm/Haq2Pawa8tj9S0115EQCZjQIzwgLtpa41O+OkUn+zx4RBVVe43Md2hY2l9KLl+b88fLGqN1eWKbpuFEh8mPbmPME= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3799.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(346002)(39860400002)(136003)(376002)(396003)(451199015)(36756003)(2906002)(82960400001)(5660300002)(38100700002)(8936002)(4326008)(41300700001)(83380400001)(86362001)(31696002)(478600001)(6486002)(31686004)(66476007)(8676002)(6512007)(53546011)(186003)(6506007)(26005)(316002)(66946007)(2616005)(107886003)(66556008)(6666004)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OUNhYTkxc25VQnBHY1RMei9ZczU3VTU1NmQ1ak82UW5vdUY2My9Wam82ZVVP?= =?utf-8?B?MFJTbWd3aGZQZWk5QU1jNjc5Z0hTNFhBQ0RrSmNPQ2hjRS9wT2pGRS9yZGdz?= =?utf-8?B?Qmpab1plZkhYSkVXeU1jUk5BUVVkZnYvR054dGpuMVI2UDlmWjh2Q2RSbW9l?= =?utf-8?B?RTNJc2dJYXRVWDcrYXJmSGhVbDFKRmt4NFU2Z0E5RmpqSVdCbnlaazdKSVl1?= =?utf-8?B?TXVmL0M2Nkc5alJ1TDc3Ynh0dUxaYUZrdll2M3lCN3RKMS9vK0VBYVVaa3BF?= =?utf-8?B?d3BaSlc5Ym95ZjljVzA1Qk5HT0Y1MTcxRi94MGRPRVJqZlYyV0VnK2hrZUpL?= =?utf-8?B?Si8vZlhrRGlLQ05EajFrMUd5Rmt2WXhsdk9LamNqbUpOZEVCN3dIY200Mlpw?= =?utf-8?B?QjdjWjhUdnlXT0NSb0pGemQ2UUJJQW02VEowVVBITjRwRjZWWks0ZVZpOXJL?= =?utf-8?B?QkJrZ1JZb3RhTzdxYnRIK0FCWVlST004RUZrV3VQODV0VnArTzhzNllmWDhH?= =?utf-8?B?VDZqbHROcG9sRmwwVkhPd0JESkkwOTF2ZXhrNXFvdDFscUtyRVZhU2EvV0Nu?= =?utf-8?B?dmc2ZDk2TXB6VFA4Z1IwK1BsMVBXUzUxQTRrZHBQOHdEcHN6bEFFTmE3WC9w?= =?utf-8?B?ZkJDeUplb2hwcFVtT2hYcTlTZU9wQnIwZGs1Y1lQVzZDNXREVGE5QjdvZ0tB?= =?utf-8?B?c1NpenVsNmZ5elVLeXVKdGt2TG53ZksvSGFWYVoyRlA3OGNnK1MzSEJwNC9Z?= =?utf-8?B?dCsxSzZaSHRWcUd1UzlLa0ZoTWhIVFZ6WTR1Y0VsbmNKU2hDVnpRazRpTENi?= =?utf-8?B?RGl0U082Tm5YZktnWkhLblpXeGkwUHliMWdlZVBXenVaQzBBZm1MUTZCcEhh?= =?utf-8?B?UGc4MDNwalJBeEJEekptL0F2RlJUVFpsMVVYVkhQREorbnpIemphQXZlZDlm?= =?utf-8?B?WndyZXNyZG1Jdk5KUDIydTN4TVJzeHlWeUdKUVhFUzZ6MjhmeEZYY3pmei8z?= =?utf-8?B?aGpORGJlS3A2RWZCTHl2Zk12SHBzS1ZGYitmQ3RPb25zTVZ3azhzZlNleldQ?= =?utf-8?B?SDRQNVBmc0NJNG9oUGpXTkRHSWpRb0VUTTZJMllMeUV3Q0swY3JGdEhtMnBu?= =?utf-8?B?ME1LTU5NRE5XTndSd1pxZER2ankwQ3BpYUpvUHNiWjZFRFFiNG84V2ZUWFdr?= =?utf-8?B?VGJpWTRuZTcrdk5RTFJtSnNmZUdOQjNCYlZ0bzY4b2xqUjdLdTBxNWlsYkF6?= =?utf-8?B?WDhweEQwb2dKSHI5S0F6WTUyNE5BeU9Qd3VxS3ExYTlIeHJ0YVBRUUxjRnJy?= =?utf-8?B?dEJDazh3SEQwVWNaWGNtMFB6WW9nVEpQcVZRWHhvSTJhangzS2ovOGUrVUFP?= =?utf-8?B?SzhwQWR2aURmSzVYa0tjQWFleU9EbWtOYW5zaFNFWUNJQ0NSMmtReU9hc3F3?= =?utf-8?B?Zkk5SUczZTZiN005aGNpVWJ0MTI5UnhBNjVuM2N2M2RqbzhjMHhWTVplQlRw?= =?utf-8?B?ZXZ4K1FoVTVndTlOK3hjOVRMcTljS0VML2p4RHdVMWRyY0NQbGp0RWhSMmNK?= =?utf-8?B?YllLUXpDOFVjZjU0bThjcHJLRXp3dk9kT3hDcytRVmxsbTFiZlN6ZWZGWWNO?= =?utf-8?B?V0E4MVgyRS9BMkQvQVVkcUFQQ1ZpZGh4d1dUK0NZT1U1Yzk4eURSNFBPYnpD?= =?utf-8?B?ZS94R1h4TktLMWRheHZmeWphRzNLdCtiVXN0UnhFOUtRVi9abExudkhGL1dE?= =?utf-8?B?MHR5MUo4TjZTcGlKOE5NNHJtMnlLVXk3QjlDdWtzMy8wUkxrQVR2OWExZ1U5?= =?utf-8?B?TWo1WEdHdVlXZWZOK2hiV3FVME9kcWVpcjBQSXcxKzd6Q3k4R2lpOElLWEJN?= =?utf-8?B?SFJaQjkyVXA3U00yUDRvZGJBQm9SOEhNdjdwUURaWGdta3BSOERRUzkxY0xm?= =?utf-8?B?aXEySGN4a2FBWjhVR3poY1JxaUd3Z1gwMVRvR0x1Y3VQck1nRXlQN0t0dWNw?= =?utf-8?B?cGNtdnVoTUdSNTVyY3MwSTZZZWR3L2syRmhscjl0K1RoZ2I1cVBNcGR3NVNY?= =?utf-8?B?eWxxd05xMGJ4eTN5RHBBdGVZOElxT2dpMW9WTCtHNG9PZHdTNnlGMHpYSFY0?= =?utf-8?B?TVBqYlNIbVBadGZqdythMmN1VFgxSTBTcmFjSFZXM3pRSHhjWWh4TENaaUNX?= =?utf-8?B?ZlE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2ed25a76-7027-4f98-0537-08dafd49f5f7 X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3799.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2023 13:58:53.4580 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TLPloPH0ZZ4rR9RQB/w+Fs9lyxqyGeRnPzhmk5GacGsheydBghg7phVW3ohcW58aNxQbSC9toB4lMtKxYlSLQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4702 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi Tadhg, On 16/01/2023 14:13, Tadhg Kearney wrote: > Revert backported commit a244dfa7d784 ("examples/vm_power_manager: > use safe list iterator") that adds compilation errors while compiling > dpdk with vm_power_manager. Issue is caused by TAILQ_FOREACH being used > without dependencies also having being backported. > > Fixes: a244dfa7d784 ("examples/vm_power_manager: use safe list iterator") > Cc: hamza.khan@intel.com > > Signed-off-by: Tadhg Kearney > --- > examples/vm_power_manager/channel_manager.c | 19 +++++++++---------- > 1 file changed, 9 insertions(+), 10 deletions(-) > > diff --git a/examples/vm_power_manager/channel_manager.c b/examples/vm_power_manager/channel_manager.c > index 5e0bbbb4c9..0a28cb643b 100644 > --- a/examples/vm_power_manager/channel_manager.c > +++ b/examples/vm_power_manager/channel_manager.c > @@ -23,7 +23,6 @@ > #include > #include > #include > -#include > > #include > > @@ -60,16 +59,16 @@ struct virtual_machine_info { > virDomainInfo info; > rte_spinlock_t config_spinlock; > int allow_query; > - RTE_TAILQ_ENTRY(virtual_machine_info) vms_info; > + LIST_ENTRY(virtual_machine_info) vms_info; > }; > > -RTE_TAILQ_HEAD(, virtual_machine_info) vm_list_head; > +LIST_HEAD(, virtual_machine_info) vm_list_head; > > static struct virtual_machine_info * > find_domain_by_name(const char *name) > { > struct virtual_machine_info *info; > - RTE_TAILQ_FOREACH(info, &vm_list_head, vms_info) { > + LIST_FOREACH(info, &vm_list_head, vms_info) { > if (!strncmp(info->name, name, CHANNEL_MGR_MAX_NAME_LEN-1)) > return info; > } > @@ -878,7 +877,7 @@ add_vm(const char *vm_name) > > new_domain->allow_query = 0; > rte_spinlock_init(&(new_domain->config_spinlock)); > - TAILQ_INSERT_HEAD(&vm_list_head, new_domain, vms_info); > + LIST_INSERT_HEAD(&vm_list_head, new_domain, vms_info); > return 0; > } > > @@ -900,7 +899,7 @@ remove_vm(const char *vm_name) > rte_spinlock_unlock(&vm_info->config_spinlock); > return -1; > } > - TAILQ_REMOVE(&vm_list_head, vm_info, vms_info); > + LIST_REMOVE(vm_info, vms_info); > rte_spinlock_unlock(&vm_info->config_spinlock); > rte_free(vm_info); > return 0; > @@ -953,7 +952,7 @@ channel_manager_init(const char *path __rte_unused) > { > virNodeInfo info; > > - TAILQ_INIT(&vm_list_head); > + LIST_INIT(&vm_list_head); > if (connect_hypervisor(path) < 0) { > global_n_host_cpus = 64; > global_hypervisor_available = 0; > @@ -1005,9 +1004,9 @@ channel_manager_exit(void) > { > unsigned i; > char mask[RTE_MAX_LCORE]; > - struct virtual_machine_info *vm_info, *tmp; > + struct virtual_machine_info *vm_info; > > - RTE_TAILQ_FOREACH_SAFE(vm_info, &vm_list_head, vms_info, tmp) { > + LIST_FOREACH(vm_info, &vm_list_head, vms_info) { > > rte_spinlock_lock(&(vm_info->config_spinlock)); > > @@ -1022,7 +1021,7 @@ channel_manager_exit(void) > } > rte_spinlock_unlock(&(vm_info->config_spinlock)); > > - TAILQ_REMOVE(&vm_list_head, vm_info, vms_info); > + LIST_REMOVE(vm_info, vms_info); > rte_free(vm_info); > } > Hi Tadhg,   I tested this and it fixes the compilation issue. Tested-by: David Hunt