From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9059448A46 for ; Fri, 31 Oct 2025 19:02:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 690CA40150; Fri, 31 Oct 2025 19:02:24 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 5718640150 for ; Fri, 31 Oct 2025 19:02:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761933742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=sd3TjuELhxZ+ZyDoaU09w7SkxsOyeb38l2AoanNq/VI=; b=EJOiUIEsWRHT+0kRvb5y7N+LpcohSXxQkPbH+JIE5PeUuIwe9fQ79OTE6cXZ+z/bXczx23 qOq1DZhNjL/qZuHVlSlkVxzFmhKq+X9QLfjXR7mzkSRD8eb5oLtSdieTGLfS6dwh8z9M7H UnDw8PHzY2BrP0FKyTMwZol+pTiJuyc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-189-yGF-a2g8PBms7I11BlCV6A-1; Fri, 31 Oct 2025 14:02:21 -0400 X-MC-Unique: yGF-a2g8PBms7I11BlCV6A-1 X-Mimecast-MFC-AGG-ID: yGF-a2g8PBms7I11BlCV6A_1761933740 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-477212937eeso19804835e9.2 for ; Fri, 31 Oct 2025 11:02:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761933740; x=1762538540; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sd3TjuELhxZ+ZyDoaU09w7SkxsOyeb38l2AoanNq/VI=; b=v/CbH0x0UlZTs7AbObMfKH5N8Nn4yzwatFzVu315It4C6LsGsEBNnaaf+5EPXHZ1hx dL7fsL9S6+HR43DAgWz0ikHF+kJL9yLttvqqX5jLIETukv7QmlQK9IAv0Ffb7WruUgRh KQ8zB4z1cmgRCxUweMEQQZd+REhs3miEQLeG5x8PQnKx8lyuJiA4p0uCopergq3ypd7h gZ4Tk+zgNzhFEZj2b/WjAlKhzY6ELmEOKzwh/IpAdegeRYcOMdZA10tBiJ+MJheovBMx w590oG6GASpLtHRw8+kXncGvI8XgneGtXn5NvFd1Yh0GYHL8VaP4KdvEEYUw6MjnNOeD Zz5g== X-Gm-Message-State: AOJu0YwWLtWX/GPRMN/dU+di0xBzWuxQfMffogEWjBMIdca/G19zscDo JzmwuBbCefOAfF9WxMYfBWRtP80AJuNqadOaSVKxQCyO2ZxiXFR4nCGNjDXAcqei9GKbX20lrFR p1WMIEevBVVt9xbbJ0D/oAfQVoQTIfZG8ekCt82Cdjn646BED X-Gm-Gg: ASbGncvMjRauSuLgAsvjRZFes73rwywPt9Fhqrakzx9qss8ODwOEz30Z8oyvQwkln1r xctitUAVmTLUWYzKBmGto1cY5ETv5nz9hIrptBsun2arsmHaIPKsO5XV3ykBFFUHzfPkKb2jNE0 PVqHNQGmOz0KZbn6Oe0npGtKDIs1GRCcuGYXz7h9c2SNxg92NFQanut1e2QLErnstHOeJBmFaF2 kXONZ8QDHdq8h238ttHBqHd6fHg75tZrP2K0puvQ8EwZkrxhyGR8to4/X7k3DqdDtYleaU/TmNb 7LXKooHIq43KQWY1BYyF67wbNRdXPzriBsLgCRrkor2oMU9Pgjynp51cp96rfS/ZqijRGX37FnG Y X-Received: by 2002:a05:6000:2681:b0:428:5673:11e0 with SMTP id ffacd0b85a97d-429bd6a78f6mr3682857f8f.40.1761933740150; Fri, 31 Oct 2025 11:02:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGGeS/boTfFEN4lpQ4KspXNltEDI73FSmJREdNKf41BIrFpDEpp3rDSJJvmCT4FOK2z/vLEHg== X-Received: by 2002:a05:6000:2681:b0:428:5673:11e0 with SMTP id ffacd0b85a97d-429bd6a78f6mr3682831f8f.40.1761933739753; Fri, 31 Oct 2025 11:02:19 -0700 (PDT) Received: from [192.168.0.56] ([78.16.130.67]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429c13f2b5asm4673708f8f.40.2025.10.31.11.02.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Oct 2025 11:02:19 -0700 (PDT) Message-ID: <2d65a63d-0f74-414d-b365-b1416de9d820@redhat.com> Date: Fri, 31 Oct 2025 18:02:17 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 24.11] dts: add reception check to checksum suite To: Dean Marx , probb@iol.unh.edu Cc: stable@dpdk.org, Luca Vizzarro References: <20251031174414.85492-1-dmarx@iol.unh.edu> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= xsFNBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABzSNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPsLBjgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71zsFNBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABwsF2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= In-Reply-To: <20251031174414.85492-1-dmarx@iol.unh.edu> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: uzo9AjYlT_1ra7K7ajkUOX6IE03itFg_QjGiT_R-NwY_1761933740 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 31/10/2025 17:44, Dean Marx wrote: > [ upstream commit 89b634c9cf001570a7a1b1992ea6992c4181b8d7 ] > > In the current implementation of Checksum Offload, the variables > is_L4 and is_IP are not initialized outside of the loop that > checks the received packet, so if the packet is dropped these > variables cause a NameError in the verification steps. > Add a line that sets these variables to None prior to the check, > then verifies they are not None directly after. > > Fixes: 8c9a7471a0e6 ("dts: add checksum offload test suite") > > Signed-off-by: Dean Marx > Reviewed-by: Patrick Robb > Reviewed-by: Luca Vizzarro > --- > dts/tests/TestSuite_checksum_offload.py | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) Thanks Dean. I have queued this up and will push to the branch next week. regards, Kevin.