From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id D1CD24CA6; Fri, 21 Sep 2018 16:54:13 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Sep 2018 07:54:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,285,1534834800"; d="scan'208";a="71852707" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.39]) ([10.237.221.39]) by fmsmga007.fm.intel.com with ESMTP; 21 Sep 2018 07:53:59 -0700 To: Andrew Rybchenko , dev@dpdk.org Cc: Igor Romanov , stable@dpdk.org References: <1536910296-17455-1-git-send-email-arybchenko@solarflare.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <2de70a03-3d72-e73b-e2e1-d03faa282fef@intel.com> Date: Fri, 21 Sep 2018 15:53:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1536910296-17455-1-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [PATCH 1/2] net/sfc: fix an Rx queue double release possibility X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Sep 2018 14:54:14 -0000 On 9/14/2018 8:31 AM, Andrew Rybchenko wrote: > From: Igor Romanov > > There are two function that call sfc_rx_qfini(): > sfc_rx_fini_queues() and sfc_rx_queue_release(). But only > sfc_rx_queue_release() sets rx_queues pointer of the device data to NULL. > It may lead to the scenario in which a queue is destroyed by > sfc_rx_fini_queues() and after the queue is attempted to be destroyed again > by sfc_rx_queue_release(). > > Move NULL assignment to sfc_rx_qfini(). > > Fixes: ce35b05c635e ("net/sfc: implement Rx queue setup release operations") > Cc: stable@dpdk.org > > Signed-off-by: Igor Romanov > Signed-off-by: Andrew Rybchenko Series applied to dpdk-next-net/master, thanks.