Re: [PATCH] kni: fix compile error

[Ferruh Yigit <ferruh.yigit@amd.com>]

On 5/21/2022 8:06 AM, Min Hu (Connor) wrote:
> [CAUTION: External Email]
> 
> When kernel version change into 5.18 from 5.17, 'netif_rx_ni' is discard.
> It is replaced by 'netif_rx' and this API is also supported in the
> version below 5.18.
> 
> This patch fixed it.
> 
> Fixes: d89a58dfe90b ("kni: support chained mbufs")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
>   kernel/linux/kni/kni_net.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c
> index 29e5b9e21f..e19f03285e 100644
> --- a/kernel/linux/kni/kni_net.c
> +++ b/kernel/linux/kni/kni_net.c
> @@ -441,7 +441,7 @@ kni_net_rx_normal(struct kni_dev *kni)
>                  skb->ip_summed = CHECKSUM_UNNECESSARY;
> 
>                  /* Call netif interface */
> -               netif_rx_ni(skb);
> +               netif_rx(skb);
> 

Hi Connor,

There is already a patch for this [1], can you test & ack that instead 
please?

Same for Mingli's patch [2], @Mingli, can you please test and ack the 
[1] instead?

[1] kni: update kernel API to receive packets
https://patches.dpdk.org/project/dpdk/patch/20220421085931.2429443-1-g.singh@nxp.com/
http://inbox.dpdk.org/dev/20220421085931.2429443-1-g.singh@nxp.com/


[2]
https://patches.dpdk.org/project/dpdk/patch/20220511112334.3233433-1-mingli.yu@windriver.com/

>                  /* Update statistics */
>                  dev->stats.rx_bytes += len;
> @@ -779,7 +779,7 @@ kni_net_set_mac(struct net_device *netdev, void *p)
>                  return -EADDRNOTAVAIL;
> 
>          memcpy(req.mac_addr, addr->sa_data, netdev->addr_len);
> -       memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len);
> +       memcpy((void *)(netdev->dev_addr), addr->sa_data, netdev->addr_len);

Why don't you use new helper functions instead? I can see not using 
helper function is causing other problem as well [3].

[3]
https://patches.dpdk.org/project/dpdk/patch/20220407082544.21282-1-humin29@huawei.com/

> 
>          ret = kni_net_process_request(netdev, &req);
> 
> --
> 2.33.0
>