From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D30948BC3 for ; Thu, 27 Nov 2025 12:44:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E4D5540658; Thu, 27 Nov 2025 12:44:21 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 759F940658 for ; Thu, 27 Nov 2025 12:44:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764243859; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Dxug8nnIMxdCjrHw6uBG2atvAIC9GmMnNfbTG7nYYp8=; b=T39Vrl1xbbpGrCtYgsYxKU1YM5duF00SzjoPGHAFEvjV8bPv0FvQd3X8cVtxzMRGdmI7x4 FEqeaqbjoqT/iMbt7bB1Bhr9bp2yDbWvECRe/7qR61y13laYmgaOzjC55JGYxFYNFWA0sb 8WNrEs9ZWj4s3ah3rNHNgjUh32/WfS8= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-224--iCDevRBON2wgRf1jwHWhg-1; Thu, 27 Nov 2025 06:44:18 -0500 X-MC-Unique: -iCDevRBON2wgRf1jwHWhg-1 X-Mimecast-MFC-AGG-ID: -iCDevRBON2wgRf1jwHWhg_1764243855 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-42b3c965ce5so598120f8f.2 for ; Thu, 27 Nov 2025 03:44:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764243855; x=1764848655; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Dxug8nnIMxdCjrHw6uBG2atvAIC9GmMnNfbTG7nYYp8=; b=eTGkCIowtnoCCu0XHGv5SWoQhR2Kj/jiEG5bB07X+XvXH8fiG8cLVwR0MNSuTxof5a N3uKdAiB5897YBuWmpQZHh4qLGrXHxWV1UwlXPbKxYPm8ZP6mpwokhkEV3JR+X3e5a6k O4GkuWk3+qdV8xAL10/NcXBUsMuCPfq1hDQT+NuCumKoJsYZyrjLmGBZs+/MgaUJceqv gX/hs9WFR2vFwAEGBtULw3MQUYoB6NIxd/sMu6BXkyhXwsSgPwoGwmpS4Qu4NTZFmD/x 2vVlUvMRVGQOBua12f7RPQw6xBYWRdnW5iYDDPJg4f2ojyYlk1SsRlN16NqH8xHKIq1u Lqxw== X-Forwarded-Encrypted: i=1; AJvYcCWOBg+Wzj4g/v16Ae62LVODp8fe1R7wJHlDAts4RDRl79NcDnk1U2+55drbRwteVd67vJ7auXo=@dpdk.org X-Gm-Message-State: AOJu0YyVeHeJlAcColKl4lRKWgRVSKfMazmk+uXRH7kMZxTwhZkYAoGr z7U+qlYCWtew57+GxovhBghr0UxH6OXjDgRJHX4d8WFf1smNDuhXYRd2TiyrfF+kZ8A1Oh75pJU voh+8FEuFzhD3XjzXEeLwejqqVux/F4Wy11Tyw9jvFh76i7Cq X-Gm-Gg: ASbGncuww4XrA4iwWF7ze42LQXJzzaINepn/6nBR5hjzZwoKMl5i7YXKROqB+NlQs06 QKATcjy6V1aHeIHsj70ypEbrugWtlEhVJsjgPa9bTKlV4Upk62iI7mCpZaLW/FiGYoO6YOqJkcj 9hr1Pg2v2SLMhCrUrMeuilkiufBH6G4CR1NEu4F8SkF0IJyHZwggC2Se0MzJpZhBbNmCPjwc7BU muJIP1ZkSmjuKOkQhguG6cou5xaml1jNh8m2HYwUrCOEufPAKwOvMBYa9fYi2+FDXphfHZr9H9N G9LRxEMCtesIoGRQyNs4ewCG94I8A9pAGeTWfT2TzNpCK+ACJtWkTPgvWey1Zu7rXOfnP70oFJ7 RORifSYK0G8Mc X-Received: by 2002:a05:6000:2489:b0:42b:3a84:1ee6 with SMTP id ffacd0b85a97d-42e0f22a2c8mr11274128f8f.24.1764243855359; Thu, 27 Nov 2025 03:44:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IEz6eZkWu8OCfCr3T/xwAQ1ZNzHiCOQMY6JU6uZFqEfF9DNAO7XOI9lLTrrMCQeGR1pMRTPTQ== X-Received: by 2002:a05:6000:2489:b0:42b:3a84:1ee6 with SMTP id ffacd0b85a97d-42e0f22a2c8mr11274094f8f.24.1764243854933; Thu, 27 Nov 2025 03:44:14 -0800 (PST) Received: from [192.168.0.56] ([78.16.128.110]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42e1caa86d0sm2940094f8f.39.2025.11.27.03.44.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Nov 2025 03:44:13 -0800 (PST) Message-ID: <2e69dbbb-5a54-4e3d-beea-e47922e765ee@redhat.com> Date: Thu, 27 Nov 2025 11:44:12 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 24.11 v2] net/mlx5: fix device start error handling To: Maayan Kashani , stable@dpdk.org Cc: dsosnowski@nvidia.com, rasland@nvidia.com, Viacheslav Ovsiienko , Bing Zhao , Ori Kam , Suanming Mou , Matan Azrad References: <20251125110607.178051-1-mkashani@nvidia.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= xsFNBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABzSNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPsLBjgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71zsFNBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABwsF2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= In-Reply-To: <20251125110607.178051-1-mkashani@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: V60_jXkfQ4UldaH5KGZgnPnCSVuKKANeJ_zG12hXO6c_1764243855 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 25/11/2025 11:06, Maayan Kashani wrote: > [ upstream commit 860f6c63dbc1 ] > > When mlx5_dev_start() fails partway through initialization, the error > cleanup code unconditionally calls cleanup functions for all steps, > including those that were never successfully initialized. This causes > state corruption leading to incorrect behavior on subsequent start > attempts. > > The issue manifests as: > 1. First start attempt fails with -ENOMEM (expected) > 2. Second start attempt returns -EINVAL instead of -ENOMEM > 3. With flow isolated mode, second attempt incorrectly succeeds, > leading to segfault in rte_eth_rx_burst() > > Root cause: The single error label cleanup path calls functions like > mlx5_traffic_disable() and mlx5_flow_stop_default() even when their > corresponding initialization functions (mlx5_traffic_enable() and > mlx5_flow_start_default()) were never called due to earlier failure. > > For example, when mlx5_rxq_start() fails: > - mlx5_traffic_enable() at line 1403 never executes > - mlx5_flow_start_default() at line 1420 never executes > - But cleanup unconditionally calls: > * mlx5_traffic_disable() - destroys control flows list > * mlx5_flow_stop_default() - corrupts flow metadata state > > This corrupts the device state, causing subsequent start attempts to > fail with different errors or, in isolated mode, to incorrectly succeed > with an improperly initialized device. > > Fix by replacing the single error label with cascading error labels > (Linux kernel style). Each label cleans up only its corresponding step, > then falls through to clean up earlier steps. > This ensures only successfully initialized steps are cleaned up, > maintaining device state consistency across failed start attempts. > > Bugzilla ID: 1419 > Fixes: 8db7e3b69822 ("net/mlx5: change operations for non-cached flows") > Cc: stable@dpdk.org > > Signed-off-by: Maayan Kashani > Acked-by: Dariusz Sosnowski Thanks Maayan. Applied to 24.11 branch. Kevin.