From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Rongwei Liu <rongweil@nvidia.com>,
dev@dpdk.org, matan@nvidia.com, viacheslavo@nvidia.com,
orika@nvidia.com, suanmingm@nvidia.com, thomas@monjalon.net
Cc: michaelba@nvidia.com, stable@dpdk.org,
Dariusz Sosnowski <dsosnowski@nvidia.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>
Subject: Re: [PATCH v8 1/3] app/testpmd: fix the testpmd field string sequence
Date: Tue, 11 Jun 2024 15:52:16 +0100 [thread overview]
Message-ID: <2e8d3814-a0c3-4a8a-8c9f-f87a4ca74719@amd.com> (raw)
In-Reply-To: <20240607140208.315235-2-rongweil@nvidia.com>
On 6/7/2024 3:02 PM, Rongwei Liu wrote:
> The field string should be in the same order as the rte_flow_field_id
> enumration definitions
>
> Fixes: bfc007802 ("ethdev: allow modifying IPv6 FL and TC fields")
> Cc: michaelba@nvidia.com
> Cc: stable@dpdk.org
>
Fixes: d66aa38f431d ("ethdev: allow modifying IPsec fields")
Fixes: b160da13b398 ("ethdev: allow modifying IPv4 next protocol field")
Above can be because of merge conflict, I didn't investigate in depth.
> Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
> Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
> ---
> app/test-pmd/cmdline_flow.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 60ee9337cf..775ce20fc4 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -1002,10 +1002,10 @@ static const char *const flow_field_ids[] = {
> "hash_result",
> "geneve_opt_type", "geneve_opt_class", "geneve_opt_data", "mpls",
> "tcp_data_off", "ipv4_ihl", "ipv4_total_len", "ipv6_payload_len",
> - "random",
> "ipv4_proto",
> - "esp_spi", "esp_seq_num", "esp_proto",
> "ipv6_flow_label", "ipv6_traffic_class",
> + "esp_spi", "esp_seq_num", "esp_proto",
> + "random",
> NULL
> };
>
prev parent reply other threads:[~2024-06-11 14:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2909053.FA0FI3ke8A@thomas>
[not found] ` <20240607140208.315235-1-rongweil@nvidia.com>
2024-06-07 14:02 ` Rongwei Liu
2024-06-11 6:59 ` Ori Kam
2024-06-11 14:52 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e8d3814-a0c3-4a8a-8c9f-f87a4ca74719@amd.com \
--to=ferruh.yigit@amd.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=michaelba@nvidia.com \
--cc=orika@nvidia.com \
--cc=rongweil@nvidia.com \
--cc=stable@dpdk.org \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).