From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 18F3D1B4D2 for ; Thu, 22 Nov 2018 18:29:41 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 50EB289AD6; Thu, 22 Nov 2018 17:29:40 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.36.118.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id F2110100164A; Thu, 22 Nov 2018 17:29:38 +0000 (UTC) From: Kevin Traynor To: Beilei Xing Cc: Qi Zhang , dpdk stable References: <20181121160440.9014-1-ktraynor@redhat.com> <20181121160440.9014-34-ktraynor@redhat.com> Organization: Red Hat Message-ID: <2f59d4ec-bee0-6707-b123-b411357ff105@redhat.com> Date: Thu, 22 Nov 2018 17:29:37 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20181121160440.9014-34-ktraynor@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 22 Nov 2018 17:29:40 +0000 (UTC) Subject: Re: [dpdk-stable] patch 'net/avf: remove keeping CRC configuration' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Nov 2018 17:29:41 -0000 On 11/21/2018 04:04 PM, Kevin Traynor wrote: > Hi, > > FYI, your patch has been queued to stable release 18.08.1 > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > It will be pushed if I get no objections before 11/26/18. So please > shout if anyone has objections. > > Also note that after the patch there's a diff of the upstream commit vs the patch applied > to the branch. If the code is different (ie: not only metadata diffs), due for example to > a change in context or macro names, please double check it. > > Thanks. > > Kevin Traynor > > --- > From 328983dd640b60da0fbc2fed9c8271a0af53f8b2 Mon Sep 17 00:00:00 2001 > From: Beilei Xing > Date: Wed, 26 Sep 2018 10:44:34 +0800 > Subject: [PATCH] net/avf: remove keeping CRC configuration > > [ upstream commit 98ff88b3c45ec6b432fbeff761c48492dfaa735f ] > > Remove keeping CRC configuration as it's not supported by AVF. > > Fixes: 5ce4c2be1a64 ("net/avf: fix offload capabilities") > > Signed-off-by: Beilei Xing > Acked-by: Qi Zhang > --- > drivers/net/avf/avf_ethdev.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c > index a44e3e6ca..e56d57c43 100644 > --- a/drivers/net/avf/avf_ethdev.c > +++ b/drivers/net/avf/avf_ethdev.c > @@ -515,6 +515,4 @@ avf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) > DEV_RX_OFFLOAD_TCP_CKSUM | > DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM | > - DEV_RX_OFFLOAD_CRC_STRIP | Hi, this didn't apply cleanly because of the STRIP flag. Note, I removed the STRIP flag also in backport. Please confirm it's ok. > - DEV_RX_OFFLOAD_KEEP_CRC | > DEV_RX_OFFLOAD_SCATTER | > DEV_RX_OFFLOAD_JUMBO_FRAME | >