From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1784CA09E8 for ; Tue, 8 Dec 2020 13:53:16 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D8122A3; Tue, 8 Dec 2020 13:53:14 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 15806A3 for ; Tue, 8 Dec 2020 13:53:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607431990; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iGLiOAL+qKhTTX/2mnuvLdOCRqsF1hnEbc458F9taEk=; b=glnYFhfO7t1FrrPxqNVZC0n9CAaSLfmRKLp72TkoRNUJlSxZk/KGHucEvXd7dGuL5O1nls FTLsGWLBAd8XDFsauwgmk0HyeTRlwXF73rNmeqaHvRiy+ut5Tgo6Rby8HsiBrXsF2MyXV3 5Uiu2FxobiRA+2+waRTEbqvDAvXJyoI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-508-9LD8mcZkOmu6r76QpIC0Hw-1; Tue, 08 Dec 2020 07:52:56 -0500 X-MC-Unique: 9LD8mcZkOmu6r76QpIC0Hw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B3EE51015949; Tue, 8 Dec 2020 12:52:55 +0000 (UTC) Received: from [10.36.114.230] (ovpn-114-230.ams2.redhat.com [10.36.114.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id CC8FC1001B2C; Tue, 8 Dec 2020 12:52:54 +0000 (UTC) To: Slava Ovsiienko , "stable@dpdk.org" Cc: "mohsinshaikh@niometrics.com" References: <1607427254-11610-1-git-send-email-viacheslavo@nvidia.com> <9994347b-c239-8783-48ff-07d3185ebdc5@redhat.com> From: Kevin Traynor Message-ID: <300b1000-3404-c2fb-e80f-96ee1d5896b3@redhat.com> Date: Tue, 8 Dec 2020 12:52:53 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-stable] [PATCH] [18.11] net/mlx5: use open/read/close for ib stats query X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 08/12/2020 12:41, Slava Ovsiienko wrote: > OK, so, should I resend v2 with: > - no From: tag > - add [ upstream commit 00437823cb80b8fa87dbe61becc07bd42ee98549 ] > Got it, thanks. > With best regards, Slava > >> -----Original Message----- >> From: Kevin Traynor >> Sent: Tuesday, December 8, 2020 14:07 >> To: Slava Ovsiienko ; stable@dpdk.org >> Cc: mohsinshaikh@niometrics.com >> Subject: Re: [PATCH] [18.11] net/mlx5: use open/read/close for ib stats query >> >> On 08/12/2020 11:34, Viacheslav Ovsiienko wrote: >>> From: Mohsin Shaikh >>> >>> From: Mohsin Shaikh >>> >> Hi Slava, your patches are putting in duplicate From: tags ^ and missing >> upstream commit ids. Please add upstream commit ids so I don't have to find it >> for every patch. i.e. >> >> [ upstream commit 00437823cb80b8fa87dbe61becc07bd42ee98549 ] >> >>> fgets(3)/fread(3)/fscanf(3) etc. use mmap(2)/munmap(2) which leads to >>> TLB shutdown interrupts to all DPDK app cores including RX cores. >>> This can cause packet drops. Use read(2)/write(2) instead. >>> >>> Bugzilla ID: 440 >>> Cc: stable@dpdk.org >>> >> We can drop the stable tag as it's targetted to LTS branch anyway >> >>> Signed-off-by: Mohsin Shaikh >>> Reviewed-by: Alexander Kozyrev >>> Acked-by: Viacheslav Ovsiienko >>> --- >>> drivers/net/mlx5/mlx5_stats.c | 21 ++++++++++++++------- >>> 1 file changed, 14 insertions(+), 7 deletions(-)