From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5FD85A04AF for ; Thu, 17 Sep 2020 14:56:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 379E21BEA1; Thu, 17 Sep 2020 14:56:21 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id AB97C1BEA1; Thu, 17 Sep 2020 14:56:19 +0200 (CEST) IronPort-SDR: lxr7H9hOvURrX2Y2mfjmn0Mh8b+URxFQ31D/4kyMmUeKYwfNnCmHbiMoaWHFoKfN9iqNzR/4NO yF90IG93w2vA== X-IronPort-AV: E=McAfee;i="6000,8403,9746"; a="221235102" X-IronPort-AV: E=Sophos;i="5.76,437,1592895600"; d="scan'208";a="221235102" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2020 05:56:17 -0700 IronPort-SDR: pRJaFK6Q9BxZMw8bmx1a6dMQPSA0AOapOYv+f77WC4i9r1clDMF5s1QvC2HGIxXsGUByWNuahi EN8/i8EBNrPw== X-IronPort-AV: E=Sophos;i="5.76,437,1592895600"; d="scan'208";a="483734656" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.206.43]) ([10.213.206.43]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2020 05:56:15 -0700 To: wangyunjian , dev@dpdk.org Cc: hemant.agrawal@nxp.com, sachin.saxena@nxp.com, jerry.lilijun@huawei.com, xudingke@huawei.com, stable@dpdk.org References: <1589859732-5008-1-git-send-email-wangyunjian@huawei.com> From: "Burakov, Anatoly" Message-ID: <302a5cfb-f50e-ff66-3267-551fe7a4b6a8@intel.com> Date: Thu, 17 Sep 2020 13:56:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <1589859732-5008-1-git-send-email-wangyunjian@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 2/2] bus/fslmc: fix check for vfio_group_fd X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 19-May-20 4:42 AM, wangyunjian wrote: > From: Yunjian Wang > > The issue is that a file descriptor at 0 is a valid one. Currently > the file not found, the return value will be set to 0. As a result, > it is impossible to distinguish between a correct descriptor and a > failed return value. Fix it to return -ENOENT instead of 0. > > Fixes: a69f79300262 ("bus/fslmc: support multi VFIO group") > Cc: stable@dpdk.org > > Signed-off-by: Yunjian Wang > --- I am unfamiliar with bus/fslmc code but i've taken a quick look, and i've noticed that there's another instance of get_group_fd() usage that you're not modifying - is that intentional? -- Thanks, Anatoly