* Re: [dpdk-stable] [DPDK] devtools: change for ABI back-compatibility checking
2019-04-24 15:11 [dpdk-stable] [DPDK] devtools: change for ABI back-compatibility checking Peng Huang
@ 2019-04-24 12:08 ` Neil Horman
2019-05-01 23:47 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2019-04-24 12:32 ` Bruce Richardson
1 sibling, 1 reply; 4+ messages in thread
From: Neil Horman @ 2019-04-24 12:08 UTC (permalink / raw)
To: Peng Huang; +Cc: qi.z.zhang, qiming.yang, wenzhuo.lu, dev, stable
On Wed, Apr 24, 2019 at 03:11:59PM +0000, Peng Huang wrote:
> The new default-taget "linux" is introduced in v19.05-rc1
> but not exist in before release such as v19.02 which have
> default-target "linuxapp", there is no compatibility report
> when run validate-abi.sh to check ABI compatibility between
> v19.05-rc1 and v19.02, changed default-target from "linux"
> to "linuxapp" in validate-abi.sh
>
> Fixes: 218c4e68c1d9 ("mk: use linux and freebsd in config names")
> Cc: stable@dpdk.org
>
> Signed-off-by: Peng Huang <peng.huang@intel.com>
> ---
> devtools/validate-abi.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/devtools/validate-abi.sh b/devtools/validate-abi.sh
> index 54df2e4..138436d 100755
> --- a/devtools/validate-abi.sh
> +++ b/devtools/validate-abi.sh
> @@ -9,7 +9,7 @@ set -e
> abicheck=abi-compliance-checker
> abidump=abi-dumper
> default_dst=abi-check
> -default_target=x86_64-native-linux-gcc
> +default_target=x86_64-native-linuxapp-gcc
>
> # trap on error
> err_report() {
> --
> 1.8.3.1
>
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [DPDK] devtools: change for ABI back-compatibility checking
2019-04-24 15:11 [dpdk-stable] [DPDK] devtools: change for ABI back-compatibility checking Peng Huang
2019-04-24 12:08 ` Neil Horman
@ 2019-04-24 12:32 ` Bruce Richardson
1 sibling, 0 replies; 4+ messages in thread
From: Bruce Richardson @ 2019-04-24 12:32 UTC (permalink / raw)
To: Peng Huang; +Cc: nhorman, qi.z.zhang, qiming.yang, wenzhuo.lu, dev, stable
On Wed, Apr 24, 2019 at 03:11:59PM +0000, Peng Huang wrote:
> The new default-taget "linux" is introduced in v19.05-rc1
> but not exist in before release such as v19.02 which have
> default-target "linuxapp", there is no compatibility report
> when run validate-abi.sh to check ABI compatibility between
> v19.05-rc1 and v19.02, changed default-target from "linux"
> to "linuxapp" in validate-abi.sh
>
> Fixes: 218c4e68c1d9 ("mk: use linux and freebsd in config names")
> Cc: stable@dpdk.org
>
> Signed-off-by: Peng Huang <peng.huang@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-stable] [DPDK] devtools: change for ABI back-compatibility checking
@ 2019-04-24 15:11 Peng Huang
2019-04-24 12:08 ` Neil Horman
2019-04-24 12:32 ` Bruce Richardson
0 siblings, 2 replies; 4+ messages in thread
From: Peng Huang @ 2019-04-24 15:11 UTC (permalink / raw)
To: nhorman, qi.z.zhang, qiming.yang, wenzhuo.lu; +Cc: dev, peng.huang, stable
The new default-taget "linux" is introduced in v19.05-rc1
but not exist in before release such as v19.02 which have
default-target "linuxapp", there is no compatibility report
when run validate-abi.sh to check ABI compatibility between
v19.05-rc1 and v19.02, changed default-target from "linux"
to "linuxapp" in validate-abi.sh
Fixes: 218c4e68c1d9 ("mk: use linux and freebsd in config names")
Cc: stable@dpdk.org
Signed-off-by: Peng Huang <peng.huang@intel.com>
---
devtools/validate-abi.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/devtools/validate-abi.sh b/devtools/validate-abi.sh
index 54df2e4..138436d 100755
--- a/devtools/validate-abi.sh
+++ b/devtools/validate-abi.sh
@@ -9,7 +9,7 @@ set -e
abicheck=abi-compliance-checker
abidump=abi-dumper
default_dst=abi-check
-default_target=x86_64-native-linux-gcc
+default_target=x86_64-native-linuxapp-gcc
# trap on error
err_report() {
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [DPDK] devtools: change for ABI back-compatibility checking
2019-04-24 12:08 ` Neil Horman
@ 2019-05-01 23:47 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2019-05-01 23:47 UTC (permalink / raw)
To: Peng Huang; +Cc: dev, Neil Horman, qi.z.zhang, qiming.yang, wenzhuo.lu, stable
24/04/2019 14:08, Neil Horman:
> On Wed, Apr 24, 2019 at 03:11:59PM +0000, Peng Huang wrote:
> > The new default-taget "linux" is introduced in v19.05-rc1
> > but not exist in before release such as v19.02 which have
> > default-target "linuxapp", there is no compatibility report
> > when run validate-abi.sh to check ABI compatibility between
> > v19.05-rc1 and v19.02, changed default-target from "linux"
> > to "linuxapp" in validate-abi.sh
> >
> > Fixes: 218c4e68c1d9 ("mk: use linux and freebsd in config names")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Peng Huang <peng.huang@intel.com>
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
Applied, thanks and welcome!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-01 23:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-24 15:11 [dpdk-stable] [DPDK] devtools: change for ABI back-compatibility checking Peng Huang
2019-04-24 12:08 ` Neil Horman
2019-05-01 23:47 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2019-04-24 12:32 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).