From: Kevin Traynor <ktraynor@redhat.com>
To: Dekel Peled <dekelp@mellanox.com>,
yskoh@mellanox.com, viacheslavo@mellanox.com,
shahafs@mellanox.com
Cc: orika@mellanox.com, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mlx5: fix validation of drop action
Date: Fri, 22 Nov 2019 13:33:10 +0000 [thread overview]
Message-ID: <3045a4a5-4d76-0d75-5c9e-589faadd9697@redhat.com> (raw)
In-Reply-To: <7a681061efe7fa66f1827515039f83a2793fee15.1565861079.git.dekelp@mellanox.com>
Hi Dekel,
On 15/08/2019 10:26, Dekel Peled wrote:
> Function mlx5_flow_validate_action_drop() checks if another fate
> action is already present in this flow rule, using
> defined value MLX5_FLOW_FATE_ACTIONS.
> This patch enhances the check using value
> (MLX5_FLOW_FATE_ACTIONS | MLX5_FLOW_FATE_ESWITCH_ACTIONS)
> to make sure all relevant fate actions are checked.
>
> Fixes: 23c1d42c7138 ("net/mlx5: split flow validation to dedicated function")
MLX5_FLOW_FATE_ESWITCH_ACTIONS is not available and causes build error
for 18.11. I think correct fixes tag is,
Fixes: 2e4c987aad91 ("net/mlx5: validate Direct Rule E-Switch")
which is not part of 18.11 stable. Will drop patch from 18.11 stable.
Let me know if there is something else needed.
thanks,
Kevin.
> Cc: stable@dpdk.org
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_flow.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index 9d2c8c9..2356c14 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -809,7 +809,8 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,
> return rte_flow_error_set(error, EINVAL,
> RTE_FLOW_ERROR_TYPE_ACTION, NULL,
> "can't drop and mark in same flow");
> - if (action_flags & MLX5_FLOW_FATE_ACTIONS)
> + if (action_flags & (MLX5_FLOW_FATE_ACTIONS |
> + MLX5_FLOW_FATE_ESWITCH_ACTIONS))
> return rte_flow_error_set(error, EINVAL,
> RTE_FLOW_ERROR_TYPE_ACTION, NULL,
> "can't have 2 fate actions in"
>
prev parent reply other threads:[~2019-11-22 13:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 9:26 [dpdk-stable] " Dekel Peled
2019-09-04 14:10 ` Slava Ovsiienko
2019-09-05 8:59 ` [dpdk-stable] [dpdk-dev] " Raslan Darawsheh
2019-11-22 13:33 ` Kevin Traynor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3045a4a5-4d76-0d75-5c9e-589faadd9697@redhat.com \
--to=ktraynor@redhat.com \
--cc=dekelp@mellanox.com \
--cc=dev@dpdk.org \
--cc=orika@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@mellanox.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).