From: Ferruh Yigit <ferruh.yigit@amd.com>
To: shaibran@amazon.com
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH v3 05/33] net/ena: fix fast mbuf free
Date: Fri, 8 Mar 2024 17:23:19 +0000 [thread overview]
Message-ID: <3047c09e-9403-46ee-a13f-f269ed81f78b@amd.com> (raw)
In-Reply-To: <20240306122445.4350-6-shaibran@amazon.com>
On 3/6/2024 12:24 PM, shaibran@amazon.com wrote:
> From: Shai Brandes <shaibran@amazon.com>
>
> In case the application enables fast mbuf release optimization,
> the driver releases 256 TX mbufs in bulk upon reaching the
> TX free threshold.
> The existing implementation utilizes rte_mempool_put_bulk for bulk
> freeing TXs, which exclusively supports direct mbufs.
> In case the application transmits indirect bufs, the driver must
> also decrement the mbuf reference count and unlink the mbuf segment.
> For such case, the driver should employ rte_pktmbuf_free_bulk.
>
Ack.
I wonder if you observe any performance impact from this change, just
for reference if we encounter similar decision in the future.
next prev parent reply other threads:[~2024-03-08 17:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240306122445.4350-1-shaibran@amazon.com>
2024-03-06 12:24 ` shaibran
2024-03-08 17:23 ` Ferruh Yigit [this message]
2024-03-10 14:58 ` Brandes, Shai
2024-03-13 11:28 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3047c09e-9403-46ee-a13f-f269ed81f78b@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=shaibran@amazon.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).