From: Thomas Monjalon <thomas@monjalon.net>
To: Rongwei Liu <rongweil@nvidia.com>,
Luca Boccassi <luca.boccassi@gmail.com>
Cc: stable@dpdk.org, matan@nvidia.com, viacheslavo@nvidia.com,
orika@nvidia.com, suanmingm@nvidia.com, michaelba@nvidia.com
Subject: Re: [PATCH22.11 v1] net/mlx5: fix age checking crash
Date: Tue, 28 Oct 2025 14:10:21 +0100 [thread overview]
Message-ID: <3058440.n97fhnxGW3@thomas> (raw)
In-Reply-To: <CAMw=ZnQ=xC+SVvaCr19zzU4j4xno_8hqarDxoYOteiMiZQu6YQ@mail.gmail.com>
28/10/2025 13:13, Luca Boccassi:
> On Tue, 28 Oct 2025 at 08:17, Rongwei Liu <rongweil@nvidia.com> wrote:
> >
> > When aging is configured, there is a background thread
> > which queries all the counters in the pool.
> >
> > Meantime, per queue flow insertion/deletion/update changes
> > the counter pool too. It introduces a race condition between
> > resetting counters's in_used and age_idx fields during flow deletion
> > and reading them in the background thread.
> >
> > To resolve it, all key members of counter's struct
> > are placed in a single uint32_t and they are accessed atomically.
> >
> > To avoid the occasional timestamp equalization with age_idx,
> > query_gen_when_free is moved out of the union. The total memory
> > size is kept the same.
> >
> > Fixes: 04a4de756e14 ("net/mlx5: support flow age action with HWS")
> > Cc: michaelba@nvidia.com
> > Cc: stable@dpdk.org
> > Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
>
> Hi,
>
> I cannot seem to find a reference to this patch on the main branch?
> Was it merged with a different commit?
It seems Rongwei didn't reuse the title updated while merging in main:
https://git.dpdk.org/dpdk/commit/?id=820ca7361bb
Note the new title is more precise, please use it:
net/mlx5: fix flow aging race condition
next prev parent reply other threads:[~2025-10-28 13:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 8:16 Rongwei Liu
2025-10-28 12:13 ` Luca Boccassi
2025-10-28 13:10 ` Thomas Monjalon [this message]
2025-10-28 14:48 ` Luca Boccassi
2025-10-29 1:48 ` rongwei liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3058440.n97fhnxGW3@thomas \
--to=thomas@monjalon.net \
--cc=luca.boccassi@gmail.com \
--cc=matan@nvidia.com \
--cc=michaelba@nvidia.com \
--cc=orika@nvidia.com \
--cc=rongweil@nvidia.com \
--cc=stable@dpdk.org \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).