From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCABA489F8 for ; Tue, 28 Oct 2025 14:10:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B1D914021E; Tue, 28 Oct 2025 14:10:27 +0100 (CET) Received: from fhigh-a8-smtp.messagingengine.com (fhigh-a8-smtp.messagingengine.com [103.168.172.159]) by mails.dpdk.org (Postfix) with ESMTP id E1A764021E for ; Tue, 28 Oct 2025 14:10:25 +0100 (CET) Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfhigh.phl.internal (Postfix) with ESMTP id 67D08140046B; Tue, 28 Oct 2025 09:10:25 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Tue, 28 Oct 2025 09:10:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1761657025; x=1761743425; bh=i1Qyza2xuBI+BBC2WEHu6mHfp4tFyWgDR4kh4UwD/q4=; b= tPVOd3y3UNlhs8ZesDVU/C4Oreyf3JVGUUIwLJ5MRIyL1dUsArvcQM4cU2G+aAkH Oy+AnP1PIsuNMjpi3sNK7iExDtRxjx6mziL5ZzjZ3A1mnPqY1gaJjZCjLewdxyIK Lid6NUeyQFN5l03J4SWEp7/osLBDUFPTavOSwgsV9UIgQAOszw3NPh8QLQyj5Hla qcbPhj6KYqkPaJAKhuT42bqPXBHZUDTcoEdmsoM3B1l2pGhrVeWeQxbnVZF38Zw7 85wVJEtMtMxSolPJLGZigSE2n2Wr0KflMQJK7dUlBiE7dne+X2rb8vBR6hd15bEh /7vvmUe1LNwaJF4j87qDlQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1761657025; x= 1761743425; bh=i1Qyza2xuBI+BBC2WEHu6mHfp4tFyWgDR4kh4UwD/q4=; b=t 6AvQB5bcICv9LusukU91cwL9QP/SEOneqYYSGgh7aKAvCFaRr9jmSFUknwGgmcbT G7G17BEBz8foO59lm7YpcrNd23WNxUTyKKuRQ6h7lBBA5eIz7pIMiFnvU9Y/ttvj BqCrhngQ57ixTKzrrylVi2vXuYbBQ/KKjsw68njOLH+mkOUuEyOoqGd8tBSuMC04 BEoJndoVG73wqrT9xtbIHdCsFwKAcINbw7vr3XzqtlzuaqJVzbGe/2cdJJAjJLAo Wxd8CPz+IaRDoC3e5lclAdt+f7pGc/GggkcQUPHMYZMAhas7GX5EP4a+u5YPOJdo 1lTucyHd5Gzu1V6u2pimg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdduiedtleefucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhephffvvefufffkjghfggfgtgesthfuredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeekfeehfedtgedtjeehueeutdfgleefieevkeeikeelkefflefgtdev ieehheffudenucffohhmrghinhepughpughkrdhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdr nhgvthdpnhgspghrtghpthhtohepkedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtoh eprhhonhhgfigvihhlsehnvhhiughirgdrtghomhdprhgtphhtthhopehluhgtrgdrsgho tggtrghsshhisehgmhgrihhlrdgtohhmpdhrtghpthhtohepshhtrggslhgvseguphgukh drohhrghdprhgtphhtthhopehmrghtrghnsehnvhhiughirgdrtghomhdprhgtphhtthho pehvihgrtghhvghslhgrvhhosehnvhhiughirgdrtghomhdprhgtphhtthhopehorhhikh grsehnvhhiughirgdrtghomhdprhgtphhtthhopehsuhgrnhhmihhnghhmsehnvhhiughi rgdrtghomhdprhgtphhtthhopehmihgthhgrvghlsggrsehnvhhiughirgdrtghomh X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 28 Oct 2025 09:10:23 -0400 (EDT) From: Thomas Monjalon To: Rongwei Liu , Luca Boccassi Cc: stable@dpdk.org, matan@nvidia.com, viacheslavo@nvidia.com, orika@nvidia.com, suanmingm@nvidia.com, michaelba@nvidia.com Subject: Re: [PATCH22.11 v1] net/mlx5: fix age checking crash Date: Tue, 28 Oct 2025 14:10:21 +0100 Message-ID: <3058440.n97fhnxGW3@thomas> In-Reply-To: References: <20251028081601.1749225-1-rongweil@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org 28/10/2025 13:13, Luca Boccassi: > On Tue, 28 Oct 2025 at 08:17, Rongwei Liu wrote: > > > > When aging is configured, there is a background thread > > which queries all the counters in the pool. > > > > Meantime, per queue flow insertion/deletion/update changes > > the counter pool too. It introduces a race condition between > > resetting counters's in_used and age_idx fields during flow deletion > > and reading them in the background thread. > > > > To resolve it, all key members of counter's struct > > are placed in a single uint32_t and they are accessed atomically. > > > > To avoid the occasional timestamp equalization with age_idx, > > query_gen_when_free is moved out of the union. The total memory > > size is kept the same. > > > > Fixes: 04a4de756e14 ("net/mlx5: support flow age action with HWS") > > Cc: michaelba@nvidia.com > > Cc: stable@dpdk.org > > Signed-off-by: Rongwei Liu > > Hi, > > I cannot seem to find a reference to this patch on the main branch? > Was it merged with a different commit? It seems Rongwei didn't reuse the title updated while merging in main: https://git.dpdk.org/dpdk/commit/?id=820ca7361bb Note the new title is more precise, please use it: net/mlx5: fix flow aging race condition