* [dpdk-stable] [PATCH] service: fix wrong lcore indexes
@ 2020-07-04 14:35 Andrew Rybchenko
2020-07-04 15:06 ` [dpdk-stable] [dpdk-dev] " Honnappa Nagarahalli
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Andrew Rybchenko @ 2020-07-04 14:35 UTC (permalink / raw)
To: dev; +Cc: Igor Romanov, stable, Harry van Haaren
From: Igor Romanov <igor.romanov@oktetlabs.ru>
The service core list is populated, but not used. Incorrect
lcore states are examined for a service.
Use the populated list to iterate over service cores.
Fixes: e30dd31847d2 ("service: add mechanism for quiescing")
Cc: stable@dpdk.org
Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
lib/librte_eal/common/rte_service.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c
index 6123a2124d..e2795f857e 100644
--- a/lib/librte_eal/common/rte_service.c
+++ b/lib/librte_eal/common/rte_service.c
@@ -422,7 +422,7 @@ rte_service_may_be_active(uint32_t id)
return -EINVAL;
for (i = 0; i < lcore_count; i++) {
- if (lcore_states[i].service_active_on_lcore[id])
+ if (lcore_states[ids[i]].service_active_on_lcore[id])
return 1;
}
--
2.17.1
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH] service: fix wrong lcore indexes
2020-07-04 14:35 [dpdk-stable] [PATCH] service: fix wrong lcore indexes Andrew Rybchenko
@ 2020-07-04 15:06 ` Honnappa Nagarahalli
2020-07-04 15:10 ` David Marchand
2020-07-06 11:05 ` [dpdk-stable] [PATCH v2 1/2] service: fix wrong lcore indices Andrew Rybchenko
2020-07-07 10:45 ` [dpdk-stable] [PATCH v3 " Andrew Rybchenko
2 siblings, 1 reply; 9+ messages in thread
From: Honnappa Nagarahalli @ 2020-07-04 15:06 UTC (permalink / raw)
To: Andrew Rybchenko, dev
Cc: Igor Romanov, stable, Harry van Haaren, Honnappa Nagarahalli, nd, nd
Hi Andrew/Igor,
A effective test case is missing for this, can you please add a test case? Otherwise it looks good.
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Andrew Rybchenko
> Sent: Saturday, July 4, 2020 9:36 AM
> To: dev@dpdk.org
> Cc: Igor Romanov <igor.romanov@oktetlabs.ru>; stable@dpdk.org; Harry van
> Haaren <harry.van.haaren@intel.com>
> Subject: [dpdk-dev] [PATCH] service: fix wrong lcore indexes
Nit, 'indices' would be better? ^^^^^^^
>
> From: Igor Romanov <igor.romanov@oktetlabs.ru>
>
> The service core list is populated, but not used. Incorrect lcore states are
> examined for a service.
>
> Use the populated list to iterate over service cores.
>
> Fixes: e30dd31847d2 ("service: add mechanism for quiescing")
> Cc: stable@dpdk.org
>
> Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> lib/librte_eal/common/rte_service.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/common/rte_service.c
> b/lib/librte_eal/common/rte_service.c
> index 6123a2124d..e2795f857e 100644
> --- a/lib/librte_eal/common/rte_service.c
> +++ b/lib/librte_eal/common/rte_service.c
> @@ -422,7 +422,7 @@ rte_service_may_be_active(uint32_t id)
> return -EINVAL;
>
> for (i = 0; i < lcore_count; i++) {
> - if (lcore_states[i].service_active_on_lcore[id])
> + if (lcore_states[ids[i]].service_active_on_lcore[id])
> return 1;
> }
>
> --
> 2.17.1
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH] service: fix wrong lcore indexes
2020-07-04 15:06 ` [dpdk-stable] [dpdk-dev] " Honnappa Nagarahalli
@ 2020-07-04 15:10 ` David Marchand
2020-07-06 11:09 ` Andrew Rybchenko
0 siblings, 1 reply; 9+ messages in thread
From: David Marchand @ 2020-07-04 15:10 UTC (permalink / raw)
To: Andrew Rybchenko, Igor Romanov
Cc: dev, stable, Harry van Haaren, Honnappa Nagarahalli, nd
On Sat, Jul 4, 2020 at 5:07 PM Honnappa Nagarahalli
<Honnappa.Nagarahalli@arm.com> wrote:
>
> Hi Andrew/Igor,
> A effective test case is missing for this, can you please add a test case? Otherwise it looks good.
+1, I was about to reply this.
--
David Marchand
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] service: fix wrong lcore indexes
2020-07-04 15:10 ` David Marchand
@ 2020-07-06 11:09 ` Andrew Rybchenko
0 siblings, 0 replies; 9+ messages in thread
From: Andrew Rybchenko @ 2020-07-06 11:09 UTC (permalink / raw)
To: David Marchand, Igor Romanov
Cc: dev, stable, Harry van Haaren, Honnappa Nagarahalli, nd
On 7/4/20 6:10 PM, David Marchand wrote:
> On Sat, Jul 4, 2020 at 5:07 PM Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com> wrote:
>>
>> Hi Andrew/Igor,
>> A effective test case is missing for this, can you please add a test case? Otherwise it looks good.
>
> +1, I was about to reply this.
Done in v2
^ permalink raw reply [flat|nested] 9+ messages in thread
* [dpdk-stable] [PATCH v2 1/2] service: fix wrong lcore indices
2020-07-04 14:35 [dpdk-stable] [PATCH] service: fix wrong lcore indexes Andrew Rybchenko
2020-07-04 15:06 ` [dpdk-stable] [dpdk-dev] " Honnappa Nagarahalli
@ 2020-07-06 11:05 ` Andrew Rybchenko
2020-07-07 10:45 ` [dpdk-stable] [PATCH v3 " Andrew Rybchenko
2 siblings, 0 replies; 9+ messages in thread
From: Andrew Rybchenko @ 2020-07-06 11:05 UTC (permalink / raw)
To: dev; +Cc: Igor Romanov, stable, Harry van Haaren
From: Igor Romanov <igor.romanov@oktetlabs.ru>
The service core list is populated, but not used. Incorrect
lcore states are examined for a service.
Use the populated list to iterate over service cores.
Fixes: e30dd31847d2 ("service: add mechanism for quiescing")
Cc: stable@dpdk.org
Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
lib/librte_eal/common/rte_service.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c
index 6123a2124d..e2795f857e 100644
--- a/lib/librte_eal/common/rte_service.c
+++ b/lib/librte_eal/common/rte_service.c
@@ -422,7 +422,7 @@ rte_service_may_be_active(uint32_t id)
return -EINVAL;
for (i = 0; i < lcore_count; i++) {
- if (lcore_states[i].service_active_on_lcore[id])
+ if (lcore_states[ids[i]].service_active_on_lcore[id])
return 1;
}
--
2.17.1
^ permalink raw reply [flat|nested] 9+ messages in thread* [dpdk-stable] [PATCH v3 1/2] service: fix wrong lcore indices
2020-07-04 14:35 [dpdk-stable] [PATCH] service: fix wrong lcore indexes Andrew Rybchenko
2020-07-04 15:06 ` [dpdk-stable] [dpdk-dev] " Honnappa Nagarahalli
2020-07-06 11:05 ` [dpdk-stable] [PATCH v2 1/2] service: fix wrong lcore indices Andrew Rybchenko
@ 2020-07-07 10:45 ` Andrew Rybchenko
2020-07-07 13:14 ` Van Haaren, Harry
2020-07-07 19:33 ` Honnappa Nagarahalli
2 siblings, 2 replies; 9+ messages in thread
From: Andrew Rybchenko @ 2020-07-07 10:45 UTC (permalink / raw)
To: dev; +Cc: Igor Romanov, stable, Harry van Haaren
From: Igor Romanov <igor.romanov@oktetlabs.ru>
The service core list is populated, but not used. Incorrect
lcore states are examined for a service.
Use the populated list to iterate over service cores.
Fixes: e30dd31847d2 ("service: add mechanism for quiescing")
Cc: stable@dpdk.org
Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
lib/librte_eal/common/rte_service.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c
index 6123a2124d..e2795f857e 100644
--- a/lib/librte_eal/common/rte_service.c
+++ b/lib/librte_eal/common/rte_service.c
@@ -422,7 +422,7 @@ rte_service_may_be_active(uint32_t id)
return -EINVAL;
for (i = 0; i < lcore_count; i++) {
- if (lcore_states[i].service_active_on_lcore[id])
+ if (lcore_states[ids[i]].service_active_on_lcore[id])
return 1;
}
--
2.17.1
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-stable] [PATCH v3 1/2] service: fix wrong lcore indices
2020-07-07 10:45 ` [dpdk-stable] [PATCH v3 " Andrew Rybchenko
@ 2020-07-07 13:14 ` Van Haaren, Harry
2020-07-07 21:56 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2020-07-07 19:33 ` Honnappa Nagarahalli
1 sibling, 1 reply; 9+ messages in thread
From: Van Haaren, Harry @ 2020-07-07 13:14 UTC (permalink / raw)
To: Andrew Rybchenko, dev; +Cc: Igor Romanov, stable
> -----Original Message-----
> From: Andrew Rybchenko <arybchenko@solarflare.com>
> Sent: Tuesday, July 7, 2020 11:45 AM
> To: dev@dpdk.org
> Cc: Igor Romanov <igor.romanov@oktetlabs.ru>; stable@dpdk.org; Van Haaren,
> Harry <harry.van.haaren@intel.com>
> Subject: [PATCH v3 1/2] service: fix wrong lcore indices
>
> From: Igor Romanov <igor.romanov@oktetlabs.ru>
>
> The service core list is populated, but not used. Incorrect
> lcore states are examined for a service.
>
> Use the populated list to iterate over service cores.
>
> Fixes: e30d d318 47d2 ("service: add mechanism for quiescing")
> Cc: stable@dpdk.org
I believe the original adding of quiescing did not have this exact bug (ids[] was used)?
It seems to have been introduced when reworking to avoid false sharing, so fixes is:
Fixes: e484ccddbe1b ("services: avoid false sharing on core state")
> Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Code change itself:
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
<snip patch>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH v3 1/2] service: fix wrong lcore indices
2020-07-07 13:14 ` Van Haaren, Harry
@ 2020-07-07 21:56 ` Thomas Monjalon
0 siblings, 0 replies; 9+ messages in thread
From: Thomas Monjalon @ 2020-07-07 21:56 UTC (permalink / raw)
To: Andrew Rybchenko, Igor Romanov; +Cc: dev, stable, Van Haaren, Harry
07/07/2020 15:14, Van Haaren, Harry:
> From: Andrew Rybchenko <arybchenko@solarflare.com>
> > From: Igor Romanov <igor.romanov@oktetlabs.ru>
> >
> > The service core list is populated, but not used. Incorrect
> > lcore states are examined for a service.
> >
> > Use the populated list to iterate over service cores.
> >
> > Fixes: e30d d318 47d2 ("service: add mechanism for quiescing")
> > Cc: stable@dpdk.org
>
> I believe the original adding of quiescing did not have this exact bug (ids[] was used)?
> It seems to have been introduced when reworking to avoid false sharing, so fixes is:
> Fixes: e484ccddbe1b ("services: avoid false sharing on core state")
>
>
> > Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
> > Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>
> Code change itself:
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Series applied, thanks
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v3 1/2] service: fix wrong lcore indices
2020-07-07 10:45 ` [dpdk-stable] [PATCH v3 " Andrew Rybchenko
2020-07-07 13:14 ` Van Haaren, Harry
@ 2020-07-07 19:33 ` Honnappa Nagarahalli
1 sibling, 0 replies; 9+ messages in thread
From: Honnappa Nagarahalli @ 2020-07-07 19:33 UTC (permalink / raw)
To: Andrew Rybchenko, dev
Cc: Igor Romanov, stable, Harry van Haaren, nd, Honnappa Nagarahalli, nd
<snip>
> Subject: [dpdk-dev] [PATCH v3 1/2] service: fix wrong lcore indices
>
> From: Igor Romanov <igor.romanov@oktetlabs.ru>
>
> The service core list is populated, but not used. Incorrect lcore states are
> examined for a service.
>
> Use the populated list to iterate over service cores.
>
> Fixes: e30dd31847d2 ("service: add mechanism for quiescing")
> Cc: stable@dpdk.org
>
> Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
LGTM
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> ---
> lib/librte_eal/common/rte_service.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/common/rte_service.c
> b/lib/librte_eal/common/rte_service.c
> index 6123a2124d..e2795f857e 100644
> --- a/lib/librte_eal/common/rte_service.c
> +++ b/lib/librte_eal/common/rte_service.c
> @@ -422,7 +422,7 @@ rte_service_may_be_active(uint32_t id)
> return -EINVAL;
>
> for (i = 0; i < lcore_count; i++) {
> - if (lcore_states[i].service_active_on_lcore[id])
> + if (lcore_states[ids[i]].service_active_on_lcore[id])
> return 1;
> }
>
> --
> 2.17.1
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-07-07 21:56 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-04 14:35 [dpdk-stable] [PATCH] service: fix wrong lcore indexes Andrew Rybchenko
2020-07-04 15:06 ` [dpdk-stable] [dpdk-dev] " Honnappa Nagarahalli
2020-07-04 15:10 ` David Marchand
2020-07-06 11:09 ` Andrew Rybchenko
2020-07-06 11:05 ` [dpdk-stable] [PATCH v2 1/2] service: fix wrong lcore indices Andrew Rybchenko
2020-07-07 10:45 ` [dpdk-stable] [PATCH v3 " Andrew Rybchenko
2020-07-07 13:14 ` Van Haaren, Harry
2020-07-07 21:56 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2020-07-07 19:33 ` Honnappa Nagarahalli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).