From: Ferruh Yigit <ferruh.yigit@intel.com>
To: <michaelba@nvidia.com>, <dev@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>,
Raslan Darawsheh <rasland@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>, <stable@dpdk.org>
Subject: Re: [PATCH 2/3] net/mlx5: improve stride parameter names
Date: Tue, 7 Dec 2021 13:33:42 +0000 [thread overview]
Message-ID: <30deca6b-b60d-134f-baaf-175ed0c8bc8f@intel.com> (raw)
In-Reply-To: <20211123183805.2905792-3-michaelba@nvidia.com>
On 11/23/2021 6:38 PM, michaelba@nvidia.com wrote:
> From: Michael Baum<michaelba@nvidia.com>
>
> In the striding RQ management there are two important parameters, the
> size of the single stride in bytes and the number of strides.
>
> Both the data-path structure and config structure keep the log of the
> above parameters. However, in their names there is no mention that the
> value is a log which may be misleading as if the fields represent the
> values themselves.
>
> This patch updates their names describing the values more accurately.
>
> Cc:stable@dpdk.org
>
Can you please provide fixes tag for it?
In this case commit(s) adding the parameters with bad name.
> Signed-off-by: Michael Baum<michaelba@nvidia.com>
> Acked-by: Matan Azrad<matan@nvidia.com>
next prev parent reply other threads:[~2021-12-07 13:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211123183805.2905792-1-michaelba@nvidia.com>
2021-11-23 18:38 ` [PATCH 1/3] common/mlx5: add min WQE size for striding RQ michaelba
2021-12-07 13:32 ` Ferruh Yigit
2021-12-08 12:52 ` Michael Baum
2021-11-23 18:38 ` [PATCH 2/3] net/mlx5: improve stride parameter names michaelba
2021-12-07 13:33 ` Ferruh Yigit [this message]
2021-12-08 12:52 ` Michael Baum
2021-11-23 18:38 ` [PATCH 3/3] net/mlx5: fix missing adjustment MPRQ stride devargs michaelba
2021-11-23 20:41 ` Raslan Darawsheh
2021-12-07 13:40 ` Ferruh Yigit
2021-12-08 12:52 ` Michael Baum
2021-12-08 14:00 ` Ferruh Yigit
2021-12-08 15:40 ` Matan Azrad
2021-12-09 12:33 ` Kevin Traynor
2021-12-10 16:58 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30deca6b-b60d-134f-baaf-175ed0c8bc8f@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=michaelba@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).