patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"Zhang, AlvinX" <alvinx.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v2] net/iavf: fix pointer of meter data
Date: Thu, 11 Nov 2021 23:53:55 +0000
Message-ID: <30df16a5f9f64915b4b05dd3578c9169@intel.com> (raw)
In-Reply-To: <aeb65a01-f31c-ebe5-a8ef-f02a0caaa93e@intel.com>



> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yigit@intel.com>
> Sent: Friday, November 12, 2021 1:21 AM
> To: Zhang, AlvinX <alvinx.zhang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [PATCH v2] net/iavf: fix pointer of meter data
> 
> On 11/11/2021 6:31 AM, Alvin Zhang wrote:
> > This patch fixes coverity issue by directly passing the address of the
> > meter data to lower function.
> >
> > Coverity issue: 373867
> >
> > Fixes: 91f27b2e39ab ("net/iavf: refactor RSS")
> 
> As far as I can see fixed commit is:
> Fixes: 7be10c3004be ("net/iavf: add RSS configuration for VF")

+1,this should be the patch that bring the issue, thanks.

> 
> I will update in the next-net, can you please double check?
> 
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> > ---
> >   drivers/net/iavf/iavf_hash.c | 5 ++---
> >   1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/iavf/iavf_hash.c
> > b/drivers/net/iavf/iavf_hash.c index 55d8a11..5e0888e 100644
> > --- a/drivers/net/iavf/iavf_hash.c
> > +++ b/drivers/net/iavf/iavf_hash.c
> > @@ -1261,10 +1261,9 @@ struct rss_attr_type {
> >   static int
> >   iavf_hash_parse_action(struct iavf_pattern_match_item *match_item,
> >   		       const struct rte_flow_action actions[],
> > -		       uint64_t pattern_hint, void **meta,
> > +		       uint64_t pattern_hint, struct iavf_rss_meta *rss_meta,
> >   		       struct rte_flow_error *error)
> >   {
> > -	struct iavf_rss_meta *rss_meta = (struct iavf_rss_meta *)*meta;
> >   	struct virtchnl_proto_hdrs *proto_hdrs;
> >   	enum rte_flow_action_type action_type;
> >   	const struct rte_flow_action_rss *rss; @@ -1378,7 +1377,7 @@ struct
> > rss_attr_type {
> >   		goto error;
> >
> >   	ret = iavf_hash_parse_action(pattern_match_item, actions, phint,
> > -				     (void **)&rss_meta_ptr, error);
> > +				     rss_meta_ptr, error);
> >
> >   error:
> >   	if (!ret && meta)
> >


      reply	other threads:[~2021-11-11 23:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-11  2:49 [PATCH] " Alvin Zhang
2021-11-11  6:31 ` [PATCH v2] " Alvin Zhang
2021-11-11 13:12   ` Zhang, Qi Z
2021-11-11 17:21   ` Ferruh Yigit
2021-11-11 23:53     ` Zhang, Qi Z [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30df16a5f9f64915b4b05dd3578c9169@intel.com \
    --to=qi.z.zhang@intel.com \
    --cc=alvinx.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git