From: Maryam Tahhan <mtahhan@redhat.com>
To: "Loftus, Ciara" <ciara.loftus@intel.com>,
"ferruh.yigit@amd.com" <ferruh.yigit@amd.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
"lihuisong@huawei.com" <lihuisong@huawei.com>,
"fengchengwen@huawei.com" <fengchengwen@huawei.com>,
"liuyonglong@huawei.com" <liuyonglong@huawei.com>,
"Marchand, David" <david.marchand@redhat.com>,
"Koikkara Reeny, Shibin" <shibin.koikkara.reeny@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [v13 2/3] net/af_xdp: fix multi interface support for K8s
Date: Mon, 8 Apr 2024 13:50:50 +0100 [thread overview]
Message-ID: <30f91607-af92-47b9-aed3-0a6d47c2d725@redhat.com> (raw)
In-Reply-To: <MW4PR11MB58729A89528D5C311BE142078E002@MW4PR11MB5872.namprd11.prod.outlook.com>
On 08/04/2024 11:46, Loftus, Ciara wrote:
>> +#ifdef ETH_AF_XDP_UPDATE_XSKMAP
>> +static __rte_always_inline int
>> +update_xskmap(struct xsk_socket *xsk, int map_fd, int xsk_queue_idx
>> __rte_unused)
>> +{
>> + return xsk_socket__update_xskmap(xsk, map_fd);
>> +}
>> +#else
>> +static __rte_always_inline int
>> +update_xskmap(struct xsk_socket *xsk, int map_fd, int xsk_queue_idx)
>> +{
>> + int fd = xsk_socket__fd(xsk);
> 'fd' computed here is not used in this function so generates an unused variable warning.
Thanks Ciara, sorry I missed this. I will fix it
>> + return bpf_map_update_elem(map_fd, &xsk_queue_idx, &map_fd,
>> 0);
>> +}
>> +#endif
>> +
next prev parent reply other threads:[~2024-04-08 12:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240404142326.2151118-1-mtahhan@redhat.com>
2024-04-04 14:23 ` [v13 1/3] docs: AF_XDP Device Plugin Maryam Tahhan
2024-04-04 14:23 ` [v13 2/3] net/af_xdp: fix multi interface support for K8s Maryam Tahhan
2024-04-08 10:46 ` Loftus, Ciara
2024-04-08 12:50 ` Maryam Tahhan [this message]
2024-04-08 13:12 ` Maryam Tahhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30f91607-af92-47b9-aed3-0a6d47c2d725@redhat.com \
--to=mtahhan@redhat.com \
--cc=ciara.loftus@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=ferruh.yigit@amd.com \
--cc=lihuisong@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=shibin.koikkara.reeny@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).