From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30057.outbound.protection.outlook.com [40.107.3.57]) by dpdk.org (Postfix) with ESMTP id 2FDCB2C58; Thu, 14 Sep 2017 10:05:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Iyw2rMFvuB/GLR3P8+xJl5h8M4qzyIxxEYFMiRpH+Ts=; b=lBHpG+SMpOL5K3kEUd3/PkdCOXZVRWkm3A9mg2dQtLmnShJXFQ59rt88oVHGAsWcDQp98N9fx0uthUxkFcFcw3jVXVopcH4HwBb7ePkitDBaRbSblA7B8Gmp0jKh09e4aD0bwUJJQsNWAT4QCQjiEdGqDZKhC1qwv1oBIyhz3Vc= Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com (10.167.195.147) by VI1PR0501MB2735.eurprd05.prod.outlook.com (10.172.11.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.35.12; Thu, 14 Sep 2017 08:05:25 +0000 Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::7921:ae50:9b96:93ba]) by VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::7921:ae50:9b96:93ba%14]) with mapi id 15.20.0056.010; Thu, 14 Sep 2017 08:05:25 +0000 From: Yongseok Koh To: Shahaf Shuler CC: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "Adrien Mazarguil" , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v4 4/4] net/mlx5: enforce Tx num of segments limitation Thread-Index: AQHTLH4q2joZKfhfkESKXPmeYUxnWKKyxSoAgAEVDoCAAC08Ug== Date: Thu, 14 Sep 2017 08:05:25 +0000 Message-ID: <31018994-DB44-486B-B880-579804057124@mellanox.com> References: <7b6d42c0c5e1a04f8483b6546ea0b1db8fb7ceee.1505133966.git.shahafs@mellanox.com> <20170913195154.GA4263@yongseok-MBP.local>, In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [73.222.116.174] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0501MB2735; 6:N6htqBlNQN443fyAtvlLj78zPgqXRbkfieF3n+j0AM/gKcR0ZNEg51t2sAjSDlYn3E3UsUFt/NZIqlMl1448WyqutOaRPvBZYoYljjZnoS0RTFn6V7pE4zxtD1dvLW0bUTzkZ2OhLp0qDAIKTjT4FoPexlTY3sPLqmI4oPScCEQhTcdpF7p1IZQnHQe/NS70SH2ETWYv0ds/tntRtwX3vKvk5offlL9UsGM165MIW21kfZbfYiAaee9FIpYpsCS7goDMD8+xUPVcgv50Wrbsm65zsOxzjEdL+YD3mGPplWR73zQjiCiS0trAQMwWJNVlp9Fiq54t1C39FCB2WeUd4Q==; 5:pzjsJdBr/oIeQd/u5AJ1FnDf5qSTyuPXiYhgTMpj6V3TOJLALL4zx5h9YUYzGjb03kO7BTxxbVAnjVxXIrgfW1lJJYNHSuFF4RYig6tmLbpkF5CUKUf9u7sHWC42lVsu0YJAi0u2SDxEiz6CVz8hnA==; 24:JZVZyUS7rqaWdFAQLvGSDSbGYM/a6KZIfgdvwrSD64QFV5D4gX/GSPGUMvxA3HjcxguGlTC7WZ1mbhxnv7vwQmHaSJfB5Ve6FxC4jfIRvE4=; 7:JwGLGr7WEmRjGXqfsRwBaiCb/TsUtyj5NxsynIz+T2meeGVscm+ylWEmZ2oAwT2cD47j/4QqlqHCiNhJZyDCYdG94aGvlici/nhxhfGfjA1aB47NNVa1CAJIhcnUtP2rz8PO6QpinAHIqhhKlSOsFhIhO3Y40QHm+3TV8Srvv0PCxcNSEv1A9bVCOlJhrOuXUGlH2sxUZlJAs7Ft+Ih8m/2iMqTq1l/y/0A3b9/uBT8= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-office365-filtering-correlation-id: 7299e196-5124-4020-21ea-08d4fb475b31 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:VI1PR0501MB2735; x-ms-traffictypediagnostic: VI1PR0501MB2735: x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041248)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123560025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:VI1PR0501MB2735; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VI1PR0501MB2735; x-forefront-prvs: 0430FA5CB7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(189002)(199003)(377454003)(24454002)(3280700002)(76176999)(3846002)(50986999)(97736004)(4326008)(6862004)(101416001)(305945005)(3660700001)(5660300001)(14454004)(6636002)(33656002)(6116002)(99286003)(102836003)(6246003)(7736002)(82746002)(25786009)(6512007)(2950100002)(54906002)(2906002)(53936002)(36756003)(54356999)(83716003)(66066001)(105586002)(106356001)(8936002)(189998001)(229853002)(81166006)(81156014)(8676002)(110136004)(6486002)(5250100002)(6506006)(2900100001)(86362001)(93886005)(6436002)(316002)(53546010)(478600001)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2735; H:VI1PR0501MB2045.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Sep 2017 08:05:25.5716 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2735 Subject: Re: [dpdk-stable] [PATCH v4 4/4] net/mlx5: enforce Tx num of segments limitation X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Sep 2017 08:05:27 -0000 Thanks! Yongseok > On Sep 13, 2017, at 10:23 PM, Shahaf Shuler wrote: >=20 > Hi Yongseok, >=20 > Wednesday, September 13, 2017 10:52 PM, Yongseok Koh: >>>=20 >>> +/* Maximum number of DS in WQE. */ >>> +#define MLX5_MAX_DS 63 >> How about make it consistent with MLX5_MPW_DSEG_MAX by naming >> MLX5_DSEG_MAX? >=20 > It doesn't have the same meaning.=20 >=20 > The MLX5_MPW_DSEG_MAX is to limit the number of mbuf segments (buf->nb_se= gs) for multi packet wqe. The inline part is taken into account different= ly.=20 > The MLX_MAX_DS is to limit the number data segments (i.e. MLX5_WQE_DWORD_= SIZE) that could be set into a WQE. This includes everything (inline, ctrl = seg, eth seg, pointers). > For the regular Tx burst there are many options for different inline size= s which impact on the max number of mbuf segments possible. I should've been clearer. I just suggested a small change from DS to DSEG a= s I thought DS and DSEG are same. But if it just comes from the field name = in WQE Ctrl segment, MLX5_WQE_DS_MAX or MLX5_WQE_CTRL_DS_MAX could be good.= I hoped it could be a little more explanatory. I'm not good at naming, wil= l defer to you. :-) > BTW - am still not sure why we have the MLX5_MPW_DSEG_MAX limitation. I don't know either. We should discuss it with chip design. Thanks Yongseok =