From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: bruce.richardson@intel.com, bluca@debian.org,
dmitry.kozliuk@gmail.com, olivier.matz@6wind.com,
thierry.herbelot@6wind.com,
Gabriel Ganne <gabriel.ganne@6wind.com>,
stable@dpdk.org, Harry van Haaren <harry.van.haaren@intel.com>,
Luca Boccassi <luca.boccassi@gmail.com>,
Keith Wiles <keith.wiles@intel.com>,
david.marchand@redhat.com
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v5] build: remove redundant libpcap link
Date: Wed, 14 Apr 2021 11:41:53 +0200 [thread overview]
Message-ID: <3119483.LeJDoi8FaI@thomas> (raw)
In-Reply-To: <20210409122551.265939-1-thomas@monjalon.net>
09/04/2021 14:25, Thomas Monjalon:
> From: Gabriel Ganne <gabriel.ganne@6wind.com>
>
> The pcap PMD and the librte_port both declare their dependency to libpcap
> with a line "ext_deps += pcap_dep".
> Then meson automatically adds this dependency to the pkg-config file
> in the "Requires.private" section for static builds.
>
> The additional update of dpdk_extra_ldflags was adding the dependency
> in the "Libs.private" section of the pkg-config, that is unnecessary.
>
> Fixes: efd5d1a8d8dd ("drivers/net: build some vdev PMDs with meson")
> Fixes: 268fa581b1ff ("port: fix pcap support with meson")
> Cc: stable@dpdk.org
>
> Signed-off-by: Gabriel Ganne <gabriel.ganne@6wind.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> I have a doubt whether this option is really always useless.
> In the case of an old pcap (<1.9) without pkg-config support,
> and with the minimum meson supported (0.47.1),
> are we sure the generated pkg-config file will include -lpcap?
Any volunteer to test please?
next prev parent reply other threads:[~2021-04-14 9:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210409083927.8345-1-gabriel.ganne@6wind.com>
2021-04-09 12:25 ` [dpdk-stable] " Thomas Monjalon
2021-04-14 9:41 ` Thomas Monjalon [this message]
2021-04-14 21:02 ` [dpdk-stable] [dpdk-dev] " Dmitry Kozlyuk
2021-04-14 21:10 ` Thomas Monjalon
2023-07-16 17:19 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3119483.LeJDoi8FaI@thomas \
--to=thomas@monjalon.net \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=gabriel.ganne@6wind.com \
--cc=harry.van.haaren@intel.com \
--cc=keith.wiles@intel.com \
--cc=luca.boccassi@gmail.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
--cc=thierry.herbelot@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).