From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 08323A0351
	for <public@inbox.dpdk.org>; Tue,  1 Feb 2022 08:44:54 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id ED0B3411ED;
	Tue,  1 Feb 2022 08:44:53 +0100 (CET)
Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com
 [64.147.123.21])
 by mails.dpdk.org (Postfix) with ESMTP id 2CCBC40685;
 Tue,  1 Feb 2022 08:44:51 +0100 (CET)
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.west.internal (Postfix) with ESMTP id 5112F32021C2;
 Tue,  1 Feb 2022 02:44:49 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute5.internal (MEProxy); Tue, 01 Feb 2022 02:44:50 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:cc:content-transfer-encoding:content-type:date:date:from:from
 :in-reply-to:in-reply-to:message-id:mime-version:references
 :reply-to:sender:subject:subject:to:to; s=fm3; bh=yw2VxCej1bHwqS
 FPXxjQJmo4C3KX9F8vY1rv7U5yjnw=; b=lGm1Yad99ozYq6e34oOB1grbv5djEr
 MuwuqzycxYQZ3h5QhgprGevgk0RquRjn+ptkv0tL+RFX/EKYQoHXW8BnWsMgOk9D
 lF4HVvjlqJMi+orMU/JUdEbLkpkP+QYyULxt5Asg/ppni/CNHbREYTv9VF1m+8t/
 EXZ+xGkcaK4IFd0FtJPza3K2c44O2ochvCytcalEOVKVkfw7Odn/jH2ffE1JGc4D
 QjKg8oUwZQwzh8CT5YBlR4InGuaFAt9ygD9MSbXiBio3g7JN+hXuTgQ3BNezrgRi
 BJXy3qxEl9P+avwC9ksxUf8lyPyqEx/8ymN/Sh+0Hjdj+QAgbyRHfwdQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:date:date:from:from:in-reply-to:in-reply-to
 :message-id:mime-version:references:reply-to:sender:subject
 :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=yw2VxCej1bHwqSFPXxjQJmo4C3KX9F8vY1rv7U5yj
 nw=; b=kB8DkMAzsK+hvAdQTr0DvT2k2n37pgwn4K9ezi/nWjyk4cGXsHCc7diTQ
 pt9ixnV4XMbB3qneJOBJ/Su7d6wKcdXkBkU0eTaEO1MoVZoVGfmbtpFrEa8pH8ET
 xBt7LJnQgJPhsu5E2NeClxEJUGWKbtL4sIgp6Hg3fS93ML9rYhEUQf6vAd5eapK+
 Q7XfL8/x4FUhkmfGZNsqX33QL94HSfPx5DLz7KuAUsQyRxAp155ewlg6Bz0OMGTE
 jKZWdIXLl3OIUvdrn9wABm12jvmPtbS+9xRk7SgLGWxHr3kbrTApAiQkh4Ztw7zi
 E3KIeCAtct4+PMCoNDRrPJMvoNLew==
X-ME-Sender: <xms:8OT4YarUdWMi5HkRXgBTcAbvKxicdt2CCXnFKnyg_BdnHfq2wmc_Rg>
 <xme:8OT4YYpk6vZH1_IzyAjHEsefcI8oKRk69tecyWLFYsKBbQtUVcTa5HTchRoH6mTvS
 UrC1Yi8sdqQLoyi4A>
X-ME-Received: <xmr:8OT4YfMiuQqT5MI765Pv34bCB9b4XeVaCKtvGqEUC0js9BRuTlcUdP5yk-Pgd_zn1qP_UTAtCKhSgK1JM-2oyEc6rg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrgedvgdduuddvucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
 ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu
 ieeivdffgeehnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrh
 homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:8OT4YZ6fIR2ZvHAFAS-LOcxU9bnHSiEConXm6Fljq4OYKsuCWQY0yQ>
 <xmx:8OT4YZ6upAL6oKRf--jMZof7D8_z4CyVpmYGwfUXKKuuWI4A7xabuw>
 <xmx:8OT4YZjpjpMAB1TO0JfKApdax27lvlYMFDxEXxDeEU6Ljashyjb0ag>
 <xmx:8OT4YWu4CfXa9Q0ZgtHmC63_1bNEqYTQuh0LXRCGnF1kpTsn9fsjmA>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
 1 Feb 2022 02:44:47 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
 Rakesh Kudurumalla <rkudurumalla@marvell.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>, "dev@dpdk.org" <dev@dpdk.org>,
 "david.marchand@redhat.com" <david.marchand@redhat.com>,
 "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
 "andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>,
 "ajit.khaparde@broadcom.com" <ajit.khaparde@broadcom.com>
Subject: Re: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are
 full and Tx fails
Date: Tue, 01 Feb 2022 08:44:45 +0100
Message-ID: <3120644.AJdgDx1Vlc@thomas>
In-Reply-To: <BN8PR18MB248252B7B98FFEB2FDE77C13CF269@BN8PR18MB2482.namprd18.prod.outlook.com>
References: <20210720124713.603674-1-rkudurumalla@marvell.com>
 <BN8PR18MB2482AD9B6C4FEA0BAFB95635CF509@BN8PR18MB2482.namprd18.prod.outlook.com>
 <BN8PR18MB248252B7B98FFEB2FDE77C13CF269@BN8PR18MB2482.namprd18.prod.outlook.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org

octeontx2 driver is removed
Can we close this patch?


01/02/2022 07:30, Rakesh Kudurumalla:
> ping
> 
> > -----Original Message-----
> > From: Rakesh Kudurumalla
> > Sent: Monday, January 10, 2022 2:35 PM
> > To: Thomas Monjalon <thomas@monjalon.net>; Jerin Jacob Kollanukkaran
> > <jerinj@marvell.com>
> > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> > ajit.khaparde@broadcom.com
> > Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are
> > full and Tx fails
> > 
> > ping
> > 
> > > -----Original Message-----
> > > From: Rakesh Kudurumalla
> > > Sent: Monday, December 13, 2021 12:10 PM
> > > To: Thomas Monjalon <thomas@monjalon.net>; Jerin Jacob Kollanukkaran
> > > <jerinj@marvell.com>
> > > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> > > ajit.khaparde@broadcom.com
> > > Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if
> > > queues are full and Tx fails
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > Sent: Monday, November 29, 2021 2:44 PM
> > > > To: Rakesh Kudurumalla <rkudurumalla@marvell.com>; Jerin Jacob
> > > > Kollanukkaran <jerinj@marvell.com>
> > > > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> > > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> > > > ajit.khaparde@broadcom.com
> > > > Subject: Re: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if
> > > > queues are full and Tx fails
> > > >
> > > > 29/11/2021 09:52, Rakesh Kudurumalla:
> > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > > 22/11/2021 08:59, Rakesh Kudurumalla:
> > > > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > > > > 20/07/2021 18:50, Rakesh Kudurumalla:
> > > > > > > > > Current pmd_perf_autotest() in continuous mode tries to
> > > > > > > > > enqueue MAX_TRAFFIC_BURST completely before starting the
> > test.
> > > > > > > > > Some drivers cannot accept complete MAX_TRAFFIC_BURST even
> > > > > > > > > though
> > > > > > rx+tx
> > > > > > > > > desc
> > > > > > > > count
> > > > > > > > > can fit it.
> > > > > > > >
> > > > > > > > Which driver is failing to do so?
> > > > > > > > Why it cannot enqueue 32 packets?
> > > > > > >
> > > > > > > Octeontx2 driver is failing to enqueue because hardware
> > > > > > > buffers are full
> > > > > > before test.
> > > >
> > > > Aren't you stopping the support of octeontx2?
> > > > Why do you care now?
> > > >  yes we are not supporting octeontx2,but this  issue is observed in
> > > > cnxk driver ,current patch fixes the same
> > > > > >
> > > > > > Why hardware buffers are full?
> > > > > Hardware buffers are full because number of number of descriptors
> > > > > in continuous mode Is less than MAX_TRAFFIC_BURST, so if enque
> > > > > fails , there is no way hardware can drop the Packets .
> > > > > pmd_per_autotest application evaluates performance after enqueueing
> > packets Initially.
> > > > > >
> > > > > > > pmd_perf_autotest() in continuous mode tries to enqueue
> > > > > > > MAX_TRAFFIC_BURST (2048) before starting the test.
> > > > > > >
> > > > > > > > > This patch changes behaviour to stop enqueuing after few
> > retries.
> > > > > > > >
> > > > > > > > If there is a real limitation, there will be issues in more
> > > > > > > > places than this test program.
> > > > > > > > I feel it should be addressed either in the driver or at ethdev level.
> > > > > > > >
> > > > > > > > [...]
> > > > > > > > > @@ -480,10 +483,19 @@ main_loop(__rte_unused void *args)
> > > > > > > > >  			nb_tx = RTE_MIN(MAX_PKT_BURST, num);
> > > > > > > > >  			nb_tx = rte_eth_tx_burst(portid, 0,
> > > > > > > > >  						&tx_burst[idx],
> > > > nb_tx);
> > > > > > > > > +			if (nb_tx == 0)
> > > > > > > > > +				retry_cnt++;
> > > > > > > > >  			num -= nb_tx;
> > > > > > > > >  			idx += nb_tx;
> > > > > > > > > +			if (retry_cnt == MAX_RETRY_COUNT) {
> > > > > > > > > +				retry_cnt = 0;
> > > > > > > > > +				break;
> > > > > > > > > +			}
> > > >
> > > >
> 
>