patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Slava Ovsiienko <viacheslavo@nvidia.com>,
	"Jiawei(Jonny) Wang" <jiaweiw@nvidia.com>
Cc: Matan Azrad <matan@nvidia.com>, Ori Kam <orika@nvidia.com>,
	Shahaf Shuler <shahafs@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>,
	Raslan Darawsheh <rasland@nvidia.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix mirror flow split with L3 encapsulation
Date: Fri, 23 Jul 2021 16:09:36 +0200	[thread overview]
Message-ID: <3136964.cCNWhMJKoI@thomas> (raw)
In-Reply-To: <BN9PR12MB5034F2C47F90F4214310FB68C6E59@BN9PR12MB5034.namprd12.prod.outlook.com>

23/07/2021 16:01, Jiawei(Jonny) Wang:
> Hello, 
> 
> From: Thomas Monjalon <thomas@monjalon.net>
> > 23/07/2021 14:43, Jiawei Wang:
> > > Due to hardware limitations, the decap action can't follow the
> > 
> > Which decap action? Pleas be more specific.
> 
> All of decap,  vxlan_decap, nvgre_decap and raw_decap.
> Will update details.
> 
> > 
> > > sample action in the same flow, to keep the original action order of
> > > sample and decap actions the flow was internally split by PMD, and
> > > decap action was moved into suffix subflow in the new table.
> > 
> > "the" new table? which one?
> 
> " sample and decap actions the flow was internally split by PMD, " means
> that PMD split internally into two flows:prefix subflow with sample action in original table;
> suffix subflow with decap action in the new table;
> 
> > 
> > Was there an issue? Above seems to say all is fine.
> > 
> 
> The issue is mentioned below that 'L3 encapsulation' case (raw_decap+raw_encap), 
> the previous code not consier the combination decap/encap case.
> And under this case flow don't need split.
> 
> > > There is a specific combination of raw decap and raw encap actions to
> > > specify "L3 encapsulation" packet transformation - raw decap action to
> > > remove L2 header and raw encap to add the tunnel header.
> > 
> > Is this combination the problem? It was not working before this patch?
> > Please describe what happened.
> > 
> 
> L3 encap is working without sample action or sample is working without L3 encap;

OK please be more explicit in the next version.

> > > This specific L3 encapsulation is encoded as a single packet reformat
> > > hardware transaction and is supported by hardware after sample action
> > > (no hardware limitations for packet reformat).
> > >
> > > The patch checks whether the decap action is the part of "L3
> > encapsulation"
> > 
> > I think you mean "is part of".
> 
> Thanks, will fix in new version.
> 
> > 
> > > and does not move the decap action into suffix subflow for the case.
> > >
> > > Fixes: cafd87f62a06 ("net/mlx5: fix VLAN push/pop and decap actions
> > > with mirror")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
> > > Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>




  reply	other threads:[~2021-07-23 14:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-23 12:43 Jiawei Wang
2021-07-23 12:57 ` Thomas Monjalon
2021-07-23 14:01   ` Jiawei(Jonny) Wang
2021-07-23 14:09     ` Thomas Monjalon [this message]
2021-07-26  6:26       ` Jiawei(Jonny) Wang
2021-07-26  6:22 ` [dpdk-stable] [PATCH v2] " Jiawei Wang
2021-07-28 13:07   ` Raslan Darawsheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3136964.cCNWhMJKoI@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=jiaweiw@nvidia.com \
    --cc=matan@nvidia.com \
    --cc=orika@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=shahafs@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).