From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F40D04233A for ; Mon, 9 Oct 2023 11:17:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E28444067A; Mon, 9 Oct 2023 11:17:36 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2046.outbound.protection.outlook.com [40.107.220.46]) by mails.dpdk.org (Postfix) with ESMTP id B3F0B4026B; Mon, 9 Oct 2023 11:17:33 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WWrNASXcRfsqYJRynXiqVW4KqT1/XjCqKBcgMm9FMGZJJlmlBZ1MYz6YEgVOnokcnsF9nza23C3u9fH3i3Eh0VGigcfeb/cWS/cyzM0atdVVvq+HMsUI0oPa/Zwo0N1vrzYLMbOtpwmxAkOxpVCNWgxjaVO/hSE5DqqnFmmqNnmT4BsnAIeNry2fDFhEGY5ZoCEbZCpyhBHv4DUq+vtoaZs8r+kXTmUynxJ+5l37VjHjUBbmpLRJB7XYLcyl44LCRF4QBF1IoNdWME8T1ZlKMFsdqbrdzYlB2EPX9YMO1M72yyR3Dezx78AazZfDvDFi97Vv8CDzoVNFxB/dBDoY8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oCeFNGNTO4+kTDzV+TcMnF6gcNzFGcHF+/VQEEMOf8g=; b=Wdk+YHBUuJB6FmQfh9PXF31QhH8xQv+rsjxQNOxkctPjL+clPhGREhOqC4/QDP0eSvA9TxZ100xvL/gkjh/1ANm8KgYO4pB7QT54TxnZNWJJQnDuM2/mrGadfiPRixcfOGtQun16L2S2d/A6I2KNlWaDSCV0p85xJaZMdZHNaV7uvD4N25sfuf55qcQ5wnNNuQQ6oDppvdloSeiiukxNL7G3opognV/f/BAeN+iKzOMhD6+dSUyH3ahbweJ8ozjOVQegN5vnqB9qu9Hs/J6DlRzr++qJ0iJrQivjS+ADSeeFiJIJFs8PQADhZw3vIGpvrCLVTrVWdzdrox6MJwjxVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oCeFNGNTO4+kTDzV+TcMnF6gcNzFGcHF+/VQEEMOf8g=; b=yq1k+a6q2zVby3L0SOhmD8jINGbxG38I9KnkEeIFHzrRoS2dX6ZUGGZsF6aNciRoWuJwP4+t0Tmv/4vw6Ri34MSGfCuTWZLiXcxwR+/1QgL64vxRMxmnBdyoEx2liTuV0CAlmucXDsbbGQayoaaiNx5OY2RNT3UOFZDo4oy8u6E= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SN7PR12MB6929.namprd12.prod.outlook.com (2603:10b6:806:263::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.43; Mon, 9 Oct 2023 09:17:31 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6863.032; Mon, 9 Oct 2023 09:17:31 +0000 Message-ID: <320b9f43-734a-4946-9f5d-4d021e1ff416@amd.com> Date: Mon, 9 Oct 2023 10:17:26 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] net/tap: resolve stringop-overflow with gcc 12 on ppc64le Content-Language: en-US To: David Christensen , Stephen Hemminger Cc: dev@dpdk.org, stable@dpdk.org References: <20230322212439.524725-1-drc@linux.vnet.ibm.com> <20230323170145.129901-1-drc@linux.vnet.ibm.com> <165a233b-b41b-3a65-1866-5b7c94993b40@amd.com> <20230515162032.36a4f3ec@hermes.local> <20230515182838.08e49a7c@hermes.local> <44fb2571-8f96-570d-cb35-210fa5f52d9f@amd.com> <0eccde0d-6fdd-4351-87c5-930b22ac2d0d@amd.com> <76a65428-5c3b-0a26-a8c5-cc66799e9375@linux.vnet.ibm.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <76a65428-5c3b-0a26-a8c5-cc66799e9375@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LNXP265CA0051.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5d::15) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SN7PR12MB6929:EE_ X-MS-Office365-Filtering-Correlation-Id: f1857e01-c2b8-4132-9732-08dbc8a890bb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NtCRV6d2cZ/uGgSjlyDTJ8+vhIRYkd90p1U7SdOU5k7Any5mmQcOKO76FZrWGXhuCGWGDc/y+Yx3x3IG1u70cin0s5CUP0Aq/r7PcCYwzQ1NGsbK1wcuBWcZ3xfopYhSzDBRo5XJ8mfbCzRph3DyzQ9YSgK1g68ToN2E46ABc5VUxPzY9ZBTkX+QMvvUAZBOutFj84K7VJtgxv+jIiRAQquBNnOzilJiin4KFl1l4iy+8uQBlQus1c73OYsDJeS5OjZKyT7YC0MKw9n/ExPWN7eC/2ZVq7irDTFQi4ZQyLFID08cAD5D6PLFzNECJfa/RlGB/l4PR9HM0DBOTOXUlg/Xcd3xjvKvUySv9r36gG2YcJUQOW0lujazttl/NgenRLCLJ/Xdn14x80+lWDQVtyqDN0PYzbIshQKEa0IaX1jgvAt1Sw1PpS0Q9Ho+nW2BvTmSS967bsR8+pou+Kvw8+2HJYVorp6t1ddeX4oazXmdMZHQaFeJZQ1Q9tTjKbNiiXpTg5zLqvy4COf8FFT47pFUAuoMZH46+upy9MYhBaigYFDiWD1b0CJJiERIUytSHjtfNeGDmk1gZrH9YoLJCGe8sWTrkSNaB8wVKY3gQocO2kyDJiEOIWTqFJu4PWfWMimlFSvrsYpt2a2kVTfTUQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(39860400002)(136003)(376002)(366004)(396003)(230922051799003)(64100799003)(186009)(451199024)(1800799009)(31686004)(2616005)(26005)(53546011)(36756003)(31696002)(86362001)(38100700002)(83380400001)(4326008)(2906002)(478600001)(6666004)(6506007)(6512007)(8676002)(8936002)(44832011)(6486002)(966005)(5660300002)(41300700001)(316002)(110136005)(66946007)(66556008)(66476007)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WFc3M2xIYmRhdS9HZFBJV1ZYUE43NGVZTUNhRnBhYW14VCtLbGtrZjQ2VW5S?= =?utf-8?B?ZGZmaWZaK3pvSCt0NjA2V2FnV0JqNnJDbVdTeFRNSHRrYTV3LzR3aEdJdGl1?= =?utf-8?B?bHhnSTQ0dDArNzBsN2pkbzF1bTU2TnRTd0NSbVZKcVAvR1FpeVROVVhlemxZ?= =?utf-8?B?ZTZYUWlhZ0ZZbmlTQmVsWjYrQW9RbDE5NXZ3czVOUDBra0owZWFmOTJEbllq?= =?utf-8?B?enV4ditrcXVnenZOZGd3aFlQWm9NdzRFSkZDYzJOTFBYRkJ2bldaSm1jbUoz?= =?utf-8?B?TEtiNlhtdjByWlBNb1lBZ3cvS1dBYmJScC9nYVQvUDRsT0JzM2tjaFFrQ01S?= =?utf-8?B?L2lkNUJ2dXNnTWt0VGk3M0ZYMEQ5R3NNMk4rZGdBNFhYMHRPMTVmOWVGUXNk?= =?utf-8?B?Qk9PS3RjVi9UdTZrZVJTRUN6bklMbXF5TjlOVjRuVm9ENjA2RFIvSFFKaXQz?= =?utf-8?B?V01JZEFobWFvdWRGbUJ2OUJWSmxIbFd4cmNqZUVjNVBldVBwQ1pkQ0FGKzdt?= =?utf-8?B?dng5M3Fjdm5yc2NIV0xTditDR1JSNGVMZmVBd3FyYTdpcnhLL3oxQXlIdVdS?= =?utf-8?B?N0wwcUlIdHhIdzVpU2Q2VUJ5dDlSVkpLdVVpWlE3YklNRWFKQm84cGRvVlBU?= =?utf-8?B?T3JnVGlHT2h4OWFnUy9HUml6aUFQaFllT1Fsd2FRczkyaENNT0IrYWNUWDlH?= =?utf-8?B?YUw2dzg2bGxaYW5rTEtUbTZnbU9WdHpCcWpJNXJaSWcxRjdmK3F4SGFKbWcv?= =?utf-8?B?ak4rbEt3RklRUEFVTGI5d0tzbDBVLzFlbHNYdklMdENWV0NzNU41ZjlHb1Mw?= =?utf-8?B?ZlVxcFJhR0tmdGM2QUNRc1dzQ1FmYUxzNVlpWG1DbWlHb1FOMGc1MFRuQVU2?= =?utf-8?B?ekJHRFVEcVpvQUM0WWZpdG85NkdRa2tueXlhbTNLa1NZcVRZTVpwVytMaUYv?= =?utf-8?B?a3grbnZybHlnWWNnSnczUVlRRHkxT0Y0a0s1TGdMYlJlTXlXdFNBcEkyb1Q2?= =?utf-8?B?bkh6U0UrR01ONDBoaEpxN3NBanQyb2VyREVLRHNWWkR1RkRsbkdJK0ZnQzRP?= =?utf-8?B?Z09pYXNkUVdyekF2YWpCRmwxem5LUGxjSU1iNCtWcDZDd2gzNlVGSk5SU21C?= =?utf-8?B?WXhUL0RnYTlvWCtuVWZxeEtwWXlpUFQvWTYrWG9HaVhOY1loTDlRRkpMVTRo?= =?utf-8?B?S25RbXFxU1FlUW9kM3RPdkN1bnN2UEwyNFdTUE13YUJnaHh5S3VGTmFpTDZo?= =?utf-8?B?NUVMUDdETnFuS0t1bXI2aEJPODUrTDlMeDBQZDVOanNzTjRVWUxPVE4rOVVW?= =?utf-8?B?cVNGSVp5Wlc4UmFoSllMR2JkdUJHanFMWjlYMUJaUWxDNyt2T3hZSjFUcnRO?= =?utf-8?B?RWN6Q1hPSzZKOG5seW5HdmtvaW9TTjU0YjJBWlV1blRkeVluMStTd0w0U01x?= =?utf-8?B?L2taTWZSOFdwN0YxTUNXbWgwcmN3c2d0Z3ZkYzRNRUt6ZWhFSGNrMnpQTHkw?= =?utf-8?B?RGdUOTNCVEFwbUZ4MmlDZjEzeTNNcng3d2VBWmZ1d1ZnTWtQUUt4clBtZ05L?= =?utf-8?B?d3VPZm5lV1JTVGZxZ05GbVVkQjlCZG96Z3ZBUWM3TUM2RjMyN1pWMXlPMFpx?= =?utf-8?B?YUJNVHNUaWptaDN6dzEvRTRZVGRCSEVZSHZyd2hjY1lSV3VPRmxrNjFsRjB6?= =?utf-8?B?K0hmTFIwYlpEd0pmMWp6b3UzWG9SZzFrVVM4SUtHSkZHMU40SGpFcUFqYURl?= =?utf-8?B?eHNxdnNsa0YydDFheDVySHZON1F0ZlBpR3R3K1VRR3hLMnFKZEoyc2tZbUky?= =?utf-8?B?cnFnOXByWFNMVVc0SDlSVUtRMmxML0x6d1hvZENnL1NqTWtuSU0vRFQzUy9p?= =?utf-8?B?RHpXdW5EK2dUWXFPZFF0dGtnd0dNNDFmeUpnQ3NoamY2cXJZOVp4aTYyNnY4?= =?utf-8?B?MFJYSmVqQWZzR3N1dFNDOGJMZ1lOTlh1aytmQ09Ldkt0S0M4dUNzTkFGWC9G?= =?utf-8?B?aHpSNklScHVRN3RWZmFYbW50TCsvUHR0WkxUZGtrTnVYZnJmVDlqN3BDRUJX?= =?utf-8?B?NThBaG9Ca1V6S24rZ2hPQ2xrWWEvd0hOaVFlU25hV1JTSGZhZU5NdllUanRl?= =?utf-8?Q?U5dmDwpfuTw1+VRxqzluNqCnu?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f1857e01-c2b8-4132-9732-08dbc8a890bb X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2023 09:17:31.3301 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8l0qtxjPt/jPqda9XXsZKTLn3EzIx1/Wigx2QcQmj8blTShmzAEdgBPBPk+FRbj7 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6929 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 10/6/2023 7:31 PM, David Christensen wrote: > > > On 9/29/23 6:48 AM, Ferruh Yigit wrote: >> On 6/7/2023 7:47 PM, Ferruh Yigit wrote: >>> On 5/16/2023 10:55 AM, Ferruh Yigit wrote: >>>> On 5/16/2023 2:28 AM, Stephen Hemminger wrote: >>>>> On Tue, 16 May 2023 00:35:56 +0100 >>>>> Ferruh Yigit wrote: >>>>> >>>>>> Yes only some scripts and possible applications that hotplug tap >>>>>> interface with hardcoded parameters may impacted, don't know how >>>>>> big is >>>>>> this amount but this ends up breaking something that was working >>>>>> before >>>>>> upgrading DPDK for them. >>>>>> >>>>>> And I believe the motivation is weak to break the behavior. >>>>>> >>>>>> Won't it be better to update 'rte_ether_unformat_addr()' to accept >>>>>> more >>>>>> flexible syntax, and use it? Is there any disadvantage of this >>>>>> approach? >>>>> >>>>> It is already more flexible than the standard ether_aton(). >>>> >>>> I mean to accept single chars, as 'tap' currently does, like >>>> "a:a:a:a:a:a". >>>> >>>> Agree that impact of tap change is small, but if we can eliminate it >>>> completely without any side affect, why not? >>>> >>>> >>>> As accepting single char will be expanding 'rte_ether_unformat_addr()' >>>> capability, it will be backward compatible, am I missing anything? >>>> >>> >>> Hi David, >>> >>> If API update is not planned, what do you think to just solve the build >>> error without changing functionality with a change something like below: >>> >>> ``` >>>   -       (strlen(mac_byte) == strspn(mac_byte, >>>   -                       ETH_TAP_CMP_MAC_FMT))) { >>>   +       (strlen(mac_byte) == strspn(mac_byte, ETH_TAP_CMP_MAC_FMT)) && >>>   +                       index < RTE_ETHER_ADDR_LEN) { >>> >>> ``` >> >> Hi David, >> >> If you can confirm above fixes the issue, I can send a patch for it. > > Confirmed that your proposed change resolves the build issue on ppc64le. >  Appreciate if you can submit the patch. > > Thanks for checking, but Stephen updated the 'rte_ether_unformat_addr()' API [1] and sent a new version of this patch [2], which is merged in next-net [3] now. Build error for PPC should be fixed now. [1] https://patchwork.dpdk.org/project/dpdk/patch/20231003202909.391330-3-stephen@networkplumber.org/ [2] https://patchwork.dpdk.org/project/dpdk/patch/20231003202909.391330-5-stephen@networkplumber.org/ [3] https://git.dpdk.org/next/dpdk-next-net/log/