* Re: [dpdk-stable] [PATCH v2] cfgfile: update map file
2019-12-17 11:52 ` [dpdk-stable] [PATCH v2] cfgfile: update map file lironh
@ 2019-12-17 11:12 ` Dumitrescu, Cristian
2020-01-19 23:31 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Dumitrescu, Cristian @ 2019-12-17 11:12 UTC (permalink / raw)
To: lironh, dev; +Cc: stable
> -----Original Message-----
> From: lironh@marvell.com <lironh@marvell.com>
> Sent: Tuesday, December 17, 2019 11:52 AM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; stable@dpdk.org;
> Liron Himi <lironh@marvell.com>
> Subject: [PATCH v2] cfgfile: update map file
>
> From: Liron Himi <lironh@marvell.com>
>
> rte_cfgfile_section_num_entries_by_index was missing from the map
> file.
> meson build failed when calling this function, due to linking a binary to cfgfile
> built
> as a shared library
>
> Fixes: 85ff364f3b ("build: align symbols with global ABI version")
>
> Signed-off-by: Liron Himi <lironh@marvell.com>
> ---
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [dpdk-stable] [PATCH v2] cfgfile: update map file
[not found] <20191217104347.21955-1-lironh@marvell.com>
@ 2019-12-17 11:52 ` lironh
2019-12-17 11:12 ` Dumitrescu, Cristian
0 siblings, 1 reply; 3+ messages in thread
From: lironh @ 2019-12-17 11:52 UTC (permalink / raw)
To: dev; +Cc: cristian.dumitrescu, stable, Liron Himi
From: Liron Himi <lironh@marvell.com>
rte_cfgfile_section_num_entries_by_index was missing from the map
file.
meson build failed when calling this function, due to linking a binary to cfgfile built
as a shared library
Fixes: 85ff364f3b ("build: align symbols with global ABI version")
Signed-off-by: Liron Himi <lironh@marvell.com>
---
v2:
- update commit msg.
- add 'Fixes'
- follow alphabetical order
lib/librte_cfgfile/rte_cfgfile_version.map | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_cfgfile/rte_cfgfile_version.map b/lib/librte_cfgfile/rte_cfgfile_version.map
index 906eee96b..22c999fe1 100644
--- a/lib/librte_cfgfile/rte_cfgfile_version.map
+++ b/lib/librte_cfgfile/rte_cfgfile_version.map
@@ -15,6 +15,7 @@ DPDK_20.0 {
rte_cfgfile_section_entries;
rte_cfgfile_section_entries_by_index;
rte_cfgfile_section_num_entries;
+ rte_cfgfile_section_num_entries_by_index;
rte_cfgfile_sections;
rte_cfgfile_set_entry;
--
2.23.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] cfgfile: update map file
2019-12-17 11:12 ` Dumitrescu, Cristian
@ 2020-01-19 23:31 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2020-01-19 23:31 UTC (permalink / raw)
To: lironh; +Cc: dev, stable, Dumitrescu, Cristian, david.marchand
17/12/2019 12:12, Dumitrescu, Cristian:
>
> > -----Original Message-----
> > From: lironh@marvell.com <lironh@marvell.com>
> > Sent: Tuesday, December 17, 2019 11:52 AM
> > To: dev@dpdk.org
> > Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; stable@dpdk.org;
> > Liron Himi <lironh@marvell.com>
> > Subject: [PATCH v2] cfgfile: update map file
> >
> > From: Liron Himi <lironh@marvell.com>
> >
> > rte_cfgfile_section_num_entries_by_index was missing from the map
> > file.
> > meson build failed when calling this function, due to linking a binary to cfgfile
> > built
> > as a shared library
> >
> > Fixes: 85ff364f3b ("build: align symbols with global ABI version")
> >
> > Signed-off-by: Liron Himi <lironh@marvell.com>
>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Fixing the "Fixes" line with the real root cause:
Fixes: 3d2e0448ebb5 ("cfgfile: add section number of entries by index")
Cc: stable@dpdk.org
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-19 23:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20191217104347.21955-1-lironh@marvell.com>
2019-12-17 11:52 ` [dpdk-stable] [PATCH v2] cfgfile: update map file lironh
2019-12-17 11:12 ` Dumitrescu, Cristian
2020-01-19 23:31 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).