* [dpdk-stable] [PATCH 1/1] doc: remove Linux headers from requirements
@ 2020-11-26 16:08 Thomas Monjalon
2020-11-26 16:21 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2020-11-26 16:08 UTC (permalink / raw)
To: dev; +Cc: david.marchand, bruce.richardson, stable, Jerin Jacob
The compilation of the kernel module KNI is optional.
The kernel headers should be required for DPDK compilation.
Fixes: 91a861e54164 ("config: disable Linux kernel modules by default")
Cc: stable@dpdk.org
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
doc/guides/linux_gsg/sys_reqs.rst | 2 --
1 file changed, 2 deletions(-)
diff --git a/doc/guides/linux_gsg/sys_reqs.rst b/doc/guides/linux_gsg/sys_reqs.rst
index ab38284950..87f7c9aa8c 100644
--- a/doc/guides/linux_gsg/sys_reqs.rst
+++ b/doc/guides/linux_gsg/sys_reqs.rst
@@ -58,8 +58,6 @@ Compilation of the DPDK
* ``libnuma-dev`` in Debian/Ubuntu;
-* Linux kernel headers or sources required to build kernel modules.
-
.. note::
Please ensure that the latest patches are applied to third party libraries
--
2.28.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-stable] [PATCH 1/1] doc: remove Linux headers from requirements
2020-11-26 16:08 [dpdk-stable] [PATCH 1/1] doc: remove Linux headers from requirements Thomas Monjalon
@ 2020-11-26 16:21 ` Bruce Richardson
2020-11-27 0:56 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2020-11-26 16:21 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, david.marchand, stable, Jerin Jacob
On Thu, Nov 26, 2020 at 05:08:37PM +0100, Thomas Monjalon wrote:
> The compilation of the kernel module KNI is optional.
> The kernel headers should be required for DPDK compilation.
>
> Fixes: 91a861e54164 ("config: disable Linux kernel modules by default")
> Cc: stable@dpdk.org
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
If someone does want to build kni, we actually have a check in meson.build
for kernel build headers, giving a suitable error if they are missed.
Therefore I think this can go.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH 1/1] doc: remove Linux headers from requirements
2020-11-26 16:21 ` Bruce Richardson
@ 2020-11-27 0:56 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2020-11-27 0:56 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, david.marchand, stable, Jerin Jacob
26/11/2020 17:21, Bruce Richardson:
> On Thu, Nov 26, 2020 at 05:08:37PM +0100, Thomas Monjalon wrote:
> > The compilation of the kernel module KNI is optional.
> > The kernel headers should be required for DPDK compilation.
not, should not :)
> > Fixes: 91a861e54164 ("config: disable Linux kernel modules by default")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> If someone does want to build kni, we actually have a check in meson.build
> for kernel build headers, giving a suitable error if they are missed.
> Therefore I think this can go.
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied with fixed typo.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-27 0:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-26 16:08 [dpdk-stable] [PATCH 1/1] doc: remove Linux headers from requirements Thomas Monjalon
2020-11-26 16:21 ` Bruce Richardson
2020-11-27 0:56 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).