From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5BBF141DE5 for ; Mon, 6 Mar 2023 11:55:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 33F3240E50; Mon, 6 Mar 2023 11:55:57 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id C67DA40A8A for ; Mon, 6 Mar 2023 11:55:55 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 98BC05C0190; Mon, 6 Mar 2023 05:55:52 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 06 Mar 2023 05:55:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1678100152; x=1678186552; bh=XrXCEuah/ogIlYT9Xblqj9MYZK+m0bGmdMe YDkkJU+Q=; b=gXU/s8cTj0Oe/dOF1hSM9Z+0EnkCJWR4Bf5FlckuF969JFocI89 DkoLASz2ZD7KR9lovMq7MciSdRqOYPkEk7NI3O7lvNnjf0RRLePYac8VEnNTsOI0 CUXYrfY+/ThksD53gdbMiI/u5zrQKGKQH8YxMtPrwWXsC+G7Aq4a+hVb5Rexxps6 xlcQsOIQdMgNIhdhj4Z0KDMWRj/ax/rXSPi6phclQY+jmO2m10CEWKstjw4l//Bu ojCqOiLYy6Vkz+6WB8nE3tycRaYUw8Fo1zea08gs+WfweAPXO7gpf6aP2lkdSf1u ++v9nt3i4rDiyxcSHj/9XOr96TxzsM/sl6w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1678100152; x=1678186552; bh=XrXCEuah/ogIlYT9Xblqj9MYZK+m0bGmdMe YDkkJU+Q=; b=CgEbKTGPNCxx58v0c1YDrFOhJPBMMKHqkKBOXRig4vsfi72nGUY ZEB2irapcE5DsCt81/EuW3j1xJdCFWLjp5JP1BDff52jodo7ZYpYHW+VDolop/hv jXx4S2Hk1naPX7xwnoo95DfBtTIFUm0em0CNY7skUys+VFH8AruSDT12ZHgIWUM6 d2DFwtha6QVKfo06lA1ynXB/mEgzPm6rhHti0zW6G8OBodVoF1L4w1JFp8liI7iC RKhEoC7CiT5ZORJNTYQJOXcfmQYsoWIzaewuk1YHNNZUGnADJ1x15iySFj7igu/z 9xuwHN8W2OfusKpor8tJOXK6AHGIKTornTg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddtiedgvdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 6 Mar 2023 05:55:51 -0500 (EST) From: Thomas Monjalon To: matan@nvidia.com, viacheslavo@nvidia.com, orika@nvidia.com, Suanming Mou , Rongwei Liu Cc: stable@dpdk.org, rasland@nvidia.com Subject: Re: [PATCH 22.11] net/mlx5: fix testpmd crash by action template Date: Mon, 06 Mar 2023 11:55:49 +0100 Message-ID: <32273080.6xKfjbll68@thomas> In-Reply-To: <20230306091526.2210924-1-rongweil@nvidia.com> References: <20230306091526.2210924-1-rongweil@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org This patch is not specific to testpmd. We should drop "testpmd" from the title. Something like "fix crash on flow action template failure" 06/03/2023 10:15, Rongwei Liu: > When action template creation fails the testpmd expects error > details. > The driver did not set the error structure and testpmd failed with a > segmentation fault. > > Fixes: 836b5c9b5e0e ("net/mlx5: add action template management") > Cc: stable@dpdk.org > Signed-off-by: Rongwei Liu > Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_flow_hw.c | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c > index b4a80f977f..9e5f263ccf 100644 > --- a/drivers/net/mlx5/mlx5_flow_hw.c > +++ b/drivers/net/mlx5/mlx5_flow_hw.c > @@ -4946,6 +4950,9 @@ flow_hw_actions_template_create(struct rte_eth_dev *dev, > mlx5dr_action_template_destroy(at->tmpl); > mlx5_free(at); > } > + rte_flow_error_set(error, rte_errno, > + RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, > + "Failed to create action template"); > return NULL; > } >