patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Jiawei Wang <jiaweiw@nvidia.com>,
	viacheslavo@nvidia.com, matan@nvidia.com, orika@nvidia.com,
	Yongseok Koh <yskoh@mellanox.com>, Ori Kam <orika@mellanox.com>
Cc: stable@dpdk.org, rasland@nvidia.com
Subject: Re: [PATCH 21.11] net/mlx5: fix NIC egress flow mismatch in switchdev mode
Date: Wed, 16 Mar 2022 15:18:52 +0000	[thread overview]
Message-ID: <327ccb72-cd5d-3bb0-cfcf-6bf7751c0b91@redhat.com> (raw)
In-Reply-To: <20220312075812.10804-1-jiaweiw@nvidia.com>

On 12/03/2022 07:58, Jiawei Wang wrote:
> [ upstream commit 6d4f1066be6cd60a95f21ef07a16a3c3676c5cd9 ]
> 
> When E-Switch mode was enabled, the NIC egress flows was implicitly
> appended with source vport to match on. If the metadata register C0
> was used to maintain the source vport, it was initialized to zero
> on packet steering engine entry, the flow could be hit only
> if source vport was zero, the register C0 of the packet was not correct
> to match in the TX side, this caused egress flow misses.
> 
> This patch:
>   - removes the implicit source vport match for NIC egress flow.
>   - rejects the NIC egress flows on the representor ports at validation.
>   - allows the internal NIC egress flows containing the TX_QUEUE items in
>     order to not impact hairpins.
> 
> Fixes: ce777b147bf8 ("net/mlx5: fix E-Switch flow without port item")
> 
> Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> Acked-by: Ori Kam <orika@nvidia.com>
> ---

Thanks Jiawei. I have queued this [0] and will push to dpdk.org with the 
next batch of backports on Monday.

[0] 
https://github.com/kevintraynor/dpdk-stable/commit/82361afbedc11452986c141f97baa8867839b0c4


      reply	other threads:[~2022-03-16 15:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-12  7:58 Jiawei Wang
2022-03-16 15:18 ` Kevin Traynor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=327ccb72-cd5d-3bb0-cfcf-6bf7751c0b91@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=jiaweiw@nvidia.com \
    --cc=matan@nvidia.com \
    --cc=orika@mellanox.com \
    --cc=orika@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@nvidia.com \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).