From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9AB89A0032 for ; Wed, 16 Mar 2022 16:19:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 700A640395; Wed, 16 Mar 2022 16:19:01 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id DEECA40395 for ; Wed, 16 Mar 2022 16:18:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647443939; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TbEM47P59bYm43mhFvhTSqosUEj7hDKz3zKVOCW4+h0=; b=PElKnMHKvhCkBdGmw7CDjONkmaSi+Hzxzwa/djUtf2vTmGIh/RIp/02PMcHkORz2bkzIM7 fg4u+g5P8swlBRtF/rPRx9mHdmsAjYbt9Aafh94eOj+sBZk5ULsVjRWTaVQ8brfOrR4i41 OwNWJ93zdaUepwW9mCzsCw5ePlXBU4Q= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-168-UiVcKHZOM7KrJgZLH3SLZw-1; Wed, 16 Mar 2022 11:18:56 -0400 X-MC-Unique: UiVcKHZOM7KrJgZLH3SLZw-1 Received: by mail-wm1-f70.google.com with SMTP id h127-20020a1c2185000000b0038c6f7e22a4so908874wmh.9 for ; Wed, 16 Mar 2022 08:18:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to :content-transfer-encoding; bh=TbEM47P59bYm43mhFvhTSqosUEj7hDKz3zKVOCW4+h0=; b=19b0XDaxf7KwqyMJ6GqAjUQjAk7g5mFO/u5bP5BaWlfIfBdn3a6kFLSAXzeejfAdDd dBaTZOchqdvlvRRb2ymSJlm1x2Brpz5jfGV8V1MPU+5ADK4atJ/SB00oOZuIOBMFKfMf 8QpZ9b94XRGw2w1Gad8+WSC/ITFAMit3ftFMGglE1QbsdzkEpA9q4ZTHbRfsdCYkkWu6 uFrF8UA6cjx+W58ngpgxKLKXDTGGGOLaUgV8iLTrDKNWLaP4fKO2lo4rOK2T/VHRYkYq VZ3WAz/nYF4s2L9ozw35/3wAa3SPYj3r0zoz92hsUY6T/TuGGzfSEL8OGPJLEyUCe7VP U7IQ== X-Gm-Message-State: AOAM530rdNd11pTvCJ1Aa1rf2fyzcvy7EF6MuQJOiRuIT2VFDufGJhTd 4+8Cio93sWbwgAUY7J3XsO2sPg6BgzH/M33NsAJwROdjo5MODnUsDyhrn3yZ2ota4LF0wL3qO90 nlamp0e4= X-Received: by 2002:a1c:4c13:0:b0:389:a4ab:df7c with SMTP id z19-20020a1c4c13000000b00389a4abdf7cmr175793wmf.14.1647443934570; Wed, 16 Mar 2022 08:18:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy7cGa2cl7ntY3AfLvjzeh8ETdTZkLcdbfx6nsIWlM6vT3K9+4xFhCS9K9AsVZU/Fw2vM+r2Q== X-Received: by 2002:a1c:4c13:0:b0:389:a4ab:df7c with SMTP id z19-20020a1c4c13000000b00389a4abdf7cmr175772wmf.14.1647443934390; Wed, 16 Mar 2022 08:18:54 -0700 (PDT) Received: from [192.168.0.36] ([78.17.178.139]) by smtp.gmail.com with ESMTPSA id h15-20020a05600c350f00b00389e7897190sm5090116wmq.3.2022.03.16.08.18.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Mar 2022 08:18:53 -0700 (PDT) Message-ID: <327ccb72-cd5d-3bb0-cfcf-6bf7751c0b91@redhat.com> Date: Wed, 16 Mar 2022 15:18:52 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 To: Jiawei Wang , viacheslavo@nvidia.com, matan@nvidia.com, orika@nvidia.com, Yongseok Koh , Ori Kam Cc: stable@dpdk.org, rasland@nvidia.com References: <20220312075812.10804-1-jiaweiw@nvidia.com> From: Kevin Traynor Subject: Re: [PATCH 21.11] net/mlx5: fix NIC egress flow mismatch in switchdev mode In-Reply-To: <20220312075812.10804-1-jiaweiw@nvidia.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 12/03/2022 07:58, Jiawei Wang wrote: > [ upstream commit 6d4f1066be6cd60a95f21ef07a16a3c3676c5cd9 ] > > When E-Switch mode was enabled, the NIC egress flows was implicitly > appended with source vport to match on. If the metadata register C0 > was used to maintain the source vport, it was initialized to zero > on packet steering engine entry, the flow could be hit only > if source vport was zero, the register C0 of the packet was not correct > to match in the TX side, this caused egress flow misses. > > This patch: > - removes the implicit source vport match for NIC egress flow. > - rejects the NIC egress flows on the representor ports at validation. > - allows the internal NIC egress flows containing the TX_QUEUE items in > order to not impact hairpins. > > Fixes: ce777b147bf8 ("net/mlx5: fix E-Switch flow without port item") > > Signed-off-by: Jiawei Wang > Acked-by: Viacheslav Ovsiienko > Acked-by: Ori Kam > --- Thanks Jiawei. I have queued this [0] and will push to dpdk.org with the next batch of backports on Monday. [0] https://github.com/kevintraynor/dpdk-stable/commit/82361afbedc11452986c141f97baa8867839b0c4