From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85EA245695 for ; Tue, 23 Jul 2024 17:25:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7935742EB1; Tue, 23 Jul 2024 17:25:11 +0200 (CEST) Received: from fout2-smtp.messagingengine.com (fout2-smtp.messagingengine.com [103.168.172.145]) by mails.dpdk.org (Postfix) with ESMTP id C990542E4A; Tue, 23 Jul 2024 17:25:06 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailfout.nyi.internal (Postfix) with ESMTP id 48DF21380057; Tue, 23 Jul 2024 11:25:06 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Tue, 23 Jul 2024 11:25:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1721748306; x=1721834706; bh=hgQkmv5xASM94OV1Jkp6nBmq0OqV2KBLECL/eSgBhF0=; b= aIgyj67cScYhbqh9FsEFkwyyG1IrTdqTpKqThgkikMeWO6TTdjb9MudrF3wOu+B6 scOHZfRse8BGhF4xOrssYGatiCPrLa8NArjBWe+Z5GzTVoTfhJ7sCZKjdYSMSHEX P1EJdFJFpXNg4Z1xpbJIfYFu0sVpqCEYuLy7BzXXBU0bZAU3lxD++iMoYjPxRTil dE8wylJmJSTEs/KHrxypPTHJya3FsIouxvvtYEu8s09S+luVBjYc+Sp2jWxFoLjJ eUotyCO8+/6RRm+Hu1s2fN5seD99mwxxD6QMAJDEfEPMs0V/eUuA+A8mWdzdraJO 1Y4UgSzlBteiJxM030qb8g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1721748306; x= 1721834706; bh=hgQkmv5xASM94OV1Jkp6nBmq0OqV2KBLECL/eSgBhF0=; b=m EAPBiH8JFHqUXqSHaAplDrRul6htxzJ7ACECb125EcV+PyTc5Sz27wlv72rlON4/ j8w483gvRQIZzQnm1LHZ2sbCO2pCtyJFf3ME9Dy7wq1SIsLq1MBPWg+tI5SqpKnk CiR8XMFHWS1EyOX/ZSQwyx2eKPLkaOE3oABacOWq02AmSbDdD14DgmVRVmRyY6Pf cKbGer1Yi+rIwK2BtQq0Kk6mrzuZijk7/Yd0HXKu7ZGasA4npDs5aL0wa2i+5pJL yBfycdWVLD9rmDnmaVwNxvON273ATAh0WKW0MgUubID8QXnoom+nQGE7ogS/sxcO 12MzPtW/ZswX5IL+7oUoA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrheelgdekkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdegkeeuveejffejgedtgeegkefg vdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthdpnhgspghrtghpthhtoheptd X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 23 Jul 2024 11:25:05 -0400 (EDT) From: Thomas Monjalon To: Mingjin Ye Cc: stable@dpdk.org, "Burakov, Anatoly" , dev@dpdk.org Subject: Re: [PATCH v2] net/vdev: fix insert vdev core dump Date: Tue, 23 Jul 2024 17:25:03 +0200 Message-ID: <3307195.44csPzL39Z@thomas> In-Reply-To: <79ce202e-38da-4da4-8754-726d8a12f976@intel.com> References: <20240314093630.1066948-4-mingjinx.ye@intel.com> <20240716095328.1820597-1-mingjinx.ye@intel.com> <79ce202e-38da-4da4-8754-726d8a12f976@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org 22/07/2024 14:39, Burakov, Anatoly: > On 7/16/2024 11:53 AM, Mingjin Ye wrote: > > In secondary processes, insert_vdev() may be called multiple times on the > > same device due to multi-process hot-plugging of the vdev bus and EAL > > parameters to add the same vdev. > > > > In this case, when rte_devargs_insert() is called, the devargs->name > > reference will be invalidated because rte_devargs_insert() destroys the > > just-allocated devargs and replaces the pointer from the devargs list. > > As a result, the reference to devargs->name stored in dev->device.name > > will be invalid. > > > > This patch fixes the issue by setting the device name after calling > > rte_devargs_insert(). > > > > Fixes: cdb068f031c6 ("bus/vdev: scan by multi-process channel") > > Cc: stable@dpdk.org > > > > Signed-off-by: Mingjin Ye > > --- > > v2: Modify commit log. > > --- > > Forgot to add my review tag: > > Reviewed-by: Anatoly Burakov Applied, thanks.