From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D14EA034C for ; Sun, 6 Nov 2022 10:37:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F32442B7E; Sun, 6 Nov 2022 10:37:28 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 9B04B4003C; Sun, 6 Nov 2022 10:37:26 +0100 (CET) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 18F4462; Sun, 6 Nov 2022 12:37:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 18F4462 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1667727446; bh=HcWnt5WnsWO9SBAN/9vw9guod2slngM8bNDwL3qJvDY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=pXzPsFlnk6enrSsRdwaaF1FTM/ZpuACz+Af8iAYbBEaCfSZSrheEe1islfCayeJs9 sX/bdxu/p1WDdC4UN8m8YzMjijKE/skeVi+6WRw0bVfQDtrJlneL8sl8EEJ6hvtfeV baHT80Ws3z1FZWSE45MSn/NPLJS1EE55WgU8/HM8= Message-ID: <333f3ca1-9c46-1e77-c29f-d15eb087027c@oktetlabs.ru> Date: Sun, 6 Nov 2022 12:37:25 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH] net/bonding: fix device configure reentrancy Content-Language: en-US To: "Yuan, DukaiX" , Ivan Malov , "dev@dpdk.org" Cc: "Jiang, YuX" , Chas Williams , "Min Hu (Connor)" , "Burakov, Anatoly" , "stable@dpdk.org" References: <20221101161853.2702425-1-ivan.malov@oktetlabs.ru> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 11/2/22 06:35, Yuan, DukaiX wrote: > -----Original Message----- > From: Ivan Malov > Sent: 2022年11月2日 0:19 > To: dev@dpdk.org > Cc: Jiang, YuX ; Chas Williams ; Min Hu (Connor) ; Burakov, Anatoly ; stable@dpdk.org; Andrew Rybchenko > Subject: [PATCH] net/bonding: fix device configure reentrancy > > As per report [1], the previous patch for device configure code apparently overlooks the corner case of manually adding back-end devices to the bond using testpmd CLI. The problem is in removing back-end ports on re-configure instead of just stopping them. Fix that. > > Fixes: 339f1ba51353 ("net/bonding: make configure method re-entrant") > Cc: stable@dpdk.org > > [1] https://bugs.dpdk.org/show_bug.cgi?id=1119 > > Signed-off-by: Ivan Malov > --- > Tested-by: Dukai Yuan Reviewed-by: Andrew Rybchenko Applied to dpdk-next-net/main with minor fix suggested by Stephen, thanks.