Re: [PATCH v4 3/3] net/ixgbe: Fix SFP detection and linking on hotplug

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 2/25/2022 8:50 PM, Jeff Daly wrote:
> Currently the ixgbe driver does not ID any SFP except for the first one
> plugged in. This can lead to no-link, or incorrect speed conditions.
> 
> For example:
> 
> * If link is initially established with a 1G SFP, and later a 1G/10G
> multispeed part is later installed, then the MAC link setup functions are
> never called to change from 1000BASE-X to 10GBASE-R mode, and the link
> stays running at the slower rate.
> 
> * If link is initially established with a 1G SFP, and later a 10G only
> module is later installed, no link is established, since we are still
> trasnsmitting in 1000BASE-X mode to a 10GBASE-R only partner.
> 
> Refactor the SFP ID/setup, and link setup code, to more closely match the
> flow of the mainline kernel driver which does not have these issues.  In
> that driver a service task runs periodically to handle these operations
> based on bit flags that have been set (usually via interrupt or userspace
> request), and then get cleared once the requested subtask has been
> completed.
> 
> Fixes: af75078fece ("first public release")
> Cc:stable@dpdk.org
> 
> Signed-off-by: Stephen Douthit<stephend@silicom-usa.com>
> Signed-off-by: Jeff Daly<jeffd@silicom-usa.com>

Hi Jeff,

Can you please send new version of whole set, instead of only
one of the patches?
It is very hard to manage different versions of individual
patches in a set.