From: fengchengwen <fengchengwen@huawei.com>
To: David Marchand <david.marchand@redhat.com>, <dev@dpdk.org>
Cc: <thomas@monjalon.net>, <stephen@networkplumber.org>,
<luca.boccassi@gmail.com>, <stable@dpdk.org>,
Luca Boccassi <bluca@debian.org>,
Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: Re: [PATCH v3] eal/unix: optimize thread creation with glibc
Date: Mon, 4 Nov 2024 08:19:47 +0800 [thread overview]
Message-ID: <338eb7c7-e746-4a52-a318-be275e70e258@huawei.com> (raw)
In-Reply-To: <20241103112519.2972691-1-david.marchand@redhat.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
On 2024/11/3 19:25, David Marchand wrote:
> Setting the cpu affinity of the child thread from the parent thread is
> racy when using pthread_setaffinity_np, as the child thread may start
> running and initialize before affinity is set.
>
> On the other hand, setting the cpu affinity from the child thread itself
> may fail, so the parent thread waits for the child thread to report
> whether this call succeeded.
>
> This synchronisation point resulted in a significant slow down of
> rte_thread_create() (as seen in the lcores_autotest unit tests, in OBS
> for some ARM systems).
>
> Another option for setting cpu affinity is to use the not portable
> pthread_attr_setaffinity_np, but it is not available with musl.
>
> Fixes: b28c6196b132 ("eal/unix: fix thread creation")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Luca Boccassi <bluca@debian.org>
next prev parent reply other threads:[~2024-11-04 0:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-02 10:08 [PATCH] " David Marchand
2024-11-02 11:32 ` [PATCH v2] " David Marchand
2024-11-02 12:36 ` Luca Boccassi
2024-11-02 19:58 ` [PATCH] " Stephen Hemminger
2024-11-03 10:37 ` David Marchand
2024-11-03 11:25 ` [PATCH v3] " David Marchand
2024-11-03 16:10 ` Stephen Hemminger
2024-11-04 0:19 ` fengchengwen [this message]
2024-11-04 8:57 ` [PATCH v4] eal/unix: optimize thread creation David Marchand
2024-11-04 17:12 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=338eb7c7-e746-4a52-a318-be275e70e258@huawei.com \
--to=fengchengwen@huawei.com \
--cc=bluca@debian.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=luca.boccassi@gmail.com \
--cc=roretzla@linux.microsoft.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).