Re: [dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: workaround softnic CLI modifications

[Thomas Monjalon <thomas@monjalon.net>]

24/07/2018 19:39, Dumitrescu, Cristian:
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Moti Haimovsky
> > Sent: Tuesday, July 24, 2018 5:21 PM
> > To: thomas@monjalon.net
> > Cc: dev@dpdk.org; stable@dpdk.org; Moti Haimovsky
> > <motih@mellanox.com>
> > Subject: [dpdk-dev] [PATCH] app/testpmd: workaround softnic CLI
> > modifications
> > 
> > This patch returns the previous testpmd command line handling
> > routines (namely cmdline_interact and cmdline_stdin_exit) to the
> > prompt routine in order to overcome testpmd abnormal exit observed on
> > several setups.
> > These routines will only by used when testpmd is compiled without
> > support for RTE_LIBRTE_PMD_SOFTNIC
> > 
> > Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Moti Haimovsky <motih@mellanox.com>
> > ---
> >  app/test-pmd/cmdline.c | 18 +++++++++---------
> >  1 file changed, 9 insertions(+), 9 deletions(-)
> > 
> 
> We should probably fix the issue in the cmdline library to bring cmdline_poll() on parity with cmdline_interact(), but this is a decent workaround to avoid breaking those automation scripts that rely on Ctrl+D behavior.

This workaround works only when disabling softnic.
It means:
	1/ softnic usage is not fixed
	2/ we need to disable softnic for all other usages

I think it is not good enough.