Re: [PATCH] mbuf: expose outer vlan in mbuf dump

[Thomas Monjalon <thomas@monjalon.net>]

04/04/2022 12:33, Kevin Traynor:
> On 04/04/2022 07:15, Morten Brørup wrote:
> >> From: Ben Magistro [mailto:koncept1@gmail.com]
> >> Sent: Monday, 4 April 2022 02.57
> >>
> >> Enable printing of the outer vlan if flags indicate it is present.
> >>
> >> Signed-off-by: Ben Magistro <koncept1@gmail.com>
> >>
> >> ---
> >>
> >> While troubleshooting some QinQ offloads with various Intel i40e
> >> firmware[1], it was
> >> helpful to expose the outer vlan in the dump mbuf calls.  This should
> >> be straightforward
> >> to backport and happy to do the work if accepted. I understand that
> >> this may not be a
> >> widely supported capability at this time, so we are okay if this is not
> >> accepted and
> >> we just maintain a local patch.
> > 
> > Features are usually not backported, only bug fixes.
> > 
> > However, since this patch proved helpful finding a bug, and it is very simple, it could be considered by the LTS maintainers.
> 
> 
> Suggest to tag the patch with 'Cc: stable@dpdk.org' to indicate it is 
> requested for stable branches. It will be caught by stable maintainer 
> filters when it is time for backports and can be discussed further then.

I think it is a bug.
What was introduced first? the function or the field?
Please find the commit where it should have been done
and mark it with "Fixes:" syntax + Cc:stable.