* [dpdk-stable] [PATCH] gso: fix VxLAN/GRE tunnel checks
@ 2019-01-18 13:28 Andrew Rybchenko
2019-01-19 13:31 ` Hu, Jiayu
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Andrew Rybchenko @ 2019-01-18 13:28 UTC (permalink / raw)
To: Jiayu Hu; +Cc: dev, stable
Tunnel type is an enum in PKT_TX_TUNNEL_MASK bits.
Fixes: b058d92ea95d ("gso: support VxLAN GSO")
Fixes: 70e737e448c7 ("gso: support GRE GSO")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
lib/librte_gso/gso_common.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_gso/gso_common.h b/lib/librte_gso/gso_common.h
index 6cd764ff5..b6ff1b886 100644
--- a/lib/librte_gso/gso_common.h
+++ b/lib/librte_gso/gso_common.h
@@ -22,12 +22,12 @@
(PKT_TX_TCP_SEG | PKT_TX_IPV4))
#define IS_IPV4_VXLAN_TCP4(flag) (((flag) & (PKT_TX_TCP_SEG | PKT_TX_IPV4 | \
- PKT_TX_OUTER_IPV4 | PKT_TX_TUNNEL_VXLAN)) == \
+ PKT_TX_OUTER_IPV4 | PKT_TX_TUNNEL_MASK)) == \
(PKT_TX_TCP_SEG | PKT_TX_IPV4 | PKT_TX_OUTER_IPV4 | \
PKT_TX_TUNNEL_VXLAN))
#define IS_IPV4_GRE_TCP4(flag) (((flag) & (PKT_TX_TCP_SEG | PKT_TX_IPV4 | \
- PKT_TX_OUTER_IPV4 | PKT_TX_TUNNEL_GRE)) == \
+ PKT_TX_OUTER_IPV4 | PKT_TX_TUNNEL_MASK)) == \
(PKT_TX_TCP_SEG | PKT_TX_IPV4 | PKT_TX_OUTER_IPV4 | \
PKT_TX_TUNNEL_GRE))
--
2.17.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-stable] [PATCH] gso: fix VxLAN/GRE tunnel checks
2019-01-18 13:28 [dpdk-stable] [PATCH] gso: fix VxLAN/GRE tunnel checks Andrew Rybchenko
@ 2019-01-19 13:31 ` Hu, Jiayu
2019-01-20 9:58 ` Andrew Rybchenko
2019-01-21 6:27 ` [dpdk-stable] [PATCH v2] " Andrew Rybchenko
2019-01-21 6:42 ` [dpdk-stable] [PATCH v3] " Andrew Rybchenko
2 siblings, 1 reply; 9+ messages in thread
From: Hu, Jiayu @ 2019-01-19 13:31 UTC (permalink / raw)
To: Andrew Rybchenko; +Cc: dev, stable
Hi Andrew,
Would you please give more explanation about the problem that
the patch wants to fix?
Thanks,
Jiayu
> -----Original Message-----
> From: Andrew Rybchenko [mailto:arybchenko@solarflare.com]
> Sent: Friday, January 18, 2019 9:29 PM
> To: Hu, Jiayu <jiayu.hu@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH] gso: fix VxLAN/GRE tunnel checks
>
> Tunnel type is an enum in PKT_TX_TUNNEL_MASK bits.
>
> Fixes: b058d92ea95d ("gso: support VxLAN GSO")
> Fixes: 70e737e448c7 ("gso: support GRE GSO")
> Cc: stable@dpdk.org
>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> lib/librte_gso/gso_common.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_gso/gso_common.h b/lib/librte_gso/gso_common.h
> index 6cd764ff5..b6ff1b886 100644
> --- a/lib/librte_gso/gso_common.h
> +++ b/lib/librte_gso/gso_common.h
> @@ -22,12 +22,12 @@
> (PKT_TX_TCP_SEG | PKT_TX_IPV4))
>
> #define IS_IPV4_VXLAN_TCP4(flag) (((flag) & (PKT_TX_TCP_SEG |
> PKT_TX_IPV4 | \
> - PKT_TX_OUTER_IPV4 |
> PKT_TX_TUNNEL_VXLAN)) == \
> + PKT_TX_OUTER_IPV4 |
> PKT_TX_TUNNEL_MASK)) == \
> (PKT_TX_TCP_SEG | PKT_TX_IPV4 | PKT_TX_OUTER_IPV4 |
> \
> PKT_TX_TUNNEL_VXLAN))
>
> #define IS_IPV4_GRE_TCP4(flag) (((flag) & (PKT_TX_TCP_SEG |
> PKT_TX_IPV4 | \
> - PKT_TX_OUTER_IPV4 |
> PKT_TX_TUNNEL_GRE)) == \
> + PKT_TX_OUTER_IPV4 |
> PKT_TX_TUNNEL_MASK)) == \
> (PKT_TX_TCP_SEG | PKT_TX_IPV4 | PKT_TX_OUTER_IPV4 |
> \
> PKT_TX_TUNNEL_GRE))
>
> --
> 2.17.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-stable] [PATCH] gso: fix VxLAN/GRE tunnel checks
2019-01-19 13:31 ` Hu, Jiayu
@ 2019-01-20 9:58 ` Andrew Rybchenko
2019-01-20 13:27 ` Hu, Jiayu
0 siblings, 1 reply; 9+ messages in thread
From: Andrew Rybchenko @ 2019-01-20 9:58 UTC (permalink / raw)
To: Hu, Jiayu; +Cc: dev, stable
On 1/19/19 4:31 PM, Hu, Jiayu wrote:
> Hi Andrew,
>
> Would you please give more explanation about the problem that
> the patch wants to fix?
Let's consider if tunnel is IPIP (0x3ULL << 45) or MPLSINUDP (0x5ULL << 45).
If so flags & VXLAN (0x1ULL << 45), still makes (0x1ULL << 45)==VXLAN,
but it is not a VXLAN tunnel packet.
Andrew.
>
> Thanks,
> Jiayu
>> -----Original Message-----
>> From: Andrew Rybchenko [mailto:arybchenko@solarflare.com]
>> Sent: Friday, January 18, 2019 9:29 PM
>> To: Hu, Jiayu <jiayu.hu@intel.com>
>> Cc: dev@dpdk.org; stable@dpdk.org
>> Subject: [PATCH] gso: fix VxLAN/GRE tunnel checks
>>
>> Tunnel type is an enum in PKT_TX_TUNNEL_MASK bits.
>>
>> Fixes: b058d92ea95d ("gso: support VxLAN GSO")
>> Fixes: 70e737e448c7 ("gso: support GRE GSO")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>> ---
>> lib/librte_gso/gso_common.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/lib/librte_gso/gso_common.h b/lib/librte_gso/gso_common.h
>> index 6cd764ff5..b6ff1b886 100644
>> --- a/lib/librte_gso/gso_common.h
>> +++ b/lib/librte_gso/gso_common.h
>> @@ -22,12 +22,12 @@
>> (PKT_TX_TCP_SEG | PKT_TX_IPV4))
>>
>> #define IS_IPV4_VXLAN_TCP4(flag) (((flag) & (PKT_TX_TCP_SEG |
>> PKT_TX_IPV4 | \
>> - PKT_TX_OUTER_IPV4 |
>> PKT_TX_TUNNEL_VXLAN)) == \
>> + PKT_TX_OUTER_IPV4 |
>> PKT_TX_TUNNEL_MASK)) == \
>> (PKT_TX_TCP_SEG | PKT_TX_IPV4 | PKT_TX_OUTER_IPV4 |
>> \
>> PKT_TX_TUNNEL_VXLAN))
>>
>> #define IS_IPV4_GRE_TCP4(flag) (((flag) & (PKT_TX_TCP_SEG |
>> PKT_TX_IPV4 | \
>> - PKT_TX_OUTER_IPV4 |
>> PKT_TX_TUNNEL_GRE)) == \
>> + PKT_TX_OUTER_IPV4 |
>> PKT_TX_TUNNEL_MASK)) == \
>> (PKT_TX_TCP_SEG | PKT_TX_IPV4 | PKT_TX_OUTER_IPV4 |
>> \
>> PKT_TX_TUNNEL_GRE))
>>
>> --
>> 2.17.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-stable] [PATCH] gso: fix VxLAN/GRE tunnel checks
2019-01-20 9:58 ` Andrew Rybchenko
@ 2019-01-20 13:27 ` Hu, Jiayu
0 siblings, 0 replies; 9+ messages in thread
From: Hu, Jiayu @ 2019-01-20 13:27 UTC (permalink / raw)
To: Andrew Rybchenko; +Cc: dev, stable
Yes, this is a bug. Thanks for catching it.
But the commit log doesn’t tell what issue the patch fixes. Can you
add it in the commit log?
Thanks,
Jiayu
From: Andrew Rybchenko [mailto:arybchenko@solarflare.com]
Sent: Sunday, January 20, 2019 5:59 PM
To: Hu, Jiayu <jiayu.hu@intel.com>
Cc: dev@dpdk.org; stable@dpdk.org
Subject: Re: [PATCH] gso: fix VxLAN/GRE tunnel checks
On 1/19/19 4:31 PM, Hu, Jiayu wrote:
Hi Andrew,
Would you please give more explanation about the problem that
the patch wants to fix?
Let's consider if tunnel is IPIP (0x3ULL << 45) or MPLSINUDP (0x5ULL << 45).
If so flags & VXLAN (0x1ULL << 45), still makes (0x1ULL << 45)==VXLAN,
but it is not a VXLAN tunnel packet.
Andrew.
Thanks,
Jiayu
-----Original Message-----
From: Andrew Rybchenko [mailto:arybchenko@solarflare.com]
Sent: Friday, January 18, 2019 9:29 PM
To: Hu, Jiayu <jiayu.hu@intel.com><mailto:jiayu.hu@intel.com>
Cc: dev@dpdk.org<mailto:dev@dpdk.org>; stable@dpdk.org<mailto:stable@dpdk.org>
Subject: [PATCH] gso: fix VxLAN/GRE tunnel checks
Tunnel type is an enum in PKT_TX_TUNNEL_MASK bits.
Fixes: b058d92ea95d ("gso: support VxLAN GSO")
Fixes: 70e737e448c7 ("gso: support GRE GSO")
Cc: stable@dpdk.org<mailto:stable@dpdk.org>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com><mailto:arybchenko@solarflare.com>
---
lib/librte_gso/gso_common.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_gso/gso_common.h b/lib/librte_gso/gso_common.h
index 6cd764ff5..b6ff1b886 100644
--- a/lib/librte_gso/gso_common.h
+++ b/lib/librte_gso/gso_common.h
@@ -22,12 +22,12 @@
(PKT_TX_TCP_SEG | PKT_TX_IPV4))
#define IS_IPV4_VXLAN_TCP4(flag) (((flag) & (PKT_TX_TCP_SEG |
PKT_TX_IPV4 | \
- PKT_TX_OUTER_IPV4 |
PKT_TX_TUNNEL_VXLAN)) == \
+ PKT_TX_OUTER_IPV4 |
PKT_TX_TUNNEL_MASK)) == \
(PKT_TX_TCP_SEG | PKT_TX_IPV4 | PKT_TX_OUTER_IPV4 |
\
PKT_TX_TUNNEL_VXLAN))
#define IS_IPV4_GRE_TCP4(flag) (((flag) & (PKT_TX_TCP_SEG |
PKT_TX_IPV4 | \
- PKT_TX_OUTER_IPV4 |
PKT_TX_TUNNEL_GRE)) == \
+ PKT_TX_OUTER_IPV4 |
PKT_TX_TUNNEL_MASK)) == \
(PKT_TX_TCP_SEG | PKT_TX_IPV4 | PKT_TX_OUTER_IPV4 |
\
PKT_TX_TUNNEL_GRE))
--
2.17.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [dpdk-stable] [PATCH v2] gso: fix VxLAN/GRE tunnel checks
2019-01-18 13:28 [dpdk-stable] [PATCH] gso: fix VxLAN/GRE tunnel checks Andrew Rybchenko
2019-01-19 13:31 ` Hu, Jiayu
@ 2019-01-21 6:27 ` Andrew Rybchenko
2019-01-21 6:40 ` Hu, Jiayu
2019-01-21 6:42 ` [dpdk-stable] [PATCH v3] " Andrew Rybchenko
2 siblings, 1 reply; 9+ messages in thread
From: Andrew Rybchenko @ 2019-01-21 6:27 UTC (permalink / raw)
To: Jiayu Hu; +Cc: dev, stable
Tunnel type is an enum in PKT_TX_TUNNEL_MASK bits.
As the result, for example, IPIP or MPLSinUDP tunnel packets may be
incorrected treated internally as VXLAN.
Fixes: b058d92ea95d ("gso: support VxLAN GSO")
Fixes: 70e737e448c7 ("gso: support GRE GSO")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
lib/librte_gso/gso_common.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_gso/gso_common.h b/lib/librte_gso/gso_common.h
index 6cd764ff5..b6ff1b886 100644
--- a/lib/librte_gso/gso_common.h
+++ b/lib/librte_gso/gso_common.h
@@ -22,12 +22,12 @@
(PKT_TX_TCP_SEG | PKT_TX_IPV4))
#define IS_IPV4_VXLAN_TCP4(flag) (((flag) & (PKT_TX_TCP_SEG | PKT_TX_IPV4 | \
- PKT_TX_OUTER_IPV4 | PKT_TX_TUNNEL_VXLAN)) == \
+ PKT_TX_OUTER_IPV4 | PKT_TX_TUNNEL_MASK)) == \
(PKT_TX_TCP_SEG | PKT_TX_IPV4 | PKT_TX_OUTER_IPV4 | \
PKT_TX_TUNNEL_VXLAN))
#define IS_IPV4_GRE_TCP4(flag) (((flag) & (PKT_TX_TCP_SEG | PKT_TX_IPV4 | \
- PKT_TX_OUTER_IPV4 | PKT_TX_TUNNEL_GRE)) == \
+ PKT_TX_OUTER_IPV4 | PKT_TX_TUNNEL_MASK)) == \
(PKT_TX_TCP_SEG | PKT_TX_IPV4 | PKT_TX_OUTER_IPV4 | \
PKT_TX_TUNNEL_GRE))
--
2.17.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-stable] [PATCH v2] gso: fix VxLAN/GRE tunnel checks
2019-01-21 6:27 ` [dpdk-stable] [PATCH v2] " Andrew Rybchenko
@ 2019-01-21 6:40 ` Hu, Jiayu
0 siblings, 0 replies; 9+ messages in thread
From: Hu, Jiayu @ 2019-01-21 6:40 UTC (permalink / raw)
To: Andrew Rybchenko; +Cc: dev, stable
> -----Original Message-----
> From: Andrew Rybchenko [mailto:arybchenko@solarflare.com]
> Sent: Monday, January 21, 2019 2:28 PM
> To: Hu, Jiayu <jiayu.hu@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH v2] gso: fix VxLAN/GRE tunnel checks
>
> Tunnel type is an enum in PKT_TX_TUNNEL_MASK bits.
> As the result, for example, IPIP or MPLSinUDP tunnel packets may be
> incorrected treated internally as VXLAN.
There is a typo: 'incorrected' -> 'incorrectly'.
Thanks,
Jiayu
>
> Fixes: b058d92ea95d ("gso: support VxLAN GSO")
> Fixes: 70e737e448c7 ("gso: support GRE GSO")
> Cc: stable@dpdk.org
>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> lib/librte_gso/gso_common.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_gso/gso_common.h b/lib/librte_gso/gso_common.h
> index 6cd764ff5..b6ff1b886 100644
> --- a/lib/librte_gso/gso_common.h
> +++ b/lib/librte_gso/gso_common.h
> @@ -22,12 +22,12 @@
> (PKT_TX_TCP_SEG | PKT_TX_IPV4))
>
> #define IS_IPV4_VXLAN_TCP4(flag) (((flag) & (PKT_TX_TCP_SEG |
> PKT_TX_IPV4 | \
> - PKT_TX_OUTER_IPV4 |
> PKT_TX_TUNNEL_VXLAN)) == \
> + PKT_TX_OUTER_IPV4 |
> PKT_TX_TUNNEL_MASK)) == \
> (PKT_TX_TCP_SEG | PKT_TX_IPV4 | PKT_TX_OUTER_IPV4 |
> \
> PKT_TX_TUNNEL_VXLAN))
>
> #define IS_IPV4_GRE_TCP4(flag) (((flag) & (PKT_TX_TCP_SEG |
> PKT_TX_IPV4 | \
> - PKT_TX_OUTER_IPV4 |
> PKT_TX_TUNNEL_GRE)) == \
> + PKT_TX_OUTER_IPV4 |
> PKT_TX_TUNNEL_MASK)) == \
> (PKT_TX_TCP_SEG | PKT_TX_IPV4 | PKT_TX_OUTER_IPV4 |
> \
> PKT_TX_TUNNEL_GRE))
>
> --
> 2.17.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [dpdk-stable] [PATCH v3] gso: fix VxLAN/GRE tunnel checks
2019-01-18 13:28 [dpdk-stable] [PATCH] gso: fix VxLAN/GRE tunnel checks Andrew Rybchenko
2019-01-19 13:31 ` Hu, Jiayu
2019-01-21 6:27 ` [dpdk-stable] [PATCH v2] " Andrew Rybchenko
@ 2019-01-21 6:42 ` Andrew Rybchenko
2019-01-21 6:45 ` Hu, Jiayu
2 siblings, 1 reply; 9+ messages in thread
From: Andrew Rybchenko @ 2019-01-21 6:42 UTC (permalink / raw)
To: Jiayu Hu; +Cc: dev, stable
Tunnel type is an enum in PKT_TX_TUNNEL_MASK bits.
As the result, for example, IPIP or MPLSinUDP tunnel packets may be
incorrectly treated internally as VXLAN.
Fixes: b058d92ea95d ("gso: support VxLAN GSO")
Fixes: 70e737e448c7 ("gso: support GRE GSO")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
lib/librte_gso/gso_common.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_gso/gso_common.h b/lib/librte_gso/gso_common.h
index 6cd764ff5..b6ff1b886 100644
--- a/lib/librte_gso/gso_common.h
+++ b/lib/librte_gso/gso_common.h
@@ -22,12 +22,12 @@
(PKT_TX_TCP_SEG | PKT_TX_IPV4))
#define IS_IPV4_VXLAN_TCP4(flag) (((flag) & (PKT_TX_TCP_SEG | PKT_TX_IPV4 | \
- PKT_TX_OUTER_IPV4 | PKT_TX_TUNNEL_VXLAN)) == \
+ PKT_TX_OUTER_IPV4 | PKT_TX_TUNNEL_MASK)) == \
(PKT_TX_TCP_SEG | PKT_TX_IPV4 | PKT_TX_OUTER_IPV4 | \
PKT_TX_TUNNEL_VXLAN))
#define IS_IPV4_GRE_TCP4(flag) (((flag) & (PKT_TX_TCP_SEG | PKT_TX_IPV4 | \
- PKT_TX_OUTER_IPV4 | PKT_TX_TUNNEL_GRE)) == \
+ PKT_TX_OUTER_IPV4 | PKT_TX_TUNNEL_MASK)) == \
(PKT_TX_TCP_SEG | PKT_TX_IPV4 | PKT_TX_OUTER_IPV4 | \
PKT_TX_TUNNEL_GRE))
--
2.17.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-stable] [PATCH v3] gso: fix VxLAN/GRE tunnel checks
2019-01-21 6:42 ` [dpdk-stable] [PATCH v3] " Andrew Rybchenko
@ 2019-01-21 6:45 ` Hu, Jiayu
2019-01-22 16:09 ` Thomas Monjalon
0 siblings, 1 reply; 9+ messages in thread
From: Hu, Jiayu @ 2019-01-21 6:45 UTC (permalink / raw)
To: Andrew Rybchenko; +Cc: dev, stable
> -----Original Message-----
> From: Andrew Rybchenko [mailto:arybchenko@solarflare.com]
> Sent: Monday, January 21, 2019 2:43 PM
> To: Hu, Jiayu <jiayu.hu@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH v3] gso: fix VxLAN/GRE tunnel checks
>
> Tunnel type is an enum in PKT_TX_TUNNEL_MASK bits.
> As the result, for example, IPIP or MPLSinUDP tunnel packets may be
> incorrectly treated internally as VXLAN.
>
> Fixes: b058d92ea95d ("gso: support VxLAN GSO")
> Fixes: 70e737e448c7 ("gso: support GRE GSO")
> Cc: stable@dpdk.org
>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> lib/librte_gso/gso_common.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_gso/gso_common.h b/lib/librte_gso/gso_common.h
> index 6cd764ff5..b6ff1b886 100644
> --- a/lib/librte_gso/gso_common.h
> +++ b/lib/librte_gso/gso_common.h
> @@ -22,12 +22,12 @@
> (PKT_TX_TCP_SEG | PKT_TX_IPV4))
>
> #define IS_IPV4_VXLAN_TCP4(flag) (((flag) & (PKT_TX_TCP_SEG |
> PKT_TX_IPV4 | \
> - PKT_TX_OUTER_IPV4 |
> PKT_TX_TUNNEL_VXLAN)) == \
> + PKT_TX_OUTER_IPV4 |
> PKT_TX_TUNNEL_MASK)) == \
> (PKT_TX_TCP_SEG | PKT_TX_IPV4 | PKT_TX_OUTER_IPV4 |
> \
> PKT_TX_TUNNEL_VXLAN))
>
> #define IS_IPV4_GRE_TCP4(flag) (((flag) & (PKT_TX_TCP_SEG |
> PKT_TX_IPV4 | \
> - PKT_TX_OUTER_IPV4 |
> PKT_TX_TUNNEL_GRE)) == \
> + PKT_TX_OUTER_IPV4 |
> PKT_TX_TUNNEL_MASK)) == \
> (PKT_TX_TCP_SEG | PKT_TX_IPV4 | PKT_TX_OUTER_IPV4 |
> \
> PKT_TX_TUNNEL_GRE))
>
> --
> 2.17.1
Acked-by: Jiayu Hu <jiayu.hu@intel.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-stable] [PATCH v3] gso: fix VxLAN/GRE tunnel checks
2019-01-21 6:45 ` Hu, Jiayu
@ 2019-01-22 16:09 ` Thomas Monjalon
0 siblings, 0 replies; 9+ messages in thread
From: Thomas Monjalon @ 2019-01-22 16:09 UTC (permalink / raw)
To: Andrew Rybchenko; +Cc: stable, Hu, Jiayu, dev
> > Tunnel type is an enum in PKT_TX_TUNNEL_MASK bits.
> > As the result, for example, IPIP or MPLSinUDP tunnel packets may be
> > incorrectly treated internally as VXLAN.
> >
> > Fixes: b058d92ea95d ("gso: support VxLAN GSO")
> > Fixes: 70e737e448c7 ("gso: support GRE GSO")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>
> Acked-by: Jiayu Hu <jiayu.hu@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-01-22 16:09 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-18 13:28 [dpdk-stable] [PATCH] gso: fix VxLAN/GRE tunnel checks Andrew Rybchenko
2019-01-19 13:31 ` Hu, Jiayu
2019-01-20 9:58 ` Andrew Rybchenko
2019-01-20 13:27 ` Hu, Jiayu
2019-01-21 6:27 ` [dpdk-stable] [PATCH v2] " Andrew Rybchenko
2019-01-21 6:40 ` Hu, Jiayu
2019-01-21 6:42 ` [dpdk-stable] [PATCH v3] " Andrew Rybchenko
2019-01-21 6:45 ` Hu, Jiayu
2019-01-22 16:09 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).