From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D840FA09D9 for ; Wed, 11 Nov 2020 11:44:17 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CE262493D; Wed, 11 Nov 2020 11:44:16 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 50269493D for ; Wed, 11 Nov 2020 11:44:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605091452; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GPWTr8wbHUodWPbOEm4dOSNA7UyOkwNGRXXsYVhY4+4=; b=O2fpHJS8TrsvWVYhaR/o5xREMcxdpNKgiV9gBFxixfTQOZNUZqmH0pYNcfz+cX8kg+/ucM Q11JiV4g2uxLljB4ASE1ggrzaM1ZEjO9/7TIXOZmSeF5URxMnEl1/w9ExAm2jeqVOeSUhE zNcfGKQ/BBLkhHePZQNW9YXYw4+DgGU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-210-vGQaeMBiNz6bUwSfNJyz6g-1; Wed, 11 Nov 2020 05:44:10 -0500 X-MC-Unique: vGQaeMBiNz6bUwSfNJyz6g-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B48FD1084C9B; Wed, 11 Nov 2020 10:44:09 +0000 (UTC) Received: from [10.36.113.249] (ovpn-113-249.ams2.redhat.com [10.36.113.249]) by smtp.corp.redhat.com (Postfix) with ESMTP id 651F15C269; Wed, 11 Nov 2020 10:44:02 +0000 (UTC) To: David Marchand , Bruce Richardson Cc: Wei Ling , Ferruh Yigit , dpdk stable References: <20201105124015.306404-1-ktraynor@redhat.com> <20201105124015.306404-15-ktraynor@redhat.com> From: Kevin Traynor Message-ID: <3442a619-0beb-8441-5752-d709a850fe75@redhat.com> Date: Wed, 11 Nov 2020 10:44:00 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-stable] patch 'app/testpmd: fix name of bitrate library in meson build' has been queued to LTS release 18.11.11 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 05/11/2020 13:22, David Marchand wrote: > On Thu, Nov 5, 2020 at 1:41 PM Kevin Traynor wrote: >> From 1bde6247b23c54adb47fa48a5373270ca05a32b4 Mon Sep 17 00:00:00 2001 >> From: Bruce Richardson >> Date: Wed, 2 Sep 2020 17:24:27 +0100 >> Subject: [PATCH] app/testpmd: fix name of bitrate library in meson build >> >> [ upstream commit 54f89e3df4b16e9079c9d343870d16757429b68b ] >> >> The bitrate library in DPDK is actually in a "bitratestats" directory, >> so that is used by meson for the macro and library name. >> Therefore, we need to update references to RTE_LIBRTE_BITRATE to >> RTE_LIBRTE_BITRATESTATS in testpmd to have it found. Rather than >> supporting both defines, since make is being removed, we can just >> replace all instances of the former define with the latter. >> >> To ensure testpmd links ok when this is done, we also need to add >> bitratestats to the list of library dependencies. > > This backport will fix meson builds, but it will drop bitratestats > support in testpmd built with make. > > Thanks David. That would be a user visible regression, so we can't do that. I will drop the patch for now and we can discuss after 20.11 when everyone is less busy.