From: Thomas Monjalon <thomas@monjalon.net>
To: Ciara Power <ciara.power@intel.com>
Cc: gakhil@marvell.com, Ciara Power <ciara.power@intel.com>,
kai.ji@intel.com, gmuthukrishn@marvell.com,
sunila.sahu@caviumnetworks.com, stable@dpdk.org
Subject: Re: [PATCH v3] crypto/openssl: fix asym memory leaks
Date: Mon, 13 Nov 2023 16:24:13 +0100 [thread overview]
Message-ID: <3449816.QJadu78ljV@thomas> (raw)
In-Reply-To: <20231113131623.1485483-1-ciara.power@intel.com>
13/11/2023 14:16, Ciara Power:
> Numerous memory leaks were detected by ASAN
> in the OpenSSL PMD asymmetric code path.
>
> These are now fixed to free all variables allocated
> by OpenSSL functions such as BN_bin2bn and
> OSSL_PARAM_BLD_new.
>
> Some need to exist until the op is processed,
> for example the BIGNUMs associated with DSA.
> The pointers for these are added to the private
> asym session so they can be accessed later when calling free.
>
> Some cases need to be treated differently if OpenSSL < 3.0.
> It has slightly different handling of memory, as functions such as
> RSA_set0_key() take over memory management of values,
> so the caller should not free the values.
>
> Fixes: 4c7ae22f1f83 ("crypto/openssl: update DSA routine with 3.0 EVP API")
> Fixes: c794b40c9258 ("crypto/openssl: update DH routine with 3.0 EVP API")
> Fixes: 3b7d638fb11f ("crypto/openssl: support asymmetric SM2")
> Fixes: ac42813a0a7c ("crypto/openssl: add DH and DSA asym operations")
> Fixes: d7bd42f6db19 ("crypto/openssl: update RSA routine with 3.0 EVP API")
> Fixes: ad149f93093e ("crypto/openssl: fix memory leaks in asym ops")
> Cc: kai.ji@intel.com
> Cc: gmuthukrishn@marvell.com
> Cc: sunila.sahu@caviumnetworks.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> Acked-by: Kai Ji <kai.ji@intel.com>
Applied, thanks.
prev parent reply other threads:[~2023-11-13 15:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 15:45 [PATCH] " Ciara Power
2023-11-06 23:14 ` Ji, Kai
2023-11-13 6:24 ` [EXT] " Akhil Goyal
2023-11-13 13:07 ` [PATCH v2] " Ciara Power
2023-11-13 13:16 ` [PATCH v3] " Ciara Power
2023-11-13 15:24 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3449816.QJadu78ljV@thomas \
--to=thomas@monjalon.net \
--cc=ciara.power@intel.com \
--cc=gakhil@marvell.com \
--cc=gmuthukrishn@marvell.com \
--cc=kai.ji@intel.com \
--cc=stable@dpdk.org \
--cc=sunila.sahu@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).