From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id EABB810F62; Thu, 30 Mar 2017 13:56:20 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP; 30 Mar 2017 04:56:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,246,1486454400"; d="scan'208";a="1148791774" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by fmsmga002.fm.intel.com with ESMTP; 30 Mar 2017 04:56:19 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.153]) by IRSMSX108.ger.corp.intel.com ([169.254.11.239]) with mapi id 14.03.0319.002; Thu, 30 Mar 2017 12:55:57 +0100 From: "Doherty, Declan" To: "De Lara Guarch, Pablo" , "Gonzalez Monroy, Sergio" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH] crypto/aesni_gcm: do crypto op in dequeue function Thread-Index: AQHSqJJlzLyU9uUzxE6ha+pFIND3ZKGtRPSA///x5ICAABDq4A== Date: Thu, 30 Mar 2017 11:55:57 +0000 Message-ID: <345C63BAECC1AD42A2EC8C63AFFC3ADC63D36255@IRSMSX102.ger.corp.intel.com> References: <20170329134253.31909-1-sergio.gonzalez.monroy@intel.com> <7923ff78-ba53-4573-5c83-efc699ff53c1@intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH] crypto/aesni_gcm: do crypto op in dequeue function X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 11:56:21 -0000 -----Original Message----- From: De Lara Guarch, Pablo=20 Sent: Thursday, March 30, 2017 12:54 PM To: Doherty, Declan ; Gonzalez Monroy, Sergio ; dev@dpdk.org Cc: stable@dpdk.org Subject: RE: [PATCH] crypto/aesni_gcm: do crypto op in dequeue function > -----Original Message----- > From: Doherty, Declan > Sent: Thursday, March 30, 2017 12:45 PM > To: Gonzalez Monroy, Sergio; dev@dpdk.org > Cc: De Lara Guarch, Pablo; stable@dpdk.org > Subject: Re: [PATCH] crypto/aesni_gcm: do crypto op in dequeue=20 > function >=20 > On 29/03/17 14:42, Sergio Gonzalez Monroy wrote: > > There is bug when more crypto ops are enqueued than dequeued. > > The return value is not checked when trying to enqueue the processed=20 > > crypto op into the internal ring, which in the case of being full=20 > > will results in crypto ops and mbufs being leaked. > > The issue is more obvious with different cores doing enqueue/dequeue. > > > > This patch moves the crypto operation to the dequeue function which=20 > > fixes the above issue without having to check for the number of free=20 > > entries in the ring. > > > > Fixes: eec136f3c54f ("aesni_gcm: add driver for AES-GCM crypto > operations") > > > > Signed-off-by: Sergio Gonzalez Monroy > > > --- > ... > > > Hi Declan, > Hey Sergio, this looks good but it needs to be rebased for the=20 > rte_ring API change. I also see a marginally performance increase with=20 > this change using the crypto-perf app which wasn't expected. Unless there is other change necessary, I can make that change when merging= . Thanks, Pablo >=20 >=20 > Acked-by: Declan Doherty Cool, no, that's the only issue. Cheers Declan