From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 006E8A0548 for ; Mon, 21 Jun 2021 19:23:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E829D411CA; Mon, 21 Jun 2021 19:23:04 +0200 (CEST) Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by mails.dpdk.org (Postfix) with ESMTP id 0FC4441158 for ; Mon, 21 Jun 2021 19:23:03 +0200 (CEST) Received: by mail-wr1-f44.google.com with SMTP id j1so3334638wrn.9 for ; Mon, 21 Jun 2021 10:23:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OLDmeOr+zQP39mnkd4vKjVZjmNCq0dDC67HS7TFIlQ4=; b=E7hgIJCUgM/7+i1t4O3quTFbzRF+BFXQjNJlFS2eQzpca+HqPbQ4Gfivo0YouZtyKc cL2tf3hbcdJgstIQOsXEel7eNZY76mktMVJDzVN8d790L/7SyiuugInXAq9nP8ajeP8K iX5KJQHtctani8Yzewnnf0nVWvZBlgEIJ3SxngVjC65o0l2KKeUjlM/4Gwohy3ixGRUR ryRSNjrLoICB5FFaQfr4+oBmJlaTTjHi2CYQhIUf63+lkEX6Bs3bsB/cXgSkX+LJ6FIx jVL4nAbRZnqzJF3I3QCiykvONTmqQuAfJ8hOdLNBJbAjammsIvzV5EeR1lfBGsABprx6 lnQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OLDmeOr+zQP39mnkd4vKjVZjmNCq0dDC67HS7TFIlQ4=; b=j4yHhwDWVIium4Msq/b8V8Dh67NcKzE/Rg8dfPYaulyp5Db95MI4pLr2AYcuXr8nPU ZZZqDNb51OYigbBtA21mA9ixnXzeqzcyTSoDqyS8DLdNmTs0U7D0vuxNTZSq0Gjoe7K5 VVYaXDF2a/fOr4Z+rnkC+Fi6eaSRHK6J960/OPLfK6kh3tFJRUKcRDWLsoAxCfHAcKtV W1CHDKli295uWNKFH4zBFKwYrLIo+5J6cUP09UGV26aWTBqlw2TtoNuvqHXQ3IzG5sOi lY56eQV0NFcZWAg3Mq9LmqgmjjBy3Od6U7C86WmAerVGZIm+ugMYdL8Y4rHRDr3lylsu 7qFg== X-Gm-Message-State: AOAM533lFGGBMVHvozcNvbHh2OUj6a9KGv7FhNhJhWjBZa/GuuBZ9kT6 Te9trV3AbfkcugxokG6Ccbz2MgJm2flJ X-Google-Smtp-Source: ABdhPJybDgMv1nZGeLCNpzJJXolD7E3ypaZ/xt55pZbl2JPW0m5g9sjiJ5BlMolEdYHX2TB+CHTmGw== X-Received: by 2002:adf:dcca:: with SMTP id x10mr26748733wrm.39.1624296182642; Mon, 21 Jun 2021 10:23:02 -0700 (PDT) Received: from [10.16.0.39] (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id o2sm11964135wrp.53.2021.06.21.10.23.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Jun 2021 10:23:02 -0700 (PDT) To: Thomas Monjalon , "Dumitrescu, Cristian" Cc: "dev@dpdk.org" , "stable@dpdk.org" References: <20210524085341.15184-1-thierry.herbelot@6wind.com> <786a1730-37eb-8f22-7812-74a8a7096dd9@6wind.com> <3815134.CEuO83SSsj@thomas> From: Thierry Herbelot Message-ID: <346451b4-b1ce-e144-dcb8-b09a9e1f208b@6wind.com> Date: Mon, 21 Jun 2021 19:23:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <3815134.CEuO83SSsj@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [PATCH v2] table: fix typo X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 6/21/21 6:14 PM, Thomas Monjalon wrote: > 21/06/2021 17:54, Thierry Herbelot: >> On 6/21/21 5:44 PM, Dumitrescu, Cristian wrote: >>> From: Thierry Herbelot >>>> On 6/17/21 9:01 AM, Thomas Monjalon wrote: >>>>>>> Check Bucket key for all possible indices. >>>>>>> >>>>>>> Fixes: d0a00966618ba ("table: add exact match SWX table") >>>>>>> Cc: stable@dpdk.org >>>>>>> Cc: Cristian Dumitrescu >>>>>>> >>>>>>> Signed-off-by: Thierry Herbelot >>>>> [...] >>>>>>> - return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2]) >>>>>>> + return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3]) >>>>>> >>>>>> Acked-by: Cristian Dumitrescu >>>>>> >>>>>> Thierry, thanks again, you could have actually added my ack from V1 :) >>>>> >>>>> The root cause looks to be a typo indeed, >>>>> but the impact or the scope of the issue >>>>> should stated in few words in the title please. >>>>> No need to send a v3, please suggest a title and I will apply. >>>> >>>> table: check a bucket is empty for all bucket keys >>>> >>>> Thierry >>>> >>> >>> Hi Thierry, >>> >>> I think Thomas is asking for you to send a new version of this patch with the title updated. Is this OK with you? > > No need to send a v3. >> >> Hello Cristian >> >> Sure ! >> >> What do you think of this title: >> >> "table: check a bucket is empty for all bucket keys" > > This title suggests it was not the intent before. > It should say that it fixes this check, > or better, name the area of the API which is fixed. "table: all keys must be checked to declare that a bucket is empty" > > -- Thierry Herbelot Senior Software Engineer Tel: +33 1 39 30 92 61 http://www.6wind.com/ Follow us: https://www.linkedin.com/company/6wind/ https://twitter.com/6WINDsoftware https://www.youtube.com/user/6windsoftware