* [dpdk-stable] [PATCH 1/9] crypto/aesni_mb: remove assert check [not found] <20170621064154.25124-1-pablo.de.lara.guarch@intel.com> @ 2017-06-21 6:41 ` Pablo de Lara 2017-06-21 6:41 ` [dpdk-stable] [PATCH 2/9] test/crypto: fix wrong AAD setting Pablo de Lara ` (5 subsequent siblings) 6 siblings, 0 replies; 20+ messages in thread From: Pablo de Lara @ 2017-06-21 6:41 UTC (permalink / raw) To: declan.doherty; +Cc: dev, Pablo de Lara, stable Some assert checks in the driver were incorrect, but they are not necessary anyway, as application will panic in any case. Fixes: 0f548b50a160 ("crypto/aesni_mb: process crypto op on dequeue") CC: stable@dpdk.org Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> --- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c index 45b25c9..43e4865 100644 --- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c +++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c @@ -494,8 +494,6 @@ static inline void verify_digest(JOB_AES_HMAC *job, struct rte_crypto_op *op) { struct rte_mbuf *m_dst = (struct rte_mbuf *)job->user_data2; - RTE_ASSERT(m_dst == NULL); - /* Verify digest if required */ if (memcmp(job->auth_tag_output, op->sym->auth.digest.data, job->auth_tag_output_len_in_bytes) != 0) @@ -522,8 +520,6 @@ post_process_mb_job(struct aesni_mb_qp *qp, JOB_AES_HMAC *job) struct aesni_mb_session *sess; - RTE_ASSERT(op == NULL); - if (unlikely(op->status == RTE_CRYPTO_OP_STATUS_ENQUEUED)) { switch (job->status) { case STS_COMPLETED: -- 2.9.4 ^ permalink raw reply [flat|nested] 20+ messages in thread
* [dpdk-stable] [PATCH 2/9] test/crypto: fix wrong AAD setting [not found] <20170621064154.25124-1-pablo.de.lara.guarch@intel.com> 2017-06-21 6:41 ` [dpdk-stable] [PATCH 1/9] crypto/aesni_mb: remove assert check Pablo de Lara @ 2017-06-21 6:41 ` Pablo de Lara 2017-06-21 17:39 ` [dpdk-stable] [dpdk-dev] " Trahe, Fiona 2017-06-21 6:41 ` [dpdk-stable] [PATCH 6/9] examples/l2fwd-crypto: fix application help Pablo de Lara ` (4 subsequent siblings) 6 siblings, 1 reply; 20+ messages in thread From: Pablo de Lara @ 2017-06-21 6:41 UTC (permalink / raw) To: declan.doherty; +Cc: dev, Pablo de Lara, stable AAD should not point at IV for AES algorithms. For AES-GCM, AAD will point at additional data in the mbuf. For the other algorithms (such as AES CBC), AAD is not used. Fixes: ffbe3be0d4b5 ("app/test: add libcrypto") CC: stable@dpdk.org Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> --- test/test/test_cryptodev_perf.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/test/test/test_cryptodev_perf.c b/test/test/test_cryptodev_perf.c index d60028d..3568b01 100644 --- a/test/test/test_cryptodev_perf.c +++ b/test/test/test_cryptodev_perf.c @@ -2634,6 +2634,11 @@ static uint8_t aes_iv[] = { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 }; +static uint8_t aes_gcm_aad[] = { + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 +}; + static uint8_t triple_des_key[] = { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, @@ -2895,7 +2900,7 @@ test_perf_create_armv8_session(uint8_t dev_id, enum chain_mode chain, #define AES_BLOCK_SIZE 16 #define AES_CIPHER_IV_LENGTH 16 - +#define AES_GCM_AAD_LENGTH 16 #define TRIPLE_DES_BLOCK_SIZE 8 #define TRIPLE_DES_CIPHER_IV_LENGTH 8 @@ -2939,8 +2944,6 @@ test_perf_set_crypto_op_aes(struct rte_crypto_op *op, struct rte_mbuf *m, op->sym->auth.digest.phys_addr = rte_pktmbuf_mtophys_offset(m, AES_CIPHER_IV_LENGTH + data_len); op->sym->auth.digest.length = digest_len; - op->sym->auth.aad.data = aes_iv; - op->sym->auth.aad.length = AES_CIPHER_IV_LENGTH; op->sym->auth.data.offset = AES_CIPHER_IV_LENGTH; op->sym->auth.data.length = data_len; } @@ -2977,8 +2980,8 @@ test_perf_set_crypto_op_aes_gcm(struct rte_crypto_op *op, struct rte_mbuf *m, op->sym->auth.digest.phys_addr = rte_pktmbuf_mtophys_offset(m, data_len); op->sym->auth.digest.length = digest_len; - op->sym->auth.aad.data = aes_iv; - op->sym->auth.aad.length = AES_CIPHER_IV_LENGTH; + op->sym->auth.aad.data = aes_gcm_aad; + op->sym->auth.aad.length = AES_GCM_AAD_LENGTH; /* Cipher Parameters */ op->sym->cipher.iv.data = aes_iv; -- 2.9.4 ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH 2/9] test/crypto: fix wrong AAD setting 2017-06-21 6:41 ` [dpdk-stable] [PATCH 2/9] test/crypto: fix wrong AAD setting Pablo de Lara @ 2017-06-21 17:39 ` Trahe, Fiona 2017-06-22 10:40 ` De Lara Guarch, Pablo 0 siblings, 1 reply; 20+ messages in thread From: Trahe, Fiona @ 2017-06-21 17:39 UTC (permalink / raw) To: De Lara Guarch, Pablo, Doherty, Declan Cc: dev, De Lara Guarch, Pablo, stable, Trahe, Fiona Hi Pablo, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara > Sent: Wednesday, June 21, 2017 7:42 AM > To: Doherty, Declan <declan.doherty@intel.com> > Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; stable@dpdk.org > Subject: [dpdk-dev] [PATCH 2/9] test/crypto: fix wrong AAD setting > > AAD should not point at IV for AES algorithms. > For AES-GCM, AAD will point at additional data in the mbuf. > For the other algorithms (such as AES CBC), AAD is not used. > > Fixes: ffbe3be0d4b5 ("app/test: add libcrypto") > CC: stable@dpdk.org > > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> > --- > test/test/test_cryptodev_perf.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/test/test/test_cryptodev_perf.c b/test/test/test_cryptodev_perf.c > index d60028d..3568b01 100644 > --- a/test/test/test_cryptodev_perf.c > +++ b/test/test/test_cryptodev_perf.c > @@ -2634,6 +2634,11 @@ static uint8_t aes_iv[] = { > 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 > }; > > +static uint8_t aes_gcm_aad[] = { > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 > +}; > + > static uint8_t triple_des_key[] = { > 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > @@ -2895,7 +2900,7 @@ test_perf_create_armv8_session(uint8_t dev_id, enum chain_mode chain, > > #define AES_BLOCK_SIZE 16 > #define AES_CIPHER_IV_LENGTH 16 > - > +#define AES_GCM_AAD_LENGTH 16 > #define TRIPLE_DES_BLOCK_SIZE 8 > #define TRIPLE_DES_CIPHER_IV_LENGTH 8 > > @@ -2939,8 +2944,6 @@ test_perf_set_crypto_op_aes(struct rte_crypto_op *op, struct rte_mbuf *m, > op->sym->auth.digest.phys_addr = rte_pktmbuf_mtophys_offset(m, > AES_CIPHER_IV_LENGTH + data_len); > op->sym->auth.digest.length = digest_len; > - op->sym->auth.aad.data = aes_iv; > - op->sym->auth.aad.length = AES_CIPHER_IV_LENGTH; Same change should be made for triple_des case > op->sym->auth.data.offset = AES_CIPHER_IV_LENGTH; > op->sym->auth.data.length = data_len; > } > @@ -2977,8 +2980,8 @@ test_perf_set_crypto_op_aes_gcm(struct rte_crypto_op *op, struct rte_mbuf > *m, > op->sym->auth.digest.phys_addr = > rte_pktmbuf_mtophys_offset(m, data_len); > op->sym->auth.digest.length = digest_len; > - op->sym->auth.aad.data = aes_iv; > - op->sym->auth.aad.length = AES_CIPHER_IV_LENGTH; > + op->sym->auth.aad.data = aes_gcm_aad; > + op->sym->auth.aad.length = AES_GCM_AAD_LENGTH; > > /* Cipher Parameters */ > op->sym->cipher.iv.data = aes_iv; > -- > 2.9.4 ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH 2/9] test/crypto: fix wrong AAD setting 2017-06-21 17:39 ` [dpdk-stable] [dpdk-dev] " Trahe, Fiona @ 2017-06-22 10:40 ` De Lara Guarch, Pablo 0 siblings, 0 replies; 20+ messages in thread From: De Lara Guarch, Pablo @ 2017-06-22 10:40 UTC (permalink / raw) To: Trahe, Fiona, Doherty, Declan; +Cc: dev, stable > -----Original Message----- > From: Trahe, Fiona > Sent: Wednesday, June 21, 2017 6:40 PM > To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Doherty, Declan > <declan.doherty@intel.com> > Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; > stable@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com> > Subject: RE: [dpdk-dev] [PATCH 2/9] test/crypto: fix wrong AAD setting > > Hi Pablo, > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara > > Sent: Wednesday, June 21, 2017 7:42 AM > > To: Doherty, Declan <declan.doherty@intel.com> > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > <pablo.de.lara.guarch@intel.com>; stable@dpdk.org > > Subject: [dpdk-dev] [PATCH 2/9] test/crypto: fix wrong AAD setting > > > > AAD should not point at IV for AES algorithms. > > For AES-GCM, AAD will point at additional data in the mbuf. > > For the other algorithms (such as AES CBC), AAD is not used. > > > > Fixes: ffbe3be0d4b5 ("app/test: add libcrypto") > > CC: stable@dpdk.org > > > > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> > > --- > > test/test/test_cryptodev_perf.c | 13 ++++++++----- > > 1 file changed, 8 insertions(+), 5 deletions(-) > > > > diff --git a/test/test/test_cryptodev_perf.c > > b/test/test/test_cryptodev_perf.c index d60028d..3568b01 100644 > > --- a/test/test/test_cryptodev_perf.c > > +++ b/test/test/test_cryptodev_perf.c > > @@ -2634,6 +2634,11 @@ static uint8_t aes_iv[] = { > > 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 }; > > > > +static uint8_t aes_gcm_aad[] = { > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 }; > > + > > static uint8_t triple_des_key[] = { > > 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > > 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, @@ -2895,7 > +2900,7 > > @@ test_perf_create_armv8_session(uint8_t dev_id, enum chain_mode > > chain, > > > > #define AES_BLOCK_SIZE 16 > > #define AES_CIPHER_IV_LENGTH 16 > > - > > +#define AES_GCM_AAD_LENGTH 16 > > #define TRIPLE_DES_BLOCK_SIZE 8 > > #define TRIPLE_DES_CIPHER_IV_LENGTH 8 > > > > @@ -2939,8 +2944,6 @@ test_perf_set_crypto_op_aes(struct rte_crypto_op > *op, struct rte_mbuf *m, > > op->sym->auth.digest.phys_addr = > rte_pktmbuf_mtophys_offset(m, > > AES_CIPHER_IV_LENGTH + data_len); > > op->sym->auth.digest.length = digest_len; > > - op->sym->auth.aad.data = aes_iv; > > - op->sym->auth.aad.length = AES_CIPHER_IV_LENGTH; > Same change should be made for triple_des case Good catch. Will fix in v2. > > > op->sym->auth.data.offset = AES_CIPHER_IV_LENGTH; > > op->sym->auth.data.length = data_len; > > } > > @@ -2977,8 +2980,8 @@ test_perf_set_crypto_op_aes_gcm(struct > > rte_crypto_op *op, struct rte_mbuf *m, > > op->sym->auth.digest.phys_addr = > > rte_pktmbuf_mtophys_offset(m, data_len); > > op->sym->auth.digest.length = digest_len; > > - op->sym->auth.aad.data = aes_iv; > > - op->sym->auth.aad.length = AES_CIPHER_IV_LENGTH; > > + op->sym->auth.aad.data = aes_gcm_aad; > > + op->sym->auth.aad.length = AES_GCM_AAD_LENGTH; > > > > /* Cipher Parameters */ > > op->sym->cipher.iv.data = aes_iv; > > -- > > 2.9.4 ^ permalink raw reply [flat|nested] 20+ messages in thread
* [dpdk-stable] [PATCH 6/9] examples/l2fwd-crypto: fix application help [not found] <20170621064154.25124-1-pablo.de.lara.guarch@intel.com> 2017-06-21 6:41 ` [dpdk-stable] [PATCH 1/9] crypto/aesni_mb: remove assert check Pablo de Lara 2017-06-21 6:41 ` [dpdk-stable] [PATCH 2/9] test/crypto: fix wrong AAD setting Pablo de Lara @ 2017-06-21 6:41 ` Pablo de Lara 2017-06-21 16:43 ` [dpdk-stable] [dpdk-dev] " Trahe, Fiona 2017-06-21 6:41 ` [dpdk-stable] [PATCH 7/9] examples/l2fwd-crypto: fix auth info display Pablo de Lara ` (3 subsequent siblings) 6 siblings, 1 reply; 20+ messages in thread From: Pablo de Lara @ 2017-06-21 6:41 UTC (permalink / raw) To: declan.doherty; +Cc: dev, Pablo de Lara, stable Chain parameter can be CIPHER_HASH, HASH_CIPHER, CIPHER_ONLY or HASH_ONLY, but only the first two were shown in the application help. Fixes: 1a75e9f3fadb ("examples/l2fwd-crypto: add cipher/hash only cases") CC: stable@dpdk.org Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> --- examples/l2fwd-crypto/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c index 66b4af3..841ec6e 100644 --- a/examples/l2fwd-crypto/main.c +++ b/examples/l2fwd-crypto/main.c @@ -842,7 +842,8 @@ l2fwd_crypto_usage(const char *prgname) " (0 to disable, 10 default, 86400 maximum)\n" " --cdev_type HW / SW / ANY\n" - " --chain HASH_CIPHER / CIPHER_HASH\n" + " --chain HASH_CIPHER / CIPHER_HASH / CIPHER_ONLY /" + " HASH_ONLY\n" " --cipher_algo ALGO\n" " --cipher_op ENCRYPT / DECRYPT\n" -- 2.9.4 ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH 6/9] examples/l2fwd-crypto: fix application help 2017-06-21 6:41 ` [dpdk-stable] [PATCH 6/9] examples/l2fwd-crypto: fix application help Pablo de Lara @ 2017-06-21 16:43 ` Trahe, Fiona 0 siblings, 0 replies; 20+ messages in thread From: Trahe, Fiona @ 2017-06-21 16:43 UTC (permalink / raw) To: De Lara Guarch, Pablo, Doherty, Declan; +Cc: dev, De Lara Guarch, Pablo, stable > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara > Sent: Wednesday, June 21, 2017 7:42 AM > To: Doherty, Declan <declan.doherty@intel.com> > Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; stable@dpdk.org > Subject: [dpdk-dev] [PATCH 6/9] examples/l2fwd-crypto: fix application help > > Chain parameter can be CIPHER_HASH, HASH_CIPHER, > CIPHER_ONLY or HASH_ONLY, but only the first two > were shown in the application help. > > Fixes: 1a75e9f3fadb ("examples/l2fwd-crypto: add cipher/hash only cases") > CC: stable@dpdk.org > > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> Acked-by: Fiona Trahe <fiona.trahe@intel.com> ^ permalink raw reply [flat|nested] 20+ messages in thread
* [dpdk-stable] [PATCH 7/9] examples/l2fwd-crypto: fix auth info display [not found] <20170621064154.25124-1-pablo.de.lara.guarch@intel.com> ` (2 preceding siblings ...) 2017-06-21 6:41 ` [dpdk-stable] [PATCH 6/9] examples/l2fwd-crypto: fix application help Pablo de Lara @ 2017-06-21 6:41 ` Pablo de Lara 2017-06-21 16:44 ` [dpdk-stable] [dpdk-dev] " Trahe, Fiona 2017-06-21 6:41 ` [dpdk-stable] [PATCH 8/9] app/crypto-perf: fix error message Pablo de Lara ` (2 subsequent siblings) 6 siblings, 1 reply; 20+ messages in thread From: Pablo de Lara @ 2017-06-21 6:41 UTC (permalink / raw) To: declan.doherty; +Cc: dev, Pablo de Lara, stable Fixes: 4790f99d2d31 ("examples/l2fwd-crypto: use cryptodev algorithm parser") CC: stable@dpdk.org Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> --- examples/l2fwd-crypto/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c index 841ec6e..779b4fb 100644 --- a/examples/l2fwd-crypto/main.c +++ b/examples/l2fwd-crypto/main.c @@ -1263,7 +1263,7 @@ display_auth_info(struct l2fwd_crypto_options *options) { printf("\n---- Authentication information ---\n"); printf("Algorithm: %s\n", - rte_crypto_auth_algorithm_strings[options->auth_xform.cipher.algo]); + rte_crypto_auth_algorithm_strings[options->auth_xform.auth.algo]); rte_hexdump(stdout, "Auth key:", options->auth_xform.auth.key.data, options->auth_xform.auth.key.length); -- 2.9.4 ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH 7/9] examples/l2fwd-crypto: fix auth info display 2017-06-21 6:41 ` [dpdk-stable] [PATCH 7/9] examples/l2fwd-crypto: fix auth info display Pablo de Lara @ 2017-06-21 16:44 ` Trahe, Fiona 0 siblings, 0 replies; 20+ messages in thread From: Trahe, Fiona @ 2017-06-21 16:44 UTC (permalink / raw) To: De Lara Guarch, Pablo, Doherty, Declan; +Cc: dev, De Lara Guarch, Pablo, stable > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara > Sent: Wednesday, June 21, 2017 7:42 AM > To: Doherty, Declan <declan.doherty@intel.com> > Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; stable@dpdk.org > Subject: [dpdk-dev] [PATCH 7/9] examples/l2fwd-crypto: fix auth info display > > Fixes: 4790f99d2d31 ("examples/l2fwd-crypto: use cryptodev algorithm parser") > CC: stable@dpdk.org > > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> Acked-by: Fiona Trahe <fiona.trahe@intel.com> ^ permalink raw reply [flat|nested] 20+ messages in thread
* [dpdk-stable] [PATCH 8/9] app/crypto-perf: fix error message [not found] <20170621064154.25124-1-pablo.de.lara.guarch@intel.com> ` (3 preceding siblings ...) 2017-06-21 6:41 ` [dpdk-stable] [PATCH 7/9] examples/l2fwd-crypto: fix auth info display Pablo de Lara @ 2017-06-21 6:41 ` Pablo de Lara 2017-06-21 16:39 ` [dpdk-stable] [dpdk-dev] " Trahe, Fiona 2017-06-21 6:41 ` [dpdk-stable] [PATCH 9/9] doc: fix typo in l2fwd-crypto usage Pablo de Lara [not found] ` <20170622120235.46063-1-pablo.de.lara.guarch@intel.com> 6 siblings, 1 reply; 20+ messages in thread From: Pablo de Lara @ 2017-06-21 6:41 UTC (permalink / raw) To: declan.doherty; +Cc: dev, Pablo de Lara, stable Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes") CC: stable@dpdk.org Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> --- app/test-crypto-perf/cperf_options_parsing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-crypto-perf/cperf_options_parsing.c index d172671..63ba37c 100644 --- a/app/test-crypto-perf/cperf_options_parsing.c +++ b/app/test-crypto-perf/cperf_options_parsing.c @@ -312,7 +312,7 @@ parse_buffer_sz(struct cperf_options *opts, const char *arg) &opts->min_buffer_size, &opts->max_buffer_size); if (ret < 0) { - RTE_LOG(ERR, USER1, "failed to parse burst size/s\n"); + RTE_LOG(ERR, USER1, "failed to parse buffer size/s\n"); return -1; } opts->buffer_size_count = ret; -- 2.9.4 ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH 8/9] app/crypto-perf: fix error message 2017-06-21 6:41 ` [dpdk-stable] [PATCH 8/9] app/crypto-perf: fix error message Pablo de Lara @ 2017-06-21 16:39 ` Trahe, Fiona 0 siblings, 0 replies; 20+ messages in thread From: Trahe, Fiona @ 2017-06-21 16:39 UTC (permalink / raw) To: De Lara Guarch, Pablo, Doherty, Declan; +Cc: dev, De Lara Guarch, Pablo, stable > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara > Sent: Wednesday, June 21, 2017 7:42 AM > To: Doherty, Declan <declan.doherty@intel.com> > Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; stable@dpdk.org > Subject: [dpdk-dev] [PATCH 8/9] app/crypto-perf: fix error message > > Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes") > CC: stable@dpdk.org > > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> Acked-by: Fiona Trahe <fiona.trahe@intel.com> ^ permalink raw reply [flat|nested] 20+ messages in thread
* [dpdk-stable] [PATCH 9/9] doc: fix typo in l2fwd-crypto usage [not found] <20170621064154.25124-1-pablo.de.lara.guarch@intel.com> ` (4 preceding siblings ...) 2017-06-21 6:41 ` [dpdk-stable] [PATCH 8/9] app/crypto-perf: fix error message Pablo de Lara @ 2017-06-21 6:41 ` Pablo de Lara 2017-06-21 17:44 ` [dpdk-stable] [dpdk-dev] " Trahe, Fiona [not found] ` <20170622120235.46063-1-pablo.de.lara.guarch@intel.com> 6 siblings, 1 reply; 20+ messages in thread From: Pablo de Lara @ 2017-06-21 6:41 UTC (permalink / raw) To: declan.doherty; +Cc: dev, Pablo de Lara, stable Fixes: ba7b86b1419b ("doc: add l2fwd-crypto sample app guide") CC: stable@dpdk.org Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> --- doc/guides/sample_app_ug/l2_forward_crypto.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/sample_app_ug/l2_forward_crypto.rst b/doc/guides/sample_app_ug/l2_forward_crypto.rst index d6df36b..45d8a12 100644 --- a/doc/guides/sample_app_ug/l2_forward_crypto.rst +++ b/doc/guides/sample_app_ug/l2_forward_crypto.rst @@ -135,7 +135,7 @@ where, * auth_algo: select the authentication algorithm (default is sha1-hmac) -* cipher_op: select the authentication operation to perform: GENERATE or VERIFY +* auth_op: select the authentication operation to perform: GENERATE or VERIFY (default is GENERATE) -- 2.9.4 ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH 9/9] doc: fix typo in l2fwd-crypto usage 2017-06-21 6:41 ` [dpdk-stable] [PATCH 9/9] doc: fix typo in l2fwd-crypto usage Pablo de Lara @ 2017-06-21 17:44 ` Trahe, Fiona 0 siblings, 0 replies; 20+ messages in thread From: Trahe, Fiona @ 2017-06-21 17:44 UTC (permalink / raw) To: De Lara Guarch, Pablo, Doherty, Declan; +Cc: dev, De Lara Guarch, Pablo, stable > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara > Sent: Wednesday, June 21, 2017 7:42 AM > To: Doherty, Declan <declan.doherty@intel.com> > Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; stable@dpdk.org > Subject: [dpdk-dev] [PATCH 9/9] doc: fix typo in l2fwd-crypto usage > > Fixes: ba7b86b1419b ("doc: add l2fwd-crypto sample app guide") > CC: stable@dpdk.org > > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> Acked-by: Fiona Trahe <fiona.trahe@intel.com> ^ permalink raw reply [flat|nested] 20+ messages in thread
[parent not found: <20170622120235.46063-1-pablo.de.lara.guarch@intel.com>]
* [dpdk-stable] [PATCH v2 1/9] crypto/aesni_mb: remove assert check [not found] ` <20170622120235.46063-1-pablo.de.lara.guarch@intel.com> @ 2017-06-22 12:02 ` Pablo de Lara 2017-06-23 12:50 ` Declan Doherty 2017-06-22 12:02 ` [dpdk-stable] [PATCH v2 2/9] test/crypto: fix wrong AAD setting Pablo de Lara ` (4 subsequent siblings) 5 siblings, 1 reply; 20+ messages in thread From: Pablo de Lara @ 2017-06-22 12:02 UTC (permalink / raw) To: declan.doherty, fiona.trahe; +Cc: dev, Pablo de Lara, stable Some assert checks in the driver were incorrect, but they are not necessary anyway, as application will panic in any case. Fixes: 0f548b50a160 ("crypto/aesni_mb: process crypto op on dequeue") CC: stable@dpdk.org Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> --- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c index 45b25c9..43e4865 100644 --- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c +++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c @@ -494,8 +494,6 @@ static inline void verify_digest(JOB_AES_HMAC *job, struct rte_crypto_op *op) { struct rte_mbuf *m_dst = (struct rte_mbuf *)job->user_data2; - RTE_ASSERT(m_dst == NULL); - /* Verify digest if required */ if (memcmp(job->auth_tag_output, op->sym->auth.digest.data, job->auth_tag_output_len_in_bytes) != 0) @@ -522,8 +520,6 @@ post_process_mb_job(struct aesni_mb_qp *qp, JOB_AES_HMAC *job) struct aesni_mb_session *sess; - RTE_ASSERT(op == NULL); - if (unlikely(op->status == RTE_CRYPTO_OP_STATUS_ENQUEUED)) { switch (job->status) { case STS_COMPLETED: -- 2.9.4 ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [dpdk-stable] [PATCH v2 1/9] crypto/aesni_mb: remove assert check 2017-06-22 12:02 ` [dpdk-stable] [PATCH v2 1/9] crypto/aesni_mb: remove assert check Pablo de Lara @ 2017-06-23 12:50 ` Declan Doherty 0 siblings, 0 replies; 20+ messages in thread From: Declan Doherty @ 2017-06-23 12:50 UTC (permalink / raw) To: Pablo de Lara, fiona.trahe; +Cc: dev, stable On 22/06/2017 1:02 PM, Pablo de Lara wrote: > Some assert checks in the driver were > incorrect, but they are not necessary anyway, > as application will panic in any case. > > Fixes: 0f548b50a160 ("crypto/aesni_mb: process crypto op on dequeue") > CC: stable@dpdk.org > > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> > --- > drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c > index 45b25c9..43e4865 100644 > --- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c ... > Acked-by: Declan Doherty <declan.doherty@intel.com> ^ permalink raw reply [flat|nested] 20+ messages in thread
* [dpdk-stable] [PATCH v2 2/9] test/crypto: fix wrong AAD setting [not found] ` <20170622120235.46063-1-pablo.de.lara.guarch@intel.com> 2017-06-22 12:02 ` [dpdk-stable] [PATCH v2 1/9] crypto/aesni_mb: remove assert check Pablo de Lara @ 2017-06-22 12:02 ` Pablo de Lara 2017-06-23 9:56 ` Trahe, Fiona 2017-06-22 12:02 ` [dpdk-stable] [PATCH v2 6/9] examples/l2fwd-crypto: fix application help Pablo de Lara ` (3 subsequent siblings) 5 siblings, 1 reply; 20+ messages in thread From: Pablo de Lara @ 2017-06-22 12:02 UTC (permalink / raw) To: declan.doherty, fiona.trahe; +Cc: dev, Pablo de Lara, stable AAD should not point at IV for AES algorithms. For AES-GCM, AAD will point at additional data in the mbuf. For the other algorithms (such as 3DES CBC), AAD is not used. Fixes: ffbe3be0d4b5 ("app/test: add libcrypto") CC: stable@dpdk.org Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> --- test/test/test_cryptodev_perf.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/test/test/test_cryptodev_perf.c b/test/test/test_cryptodev_perf.c index d60028d..894b2dd 100644 --- a/test/test/test_cryptodev_perf.c +++ b/test/test/test_cryptodev_perf.c @@ -2634,6 +2634,11 @@ static uint8_t aes_iv[] = { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 }; +static uint8_t aes_gcm_aad[] = { + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 +}; + static uint8_t triple_des_key[] = { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, @@ -2895,7 +2900,7 @@ test_perf_create_armv8_session(uint8_t dev_id, enum chain_mode chain, #define AES_BLOCK_SIZE 16 #define AES_CIPHER_IV_LENGTH 16 - +#define AES_GCM_AAD_LENGTH 16 #define TRIPLE_DES_BLOCK_SIZE 8 #define TRIPLE_DES_CIPHER_IV_LENGTH 8 @@ -2939,8 +2944,6 @@ test_perf_set_crypto_op_aes(struct rte_crypto_op *op, struct rte_mbuf *m, op->sym->auth.digest.phys_addr = rte_pktmbuf_mtophys_offset(m, AES_CIPHER_IV_LENGTH + data_len); op->sym->auth.digest.length = digest_len; - op->sym->auth.aad.data = aes_iv; - op->sym->auth.aad.length = AES_CIPHER_IV_LENGTH; op->sym->auth.data.offset = AES_CIPHER_IV_LENGTH; op->sym->auth.data.length = data_len; } @@ -2977,8 +2980,8 @@ test_perf_set_crypto_op_aes_gcm(struct rte_crypto_op *op, struct rte_mbuf *m, op->sym->auth.digest.phys_addr = rte_pktmbuf_mtophys_offset(m, data_len); op->sym->auth.digest.length = digest_len; - op->sym->auth.aad.data = aes_iv; - op->sym->auth.aad.length = AES_CIPHER_IV_LENGTH; + op->sym->auth.aad.data = aes_gcm_aad; + op->sym->auth.aad.length = AES_GCM_AAD_LENGTH; /* Cipher Parameters */ op->sym->cipher.iv.data = aes_iv; @@ -3110,8 +3113,6 @@ test_perf_set_crypto_op_3des(struct rte_crypto_op *op, struct rte_mbuf *m, op->sym->auth.digest.phys_addr = rte_pktmbuf_mtophys_offset(m, data_len); op->sym->auth.digest.length = digest_len; - op->sym->auth.aad.data = triple_des_iv; - op->sym->auth.aad.length = TRIPLE_DES_CIPHER_IV_LENGTH; /* Cipher Parameters */ op->sym->cipher.iv.data = triple_des_iv; -- 2.9.4 ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [dpdk-stable] [PATCH v2 2/9] test/crypto: fix wrong AAD setting 2017-06-22 12:02 ` [dpdk-stable] [PATCH v2 2/9] test/crypto: fix wrong AAD setting Pablo de Lara @ 2017-06-23 9:56 ` Trahe, Fiona 0 siblings, 0 replies; 20+ messages in thread From: Trahe, Fiona @ 2017-06-23 9:56 UTC (permalink / raw) To: De Lara Guarch, Pablo, Doherty, Declan; +Cc: dev, stable > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Thursday, June 22, 2017 1:02 PM > To: Doherty, Declan <declan.doherty@intel.com>; Trahe, Fiona <fiona.trahe@intel.com> > Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; stable@dpdk.org > Subject: [PATCH v2 2/9] test/crypto: fix wrong AAD setting > > AAD should not point at IV for AES algorithms. > For AES-GCM, AAD will point at additional data in the mbuf. > For the other algorithms (such as 3DES CBC), AAD is not used. > > Fixes: ffbe3be0d4b5 ("app/test: add libcrypto") > CC: stable@dpdk.org > > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> Acked-by: Fiona Trahe <fiona.trahe@intel.com> ^ permalink raw reply [flat|nested] 20+ messages in thread
* [dpdk-stable] [PATCH v2 6/9] examples/l2fwd-crypto: fix application help [not found] ` <20170622120235.46063-1-pablo.de.lara.guarch@intel.com> 2017-06-22 12:02 ` [dpdk-stable] [PATCH v2 1/9] crypto/aesni_mb: remove assert check Pablo de Lara 2017-06-22 12:02 ` [dpdk-stable] [PATCH v2 2/9] test/crypto: fix wrong AAD setting Pablo de Lara @ 2017-06-22 12:02 ` Pablo de Lara 2017-06-22 12:02 ` [dpdk-stable] [PATCH v2 7/9] examples/l2fwd-crypto: fix auth info display Pablo de Lara ` (2 subsequent siblings) 5 siblings, 0 replies; 20+ messages in thread From: Pablo de Lara @ 2017-06-22 12:02 UTC (permalink / raw) To: declan.doherty, fiona.trahe; +Cc: dev, Pablo de Lara, stable Chain parameter can be CIPHER_HASH, HASH_CIPHER, CIPHER_ONLY or HASH_ONLY, but only the first two were shown in the application help. Fixes: 1a75e9f3fadb ("examples/l2fwd-crypto: add cipher/hash only cases") CC: stable@dpdk.org Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> Acked-by: Fiona Trahe <fiona.trahe@intel.com> --- examples/l2fwd-crypto/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c index 66b4af3..841ec6e 100644 --- a/examples/l2fwd-crypto/main.c +++ b/examples/l2fwd-crypto/main.c @@ -842,7 +842,8 @@ l2fwd_crypto_usage(const char *prgname) " (0 to disable, 10 default, 86400 maximum)\n" " --cdev_type HW / SW / ANY\n" - " --chain HASH_CIPHER / CIPHER_HASH\n" + " --chain HASH_CIPHER / CIPHER_HASH / CIPHER_ONLY /" + " HASH_ONLY\n" " --cipher_algo ALGO\n" " --cipher_op ENCRYPT / DECRYPT\n" -- 2.9.4 ^ permalink raw reply [flat|nested] 20+ messages in thread
* [dpdk-stable] [PATCH v2 7/9] examples/l2fwd-crypto: fix auth info display [not found] ` <20170622120235.46063-1-pablo.de.lara.guarch@intel.com> ` (2 preceding siblings ...) 2017-06-22 12:02 ` [dpdk-stable] [PATCH v2 6/9] examples/l2fwd-crypto: fix application help Pablo de Lara @ 2017-06-22 12:02 ` Pablo de Lara 2017-06-22 12:02 ` [dpdk-stable] [PATCH v2 8/9] app/crypto-perf: fix error message Pablo de Lara 2017-06-22 12:02 ` [dpdk-stable] [PATCH v2 9/9] doc: fix typo in l2fwd-crypto usage Pablo de Lara 5 siblings, 0 replies; 20+ messages in thread From: Pablo de Lara @ 2017-06-22 12:02 UTC (permalink / raw) To: declan.doherty, fiona.trahe; +Cc: dev, Pablo de Lara, stable Fixes: 4790f99d2d31 ("examples/l2fwd-crypto: use cryptodev algorithm parser") CC: stable@dpdk.org Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> Acked-by: Fiona Trahe <fiona.trahe@intel.com> --- examples/l2fwd-crypto/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c index 841ec6e..779b4fb 100644 --- a/examples/l2fwd-crypto/main.c +++ b/examples/l2fwd-crypto/main.c @@ -1263,7 +1263,7 @@ display_auth_info(struct l2fwd_crypto_options *options) { printf("\n---- Authentication information ---\n"); printf("Algorithm: %s\n", - rte_crypto_auth_algorithm_strings[options->auth_xform.cipher.algo]); + rte_crypto_auth_algorithm_strings[options->auth_xform.auth.algo]); rte_hexdump(stdout, "Auth key:", options->auth_xform.auth.key.data, options->auth_xform.auth.key.length); -- 2.9.4 ^ permalink raw reply [flat|nested] 20+ messages in thread
* [dpdk-stable] [PATCH v2 8/9] app/crypto-perf: fix error message [not found] ` <20170622120235.46063-1-pablo.de.lara.guarch@intel.com> ` (3 preceding siblings ...) 2017-06-22 12:02 ` [dpdk-stable] [PATCH v2 7/9] examples/l2fwd-crypto: fix auth info display Pablo de Lara @ 2017-06-22 12:02 ` Pablo de Lara 2017-06-22 12:02 ` [dpdk-stable] [PATCH v2 9/9] doc: fix typo in l2fwd-crypto usage Pablo de Lara 5 siblings, 0 replies; 20+ messages in thread From: Pablo de Lara @ 2017-06-22 12:02 UTC (permalink / raw) To: declan.doherty, fiona.trahe; +Cc: dev, Pablo de Lara, stable Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes") CC: stable@dpdk.org Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> Acked-by: Fiona Trahe <fiona.trahe@intel.com> --- app/test-crypto-perf/cperf_options_parsing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-crypto-perf/cperf_options_parsing.c index d172671..63ba37c 100644 --- a/app/test-crypto-perf/cperf_options_parsing.c +++ b/app/test-crypto-perf/cperf_options_parsing.c @@ -312,7 +312,7 @@ parse_buffer_sz(struct cperf_options *opts, const char *arg) &opts->min_buffer_size, &opts->max_buffer_size); if (ret < 0) { - RTE_LOG(ERR, USER1, "failed to parse burst size/s\n"); + RTE_LOG(ERR, USER1, "failed to parse buffer size/s\n"); return -1; } opts->buffer_size_count = ret; -- 2.9.4 ^ permalink raw reply [flat|nested] 20+ messages in thread
* [dpdk-stable] [PATCH v2 9/9] doc: fix typo in l2fwd-crypto usage [not found] ` <20170622120235.46063-1-pablo.de.lara.guarch@intel.com> ` (4 preceding siblings ...) 2017-06-22 12:02 ` [dpdk-stable] [PATCH v2 8/9] app/crypto-perf: fix error message Pablo de Lara @ 2017-06-22 12:02 ` Pablo de Lara 5 siblings, 0 replies; 20+ messages in thread From: Pablo de Lara @ 2017-06-22 12:02 UTC (permalink / raw) To: declan.doherty, fiona.trahe; +Cc: dev, Pablo de Lara, stable Fixes: ba7b86b1419b ("doc: add l2fwd-crypto sample app guide") CC: stable@dpdk.org Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> Acked-by: Fiona Trahe <fiona.trahe@intel.com> --- doc/guides/sample_app_ug/l2_forward_crypto.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/sample_app_ug/l2_forward_crypto.rst b/doc/guides/sample_app_ug/l2_forward_crypto.rst index d6df36b..45d8a12 100644 --- a/doc/guides/sample_app_ug/l2_forward_crypto.rst +++ b/doc/guides/sample_app_ug/l2_forward_crypto.rst @@ -135,7 +135,7 @@ where, * auth_algo: select the authentication algorithm (default is sha1-hmac) -* cipher_op: select the authentication operation to perform: GENERATE or VERIFY +* auth_op: select the authentication operation to perform: GENERATE or VERIFY (default is GENERATE) -- 2.9.4 ^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2017-06-23 12:50 UTC | newest]
Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20170621064154.25124-1-pablo.de.lara.guarch@intel.com>
2017-06-21 6:41 ` [dpdk-stable] [PATCH 1/9] crypto/aesni_mb: remove assert check Pablo de Lara
2017-06-21 6:41 ` [dpdk-stable] [PATCH 2/9] test/crypto: fix wrong AAD setting Pablo de Lara
2017-06-21 17:39 ` [dpdk-stable] [dpdk-dev] " Trahe, Fiona
2017-06-22 10:40 ` De Lara Guarch, Pablo
2017-06-21 6:41 ` [dpdk-stable] [PATCH 6/9] examples/l2fwd-crypto: fix application help Pablo de Lara
2017-06-21 16:43 ` [dpdk-stable] [dpdk-dev] " Trahe, Fiona
2017-06-21 6:41 ` [dpdk-stable] [PATCH 7/9] examples/l2fwd-crypto: fix auth info display Pablo de Lara
2017-06-21 16:44 ` [dpdk-stable] [dpdk-dev] " Trahe, Fiona
2017-06-21 6:41 ` [dpdk-stable] [PATCH 8/9] app/crypto-perf: fix error message Pablo de Lara
2017-06-21 16:39 ` [dpdk-stable] [dpdk-dev] " Trahe, Fiona
2017-06-21 6:41 ` [dpdk-stable] [PATCH 9/9] doc: fix typo in l2fwd-crypto usage Pablo de Lara
2017-06-21 17:44 ` [dpdk-stable] [dpdk-dev] " Trahe, Fiona
[not found] ` <20170622120235.46063-1-pablo.de.lara.guarch@intel.com>
2017-06-22 12:02 ` [dpdk-stable] [PATCH v2 1/9] crypto/aesni_mb: remove assert check Pablo de Lara
2017-06-23 12:50 ` Declan Doherty
2017-06-22 12:02 ` [dpdk-stable] [PATCH v2 2/9] test/crypto: fix wrong AAD setting Pablo de Lara
2017-06-23 9:56 ` Trahe, Fiona
2017-06-22 12:02 ` [dpdk-stable] [PATCH v2 6/9] examples/l2fwd-crypto: fix application help Pablo de Lara
2017-06-22 12:02 ` [dpdk-stable] [PATCH v2 7/9] examples/l2fwd-crypto: fix auth info display Pablo de Lara
2017-06-22 12:02 ` [dpdk-stable] [PATCH v2 8/9] app/crypto-perf: fix error message Pablo de Lara
2017-06-22 12:02 ` [dpdk-stable] [PATCH v2 9/9] doc: fix typo in l2fwd-crypto usage Pablo de Lara
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).