From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id F08187D66; Thu, 27 Jul 2017 11:03:15 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jul 2017 02:03:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,419,1496127600"; d="scan'208";a="132570374" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by fmsmga006.fm.intel.com with ESMTP; 27 Jul 2017 02:03:13 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.242]) by IRSMSX109.ger.corp.intel.com ([169.254.13.187]) with mapi id 14.03.0319.002; Thu, 27 Jul 2017 10:03:08 +0100 From: "Trahe, Fiona" To: "De Lara Guarch, Pablo" , "Doherty, Declan" CC: "dev@dpdk.org" , "De Lara Guarch, Pablo" , "stable@dpdk.org" , "Trahe, Fiona" Thread-Topic: [dpdk-dev] [PATCH] cryptodev: fix crypto op bulk alloc Doxygen Thread-Index: AQHTBgqtC0+Kz2S4mEuV2DAhHZpFuaJnYHDg Date: Thu, 27 Jul 2017 09:03:08 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B4358923CF56@IRSMSX101.ger.corp.intel.com> References: <20170726042712.8355-1-pablo.de.lara.guarch@intel.com> In-Reply-To: <20170726042712.8355-1-pablo.de.lara.guarch@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODE2MGQ0N2EtNGY5ZC00ZjczLTgyZjktM2RhMjVlZDBlMDgxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjNsZmFJb3FZXC9FQ0dRellWSUljMXd1RFdIdTE2T091alVcL1hIcmJOUTR6UT0ifQ== x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] cryptodev: fix crypto op bulk alloc Doxygen X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jul 2017 09:03:16 -0000 Hi Pablo, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara > Sent: Wednesday, July 26, 2017 5:27 AM > To: Doherty, Declan > Cc: dev@dpdk.org; De Lara Guarch, Pablo ;= stable@dpdk.org > Subject: [dpdk-dev] [PATCH] cryptodev: fix crypto op bulk alloc Doxygen >=20 > When calling rte_crypto_op_bulk_alloc, the function may > return either a 0, if not enough objects are available > in the mempool or the number of operations requested, > it there are enough available. However, the Doxygen comments > were not matching these two cases. >=20 > Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto op oriente= d") > Cc: stable@dpdk.org >=20 > Signed-off-by: Pablo de Lara > --- > lib/librte_cryptodev/rte_crypto.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/lib/librte_cryptodev/rte_crypto.h b/lib/librte_cryptodev/rte= _crypto.h > index 0908368..9f10818 100644 > --- a/lib/librte_cryptodev/rte_crypto.h > +++ b/lib/librte_cryptodev/rte_crypto.h > @@ -266,8 +266,8 @@ rte_crypto_op_alloc(struct rte_mempool *mempool, enum > rte_crypto_op_type type) > * @param nb_ops Number of crypto operations to allocate > * > * @returns > - * - On success returns a valid rte_crypto_op structure > - * - On failure returns NULL > + * - 0 if no operations could be allocated > + * - nb_ops if the number of operations requested were allocated > */ >=20 My first thought was what's returned if some ops could be allocated, but no= t the requested number? Maybe instead: - nb_ops if the number of operations requested were allocated. - 0 if the requested number of ops are not available. None are allocated in= this case. > static inline unsigned > -- > 2.9.4