patches for DPDK stable branches
 help / color / mirror / Atom feed
From: wangyunjian <wangyunjian@huawei.com>
To: Tiwei Bie <tiwei.bie@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
	"zhihong.wang@intel.com" <zhihong.wang@intel.com>,
	xudingke <xudingke@huawei.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v2] net/vhost: fix return value of vhost creates not checked
Date: Tue, 7 Jan 2020 03:15:00 +0000	[thread overview]
Message-ID: <34EFBCA9F01B0748BEB6B629CE643AE60CE0B77C@DGGEMM533-MBX.china.huawei.com> (raw)
In-Reply-To: <20200107023138.GA188880@___>

Thanks, I will fix it in v3.

Yunjian
> -----Original Message-----
> From: Tiwei Bie [mailto:tiwei.bie@intel.com]
> Sent: Tuesday, January 7, 2020 10:32 AM
> To: wangyunjian <wangyunjian@huawei.com>
> Cc: dev@dpdk.org; maxime.coquelin@redhat.com; zhihong.wang@intel.com;
> xudingke <xudingke@huawei.com>; stable@dpdk.org
> Subject: Re: [PATCH v2] net/vhost: fix return value of vhost creates not checked
> 
> On Tue, Dec 17, 2019 at 09:36:17AM +0800, Yunjian Wang wrote:
> >
> > -	eth_dev_vhost_create(dev, iface_name, queues, dev->device.numa_node,
> > -		flags, disable_flags);
> > +	ret = eth_dev_vhost_create(dev, iface_name, queues,
> > +				   dev->device.numa_node, flags, disable_flags);
> > +	if (ret == -1)
> > +		VHOST_LOG(ERR, "Failed to create %s", name);
> 
> A newline is needed at the end of the error message.
> Other than that,
> 
> Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>

      reply	other threads:[~2020-01-07  3:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-17  1:36 Yunjian Wang
2020-01-07  2:31 ` Tiwei Bie
2020-01-07  3:15   ` wangyunjian [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34EFBCA9F01B0748BEB6B629CE643AE60CE0B77C@DGGEMM533-MBX.china.huawei.com \
    --to=wangyunjian@huawei.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    --cc=tiwei.bie@intel.com \
    --cc=xudingke@huawei.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).