patches for DPDK stable branches
 help / color / Atom feed
* [dpdk-stable] [PATCH v2] net/vhost: fix return value of vhost creates not checked
@ 2019-12-17  1:36 Yunjian Wang
  2020-01-07  2:31 ` Tiwei Bie
  0 siblings, 1 reply; 3+ messages in thread
From: Yunjian Wang @ 2019-12-17  1:36 UTC (permalink / raw)
  To: dev
  Cc: maxime.coquelin, tiwei.bie, zhihong.wang, xudingke, Yunjian Wang, stable

The function eth_dev_vhost_create() could return errors,
the return value need to be checked.

Fixes: ee584e9710b9 ("vhost: add driver on top of the library")
Cc: stable@dpdk.org

Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
v2:
 -change function eth_dev_vhost_create return 0 on success
---
 drivers/net/vhost/rte_eth_vhost.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
index 46f01a7..e927669 100644
--- a/drivers/net/vhost/rte_eth_vhost.c
+++ b/drivers/net/vhost/rte_eth_vhost.c
@@ -1302,7 +1302,7 @@ struct vhost_xstats_name_off {
 	}
 
 	rte_eth_dev_probing_finish(eth_dev);
-	return data->port_id;
+	return 0;
 
 error:
 	if (internal) {
@@ -1455,8 +1455,10 @@ struct vhost_xstats_name_off {
 	if (dev->device.numa_node == SOCKET_ID_ANY)
 		dev->device.numa_node = rte_socket_id();
 
-	eth_dev_vhost_create(dev, iface_name, queues, dev->device.numa_node,
-		flags, disable_flags);
+	ret = eth_dev_vhost_create(dev, iface_name, queues,
+				   dev->device.numa_node, flags, disable_flags);
+	if (ret == -1)
+		VHOST_LOG(ERR, "Failed to create %s", name);
 
 out_free:
 	rte_kvargs_free(kvlist);
-- 
1.8.3.1



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH v2] net/vhost: fix return value of vhost creates not checked
  2019-12-17  1:36 [dpdk-stable] [PATCH v2] net/vhost: fix return value of vhost creates not checked Yunjian Wang
@ 2020-01-07  2:31 ` Tiwei Bie
  2020-01-07  3:15   ` wangyunjian
  0 siblings, 1 reply; 3+ messages in thread
From: Tiwei Bie @ 2020-01-07  2:31 UTC (permalink / raw)
  To: Yunjian Wang; +Cc: dev, maxime.coquelin, zhihong.wang, xudingke, stable

On Tue, Dec 17, 2019 at 09:36:17AM +0800, Yunjian Wang wrote:
>  
> -	eth_dev_vhost_create(dev, iface_name, queues, dev->device.numa_node,
> -		flags, disable_flags);
> +	ret = eth_dev_vhost_create(dev, iface_name, queues,
> +				   dev->device.numa_node, flags, disable_flags);
> +	if (ret == -1)
> +		VHOST_LOG(ERR, "Failed to create %s", name);

A newline is needed at the end of the error message.
Other than that,

Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH v2] net/vhost: fix return value of vhost creates not checked
  2020-01-07  2:31 ` Tiwei Bie
@ 2020-01-07  3:15   ` wangyunjian
  0 siblings, 0 replies; 3+ messages in thread
From: wangyunjian @ 2020-01-07  3:15 UTC (permalink / raw)
  To: Tiwei Bie; +Cc: dev, maxime.coquelin, zhihong.wang, xudingke, stable

Thanks, I will fix it in v3.

Yunjian
> -----Original Message-----
> From: Tiwei Bie [mailto:tiwei.bie@intel.com]
> Sent: Tuesday, January 7, 2020 10:32 AM
> To: wangyunjian <wangyunjian@huawei.com>
> Cc: dev@dpdk.org; maxime.coquelin@redhat.com; zhihong.wang@intel.com;
> xudingke <xudingke@huawei.com>; stable@dpdk.org
> Subject: Re: [PATCH v2] net/vhost: fix return value of vhost creates not checked
> 
> On Tue, Dec 17, 2019 at 09:36:17AM +0800, Yunjian Wang wrote:
> >
> > -	eth_dev_vhost_create(dev, iface_name, queues, dev->device.numa_node,
> > -		flags, disable_flags);
> > +	ret = eth_dev_vhost_create(dev, iface_name, queues,
> > +				   dev->device.numa_node, flags, disable_flags);
> > +	if (ret == -1)
> > +		VHOST_LOG(ERR, "Failed to create %s", name);
> 
> A newline is needed at the end of the error message.
> Other than that,
> 
> Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-17  1:36 [dpdk-stable] [PATCH v2] net/vhost: fix return value of vhost creates not checked Yunjian Wang
2020-01-07  2:31 ` Tiwei Bie
2020-01-07  3:15   ` wangyunjian

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox