From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 93053A0351
	for <public@inbox.dpdk.org>; Thu,  6 Aug 2020 14:47:36 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 8AE0F2BF1;
	Thu,  6 Aug 2020 14:47:36 +0200 (CEST)
Received: from huawei.com (szxga08-in.huawei.com [45.249.212.255])
 by dpdk.org (Postfix) with ESMTP id 6AAE52BF1;
 Thu,  6 Aug 2020 14:47:34 +0200 (CEST)
Received: from DGGEMM405-HUB.china.huawei.com (unknown [172.30.72.53])
 by Forcepoint Email with ESMTP id 7DC9FEFE56047771B435;
 Thu,  6 Aug 2020 20:47:31 +0800 (CST)
Received: from DGGEMM533-MBX.china.huawei.com ([169.254.5.24]) by
 DGGEMM405-HUB.china.huawei.com ([10.3.20.213]) with mapi id 14.03.0487.000;
 Thu, 6 Aug 2020 20:47:24 +0800
From: wangyunjian <wangyunjian@huawei.com>
To: Thomas Monjalon <thomas@monjalon.net>
CC: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>,
 "keith.wiles@intel.com" <keith.wiles@intel.com>, "ophirmu@mellanox.com"
 <ophirmu@mellanox.com>, "Lilijun (Jerry)" <jerry.lilijun@huawei.com>,
 xudingke <xudingke@huawei.com>, "stable@dpdk.org" <stable@dpdk.org>
Thread-Topic: [dpdk-stable] [dpdk-dev] [PATCH] net/tap: free mempool when
 closing
Thread-Index: AQHWZZzOozuoX/cl2U+8EaesNm5Ws6kpDJsAgAIHZIA=
Date: Thu, 6 Aug 2020 12:47:24 +0000
Message-ID: <34EFBCA9F01B0748BEB6B629CE643AE60D11127C@DGGEMM533-MBX.china.huawei.com>
References: <40a0e68ed41b05fba8cbe5f34e369a59a1c0c09c.1596022448.git.wangyunjian@huawei.com>
 <4268011.XMymgrSB0u@thomas>
In-Reply-To: <4268011.XMymgrSB0u@thomas>
Accept-Language: en-US
Content-Language: zh-CN
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.174.185.168]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/tap: free mempool when
 closing
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Wednesday, August 5, 2020 9:48 PM
> To: wangyunjian <wangyunjian@huawei.com>
> Cc: dev@dpdk.org; stable@dpdk.org; keith.wiles@intel.com;
> ophirmu@mellanox.com; Lilijun (Jerry) <jerry.lilijun@huawei.com>; xudingk=
e
> <xudingke@huawei.com>; wangyunjian <wangyunjian@huawei.com>;
> stable@dpdk.org
> Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/tap: free mempool when
> closing
>=20
> 29/07/2020 13:35, wangyunjian:
> > From: Yunjian Wang <wangyunjian@huawei.com>
> >
> > When setup tx queues, we will create a mempool for the 'gso_ctx'.
> > The mempool is not freed when closing tap device. If free the tap
> > device and create it with different name, it will create a new
> > mempool. This maybe cause an OOM.
>=20
> While at it, please look at implementing RTE_ETH_DEV_CLOSE_REMOVE
> behaviour in tap. Thanks
>=20

I read the codes about tap device. Currently, the tap pmd doesn't
use RTE_ETH_DEV_CLOSE_REMOVE flag.

Thanks,
Yunjian