From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28521A09E5 for ; Mon, 7 Dec 2020 14:08:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EFCF64C8E; Mon, 7 Dec 2020 14:07:59 +0100 (CET) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by dpdk.org (Postfix) with ESMTP id 267D5A3; Mon, 7 Dec 2020 14:07:56 +0100 (CET) Received: from DGGEMM403-HUB.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4CqNr54PTqz13R77; Mon, 7 Dec 2020 21:07:01 +0800 (CST) Received: from DGGEMM533-MBX.china.huawei.com ([169.254.5.12]) by DGGEMM403-HUB.china.huawei.com ([10.3.20.211]) with mapi id 14.03.0487.000; Mon, 7 Dec 2020 21:07:45 +0800 From: wangyunjian To: Liron Himi , "dev@dpdk.org" CC: "zr@semihalf.com" , "Lilijun (Jerry)" , xudingke , "stable@dpdk.org" Thread-Topic: [EXT] [dpdk-dev] [PATCH] net/mvneta: check allocation in rx queue flush Thread-Index: AQHWzI1UrnJmaQHtPkGdAWrRnBvEVqnrDFwAgACK64A= Date: Mon, 7 Dec 2020 13:07:45 +0000 Message-ID: <34EFBCA9F01B0748BEB6B629CE643AE60DB5CC89@DGGEMM533-MBX.china.huawei.com> References: <1607341035-9372-1-git-send-email-wangyunjian@huawei.com> In-Reply-To: Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.243.127] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected Subject: Re: [dpdk-stable] [EXT] [dpdk-dev] [PATCH] net/mvneta: check allocation in rx queue flush X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Liron Himi [mailto:lironh@marvell.com] > Sent: Monday, December 7, 2020 8:38 PM > To: wangyunjian ; dev@dpdk.org > Cc: zr@semihalf.com; Lilijun (Jerry) ; xudingke > ; stable@dpdk.org; Liron Himi > Subject: RE: [EXT] [dpdk-dev] [PATCH] net/mvneta: check allocation in rx = queue > flush >=20 > Hi, >=20 > How about use 2 local arrays for descs & bufs instead of the malloc/free? The definition of these 2 arrays is 2048. If it is a local array, is it too= large? >=20 > Liron >=20 >=20 > -----Original Message----- > From: wangyunjian > Sent: Monday, 7 December 2020 13:37 > To: dev@dpdk.org > Cc: Liron Himi ; zr@semihalf.com; > jerry.lilijun@huawei.com; xudingke@huawei.com; Yunjian Wang > ; stable@dpdk.org > Subject: [EXT] [dpdk-dev] [PATCH] net/mvneta: check allocation in rx queu= e flush >=20 > External Email >=20 > ---------------------------------------------------------------------- > From: Yunjian Wang >=20 > The function rte_malloc() could return NULL, the return value need to be > checked. >=20 > Fixes: ce7ea764597e ("net/mvneta: support Rx/Tx") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yunjian Wang > --- > drivers/net/mvneta/mvneta_rxtx.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) >=20 > diff --git a/drivers/net/mvneta/mvneta_rxtx.c > b/drivers/net/mvneta/mvneta_rxtx.c > index 10b6f57584..dfa7ecc090 100644 > --- a/drivers/net/mvneta/mvneta_rxtx.c > +++ b/drivers/net/mvneta/mvneta_rxtx.c > @@ -872,7 +872,17 @@ mvneta_rx_queue_flush(struct mvneta_rxq *rxq) > int ret, i; >=20 > descs =3D rte_malloc("rxdesc", MRVL_NETA_RXD_MAX * sizeof(*descs), 0); > + if (descs =3D=3D NULL) { > + MVNETA_LOG(ERR, "Failed to allocate descs."); > + return; > + } > + > bufs =3D rte_malloc("buffs", MRVL_NETA_RXD_MAX * sizeof(*bufs), 0); > + if (bufs =3D=3D NULL) { > + MVNETA_LOG(ERR, "Failed to allocate bufs."); > + rte_free(descs); > + return; > + } >=20 > do { > num =3D MRVL_NETA_RXD_MAX; > -- > 2.23.0