From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 9A8A42BE2; Tue, 6 Nov 2018 13:29:22 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A5C9522139; Tue, 6 Nov 2018 07:29:21 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 06 Nov 2018 07:29:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=S8oWX7pNJxq8TlJAt4XB7E6k0c7m0p8RL2F9aOu8bTg=; b=oWNa2BDSm4tn 2q78yduzow8pQT284rCcynqibPbGkc35DfC+4xUGoynOb8d55r/O3Qra3fzc1Wao PM3Ahwe+GvRRPz2CoDXwMZjN3DCt5OAOxhBXLKn9WUt8mpA31vxFgqO2q5Z2q0/I /p5Ld6Ir7sKehHlZlFduTyC/kunUd2A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=S8oWX7pNJxq8TlJAt4XB7E6k0c7m0p8RL2F9aOu8b Tg=; b=VZ2F6SF4zIDfjnb23zA3lfm0hpscRZJcl7HcYBLF5M0H/1NC5dWl5K6xp TvYz2LUxZ+KZ9qZ1R6Ig7yHzKbDdDzW0hadW5Nj4sd/jnyJQuCe+4nTfmKP8bK4d re+dyknLMDT/IbS0Ntriwr+6qFFeXVV21eiV4IZZBki+omAmRnyohcK0S2qqQAiv lxnRoRuUYjZ5MrZm9h9HZ9+4JsKiAuew3Z/z5MAbNsJS1bqnr9jrZkABY1bGALTr HO9TOVYvYBMxnPC33EEy9fie62Rpro/G0BE9HLijipxGDphe5Rro+yr89f0Z1b+i 5BnrZQTJ/f1eN/x8/vHIKOfs975eg== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 50F3DE4430; Tue, 6 Nov 2018 07:29:20 -0500 (EST) From: Thomas Monjalon To: Jerin Jacob Cc: "dev@dpdk.org" , "Jacob, Jerin" , "stable@dpdk.org" Date: Tue, 06 Nov 2018 13:29:19 +0100 Message-ID: <3520386.84pXejHKmD@xps> In-Reply-To: <20181106114435.14770-1-jerin.jacob@caviumnetworks.com> References: <20181106114435.14770-1-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] eal: fix build issue X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2018 12:29:22 -0000 06/11/2018 12:45, Jerin Jacob: > Some toolchain has fls() definition in string.h as argument type int, > which is conflicting uint32_t argument type. >=20 > /export/dpdk.org/lib/librte_eal/common/rte_reciprocal.c:47:19: > error: conflicting types for =E2=80=98fls=E2=80=99 > static inline int fls(uint32_t x) > ^~~ >=20 > /opt/marvell-tools-201/aarch64-marvell-elf/include/strings.h:59:6: > note: previous declaration of =E2=80=98fls=E2=80=99 was here > int fls(int) __pure2; >=20 > FreeBSD string.h also has fls() with argument as int type. > https://www.freebsd.org/cgi/man.cgi?query=3Dfls&sektion=3D3 >=20 > Fixing the conflict by renaming internal function as __fls Why not rte_fls? Would it be more future proof?