* [PATCH 20.11] net/octeontx2:: fix base rule merge
@ 2022-02-18 3:56 psatheesh
2022-02-18 12:53 ` Luca Boccassi
0 siblings, 1 reply; 2+ messages in thread
From: psatheesh @ 2022-02-18 3:56 UTC (permalink / raw)
To: Jerin Jacob, Nithin Dabilpuram, Kiran Kumar K; +Cc: stable, Satheesh Paul
From: Satheesh Paul <psatheesh@marvell.com>
Egress rules do not have a base steering rule and the
current base steering rule is applicable only for ingress
rules. Hence, when creating a flow rule, merge base steering
rule only for ingress rules.
Fixes: ce3a1c3164 ("net/octeontx2: support VF base steering rule")
Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
Reviewed-by: Kiran Kumar Kokkilagadda <kirankumark@marvell.com>
---
drivers/net/octeontx2/otx2_flow_utils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/octeontx2/otx2_flow_utils.c b/drivers/net/octeontx2/otx2_flow_utils.c
index 7ed86ba742..31277adcb4 100644
--- a/drivers/net/octeontx2/otx2_flow_utils.c
+++ b/drivers/net/octeontx2/otx2_flow_utils.c
@@ -909,7 +909,7 @@ otx2_flow_mcam_alloc_and_write(struct rte_flow *flow, struct otx2_mbox *mbox,
return NPC_MCAM_ALLOC_FAILED;
}
- if (pst->is_vf) {
+ if (pst->is_vf && flow->nix_intf == OTX2_INTF_RX) {
(void)otx2_mbox_alloc_msg_npc_read_base_steer_rule(mbox);
rc = otx2_mbox_process_msg(mbox, (void *)&base_rule_rsp);
if (rc) {
--
2.25.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 20.11] net/octeontx2:: fix base rule merge
2022-02-18 3:56 [PATCH 20.11] net/octeontx2:: fix base rule merge psatheesh
@ 2022-02-18 12:53 ` Luca Boccassi
0 siblings, 0 replies; 2+ messages in thread
From: Luca Boccassi @ 2022-02-18 12:53 UTC (permalink / raw)
To: psatheesh, Jerin Jacob, Nithin Dabilpuram, Kiran Kumar K; +Cc: stable
On Fri, 2022-02-18 at 09:26 +0530, psatheesh@marvell.com wrote:
> From: Satheesh Paul <psatheesh@marvell.com>
>
> Egress rules do not have a base steering rule and the
> current base steering rule is applicable only for ingress
> rules. Hence, when creating a flow rule, merge base steering
> rule only for ingress rules.
>
> Fixes: ce3a1c3164 ("net/octeontx2: support VF base steering rule")
>
> Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
> Reviewed-by: Kiran Kumar Kokkilagadda <kirankumark@marvell.com>
> ---
> drivers/net/octeontx2/otx2_flow_utils.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/octeontx2/otx2_flow_utils.c b/drivers/net/octeontx2/otx2_flow_utils.c
> index 7ed86ba742..31277adcb4 100644
> --- a/drivers/net/octeontx2/otx2_flow_utils.c
> +++ b/drivers/net/octeontx2/otx2_flow_utils.c
> @@ -909,7 +909,7 @@ otx2_flow_mcam_alloc_and_write(struct rte_flow *flow, struct otx2_mbox *mbox,
> return NPC_MCAM_ALLOC_FAILED;
> }
>
>
> - if (pst->is_vf) {
> + if (pst->is_vf && flow->nix_intf == OTX2_INTF_RX) {
> (void)otx2_mbox_alloc_msg_npc_read_base_steer_rule(mbox);
> rc = otx2_mbox_process_msg(mbox, (void *)&base_rule_rsp);
> if (rc) {
Thanks, applied and pushed.
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-18 12:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-18 3:56 [PATCH 20.11] net/octeontx2:: fix base rule merge psatheesh
2022-02-18 12:53 ` Luca Boccassi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).