From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 8B09625A1; Thu, 28 Dec 2017 10:05:18 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1459820AD6; Thu, 28 Dec 2017 04:05:18 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 28 Dec 2017 04:05:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=X60dYKd3ifv9xqo2KSB1U3gy18 7XcCh+y4YOKZUqu10=; b=LvpHp3fw9/4bfaxdm8VDxrwwb1xb0rzVWEmM8N6FY0 +3MdKa6rWGMfFwAjsytzJ+oGiT9N9hFj7mnUfJqsipk81DX0xPfgi5H0x/9KDOV2 nM0aa0RMsk/tQKyr+rcuFlfOJJxCbZVYyNenc0wdaJYnBXGXWOWvWaf29v+ccVup 0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=X60dYK d3ifv9xqo2KSB1U3gy187XcCh+y4YOKZUqu10=; b=eOLSDNryXRmtN5TyV4YDxQ MmiK3TarDlxIdGCWzqPjnzywD2ejbImuZMA9PYAhg5Kwie2+opdg9Xpc5tESQYD9 XJsddzlFhiYHcy86qO8RqLVl1CDwtADjXOsdl3KvWjDQxrxCU9ANEyGSkNyWJihM A0NT2Qqv31ttWxuXArq7ELenin2j9wVCtlBc/ddhlzJHWhL0jLhMIoc6FShy0udI HbtujvX12pebTQYv/UuGTsI1CW6D6l8o+Byo7EZMgTiWMJQhi02NnpuXVo/zuqTs 5Ekcy1QGngKAthrwdCTtAN5+AHzJExb6oVvjkKBz3Si8l0sKio+KZoYvhs7sog8Q == X-ME-Sender: Received: from xps.localnet (gra86-3-88-182-229-223.fbx.proxad.net [88.182.229.223]) by mail.messagingengine.com (Postfix) with ESMTPA id B73DC7E1DE; Thu, 28 Dec 2017 04:05:17 -0500 (EST) From: Thomas Monjalon To: Zhiyong Yang Cc: dev@dpdk.org, ferruh.yigit@intel.com, stable@dpdk.org Date: Thu, 28 Dec 2017 10:05:06 +0100 Message-ID: <3562024.UbNHMEjv39@xps> In-Reply-To: <20171228061210.64767-1-zhiyong.yang@intel.com> References: <20171228061210.64767-1-zhiyong.yang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [PATCH] bus/pci: fix wrong intr_handle.type with uio_pci_generic X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Dec 2017 09:05:18 -0000 28/12/2017 07:12, Zhiyong Yang: > In the function rte_pci_ioport_map, if uio_pci_generic is used on X86 > platform, pci_ioport_map() is invoked, the operation > ev->intr_handle.type = RTE_INTR_HANDLE_UNKNOWN; is execused directly, > it causes the wrong assignment for uio_pci_generic, the patch fixes it. [...] > --- a/drivers/bus/pci/linux/pci.c > +++ b/drivers/bus/pci/linux/pci.c > @@ -723,7 +723,9 @@ pci_ioport_map(struct rte_pci_device *dev, int bar __rte_unused, > if (!found) > return -1; > > - dev->intr_handle.type = RTE_INTR_HANDLE_UNKNOWN; > + if (dev->kdrv == RTE_KDRV_NONE) > + dev->intr_handle.type = RTE_INTR_HANDLE_UNKNOWN; I don't understand the logic. NONE is different of UNKNOWN. Your are talking about uio_pci_generic. In this case, it should be RTE_KDRV_UIO_GENERIC.